Hash :
879f90d2
Author :
Date :
2018-03-01T11:45:20
Vulkan: Avoid recopying the data every time we draw line loops Use the Observer pattern to get notified when the BufferVk we've copied our data from is changing. We will only recopy the data if anything has changed, but otherwise we'll keep drawing with the same index buffer we've created previously. Bug: angleproject:2335 Change-Id: Ib65677b4d5ec90c46a5e3b975fffd1fddeed59e7 Reviewed-on: https://chromium-review.googlesource.com/948622 Commit-Queue: Luc Ferron <lucferron@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123
//
// Copyright 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Observer:
// Implements the Observer pattern for sending state change notifications
// from Subject objects to dependent Observer objects.
//
// See design document:
// https://docs.google.com/document/d/15Edfotqg6_l1skTEL8ADQudF_oIdNa7i8Po43k6jMd4/
#include "libANGLE/Observer.h"
#include <algorithm>
#include "common/debug.h"
namespace angle
{
// Observer implementation.
ObserverInterface::~ObserverInterface() = default;
// Subject implementation.
Subject::Subject()
{
}
Subject::~Subject()
{
resetObservers();
}
bool Subject::hasObservers() const
{
return !mObservers.empty();
}
void Subject::addObserver(ObserverBinding *observer)
{
ASSERT(std::find(mObservers.begin(), mObservers.end(), observer) == mObservers.end());
mObservers.push_back(observer);
}
void Subject::removeObserver(ObserverBinding *observer)
{
auto iter = std::find(mObservers.begin(), mObservers.end(), observer);
ASSERT(iter != mObservers.end());
mObservers.erase(iter);
}
void Subject::onStateChange(const gl::Context *context, SubjectMessage message) const
{
if (mObservers.empty())
return;
for (const angle::ObserverBinding *receiver : mObservers)
{
receiver->onStateChange(context, message);
}
}
void Subject::resetObservers()
{
for (angle::ObserverBinding *observer : mObservers)
{
observer->onSubjectReset();
}
mObservers.clear();
}
// ObserverBinding implementation.
ObserverBinding::ObserverBinding(ObserverInterface *observer, SubjectIndex index)
: mSubject(nullptr), mObserver(observer), mIndex(index)
{
ASSERT(observer);
}
ObserverBinding::~ObserverBinding()
{
reset();
}
ObserverBinding::ObserverBinding(const ObserverBinding &other) = default;
ObserverBinding &ObserverBinding::operator=(const ObserverBinding &other) = default;
void ObserverBinding::bind(Subject *subject)
{
ASSERT(mObserver);
if (mSubject)
{
mSubject->removeObserver(this);
}
mSubject = subject;
if (mSubject)
{
mSubject->addObserver(this);
}
}
void ObserverBinding::reset()
{
bind(nullptr);
}
void ObserverBinding::onStateChange(const gl::Context *context, SubjectMessage message) const
{
mObserver->onSubjectStateChange(context, mIndex, message);
}
void ObserverBinding::onSubjectReset()
{
mSubject = nullptr;
}
const Subject *ObserverBinding::getSubject() const
{
return mSubject;
}
} // namespace angle