kc3-lang/angle/src/compiler/preprocessor/numeric_lex.h

• Show log

  Commit

• Hash : ec17d54a
  Author :
  Date : 2015-08-13T12:19:28
  

  Fix angle miscompiling shaders on x86_64 Android.
  
  BUG=487341
  Change-Id: I792e0c9419566facb0bec0ad93f3646294e5a2a7
  Reviewed-on: https://chromium-review.googlesource.com/293500
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Tested-by: Nico Weber <thakis@chromium.org>
  Reviewed-by: Nico Weber <thakis@chromium.org>
  

Download

• src/compiler/preprocessor/numeric_lex.h

• //
  // Copyright (c) 2012 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // numeric_lex.h: Functions to extract numeric values from string.
  
  #ifndef COMPILER_PREPROCESSOR_NUMERICLEX_H_
  #define COMPILER_PREPROCESSOR_NUMERICLEX_H_
  
  #include <sstream>
  
  namespace pp {
  
  inline std::ios::fmtflags numeric_base_int(const std::string &str)
  {
      if ((str.size() >= 2) &&
          (str[0] == '0') &&
          (str[1] == 'x' || str[1] == 'X'))
      {
          return std::ios::hex;
      }
      if ((str.size() >= 1) && (str[0] == '0'))
      {
          return std::ios::oct;
      }
      return std::ios::dec;
  }
  
  // The following functions parse the given string to extract a numerical
  // value of the given type. These functions assume that the string is
  // of the correct form. They can only fail if the parsed value is too big,
  // in which case false is returned.
  
  template<typename IntType>
  bool numeric_lex_int(const std::string &str, IntType *value)
  {
      std::istringstream stream(str);
      // This should not be necessary, but MSVS has a buggy implementation.
      // It returns incorrect results if the base is not specified.
      stream.setf(numeric_base_int(str), std::ios::basefield);
  
      stream >> (*value);
      return !stream.fail();
  }
  
  template<typename FloatType>
  bool numeric_lex_float(const std::string &str, FloatType *value)
  {
  // On 64-bit Intel Android, istringstream is broken.  Until this is fixed in
  // a newer NDK, don't use it.  Android doesn't have locale support, so this
  // doesn't have to force the C locale.
  // TODO(thakis): Remove this once this bug has been fixed in the NDK and
  // that NDK has been rolled into chromium.
  #if defined(ANGLE_PLATFORM_ANDROID) && __x86_64__
      *value = strtod(str.c_str(), nullptr);
      return errno != ERANGE;
  #else
      std::istringstream stream(str);
      // Force "C" locale so that decimal character is always '.', and
      // not dependent on the current locale.
      stream.imbue(std::locale::classic());
  
      stream >> (*value);
      return !stream.fail();
  #endif
  }
  
  } // namespace pp.
  
  #endif // COMPILER_PREPROCESSOR_NUMERICLEX_H_
  

Download