kc3-lang/angle/src/tests/test_expectations/GPUTestExpectationsParser.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : Jonah Ryan-Davis
  Date : 2019-04-15 14:53:01
  Hash : c832cdd7
  Message : dEQP test_expectations parser should output an error on unused lines. dEQP test_expectations parser should allow nested overrides. When an expectation line is not used for any test, it's likely duplicated or misspelled, or the test was removed. The parser should output these errors to make it easier to keep the expectations up to date. Also necessary to allow longer/more specific expectations to override shorter ones, so the scenario where you FAIL one set of tests across platforms, and SKIP a subset of that group on one platform will still be allowed. Bug: angleproject:3368 Change-Id: If0470cb6fb12f8d3daa97df0c701185fa086668c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564725 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>

• src/tests/test_expectations/GPUTestExpectationsParser.h

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifndef TEST_EXPECTATIONS_GPU_TEST_EXPECTATIONS_PARSER_H_
  #define TEST_EXPECTATIONS_GPU_TEST_EXPECTATIONS_PARSER_H_
  
  #include <stddef.h>
  #include <stdint.h>
  
  #include <string>
  #include <vector>
  
  namespace angle
  {
  
  struct GPUTestConfig;
  
  class GPUTestExpectationsParser
  {
    public:
      enum GPUTestExpectation
      {
          kGpuTestPass    = 1 << 0,
          kGpuTestFail    = 1 << 1,
          kGpuTestFlaky   = 1 << 2,
          kGpuTestTimeout = 1 << 3,
          kGpuTestSkip    = 1 << 4,
      };
  
      GPUTestExpectationsParser();
      ~GPUTestExpectationsParser();
  
      // Parse the text expectations, and if no error is encountered,
      // save all the entries. Otherwise, generate error messages.
      // Return true if parsing succeeds.
      bool loadTestExpectations(const GPUTestConfig &config, const std::string &data);
      bool loadTestExpectationsFromFile(const GPUTestConfig &config, const std::string &path);
  
      // Query error messages from the last LoadTestExpectations() call.
      const std::vector<std::string> &getErrorMessages() const;
  
      // Query error messages from any expectations that weren't used before being queried.
      std::vector<std::string> getUnusedExpectationsMessages() const;
  
      // Get the test expectation of a given test on a given bot.
      int32_t getTestExpectation(const std::string &testName);
  
    private:
      struct GPUTestExpectationEntry
      {
          GPUTestExpectationEntry();
  
          std::string testName;
          int32_t testExpectation;
          size_t lineNumber;
          bool used;
      };
  
      // Parse a line of text. If we have a valid entry, save it; otherwise,
      // generate error messages.
      bool parseLine(const GPUTestConfig &config, const std::string &lineData, size_t lineNumber);
  
      // Check a the condition assigned to a particular token.
      bool checkTokenCondition(const GPUTestConfig &config,
                               bool &err,
                               int32_t token,
                               size_t lineNumber);
  
      // Check if two entries' config overlap with each other. May generate an
      // error message.
      bool detectConflictsBetweenEntries();
  
      // Query a list of any expectations that were's used before being queried.
      std::vector<GPUTestExpectationEntry> getUnusedExpectations() const;
  
      // Save an error message, which can be queried later.
      void pushErrorMessage(const std::string &message, size_t lineNumber);
      void pushErrorMessage(const std::string &message,
                            size_t entry1LineNumber,
                            size_t entry2LineNumber);
  
      std::vector<GPUTestExpectationEntry> mEntries;
      std::vector<std::string> mErrorMessages;
  };
  
  }  // namespace angle
  
  #endif  // TEST_EXPECTATIONS_GPU_TEST_EXPECTATIONS_PARSER_H_