-
Show log
Commit
-
Hash : 0e9e321b
Author :
Date : 2021-11-01T17:04:05
Metal: Anonymous unused uniform structs not named. Due to some upstream changes, unused uniform structs are not being given a name. These structs cause compilation failures, which has completely caused shadertoy.com to fail to render. Skip the check when naming embedded structs to allow uniform struct types to still be named, even when no uniform exists. Unskip targeted tests on the Metal backend which were added previously in Issue 6641. These still need to be fixed more generically for the Vulkan backend. Also suppress flaky WebGLCompatibilityTest.RG32FTextures test on Mac Intel OpenGL, which affected this CL. Bug: angleproject:6642 Bug: angleproject:6641 Bug: angleproject:6570 Change-Id: I598fc212f4db3d3b7c5617bd8a87f8b7db60706c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258341 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
-
Files
- AddExplicitTypeCasts.cpp
- AddExplicitTypeCasts.h
- AstHelpers.cpp
- AstHelpers.h
- DebugSink.h
- DiscoverDependentFunctions.cpp
- DiscoverDependentFunctions.h
- DiscoverEnclosingFunctionTraverser.cpp
- DiscoverEnclosingFunctionTraverser.h
- EmitMetal.cpp
- EmitMetal.h
- FixTypeConstructors.cpp
- FixTypeConstructors.h
- HoistConstants.cpp
- HoistConstants.h
- IdGen.cpp
- IdGen.h
- IntermRebuild.h
- IntroduceVertexIndexID.cpp
- IntroduceVertexIndexID.h
- Layout.cpp
- Layout.h
- MapFunctionsToDefinitions.cpp
- MapFunctionsToDefinitions.h
- MapSymbols.cpp
- MapSymbols.h
- ModifyStruct.cpp
- ModifyStruct.h
- Name.cpp
- Name.h
- NameEmbeddedUniformStructsMetal.cpp
- NameEmbeddedUniformStructsMetal.h
- Pipeline.cpp
- Pipeline.h
- ProgramPrelude.cpp
- ProgramPrelude.h
- ReduceInterfaceBlocks.cpp
- ReduceInterfaceBlocks.h
- Reference.h
- RewriteCaseDeclarations.cpp
- RewriteCaseDeclarations.h
- RewriteOutArgs.cpp
- RewriteOutArgs.h
- RewritePipelines.cpp
- RewritePipelines.h
- RewriteUnaddressableReferences.cpp
- RewriteUnaddressableReferences.h
- SeparateCompoundExpressions.cpp
- SeparateCompoundExpressions.h
- SeparateCompoundStructDeclarations.cpp
- SeparateCompoundStructDeclarations.h
- SkippingTraverser.h
- SymbolEnv.cpp
- SymbolEnv.h
- ToposortStructs.cpp
- ToposortStructs.h
- TranslatorMetalUtils.cpp
- TranslatorMetalUtils.h
- TransposeRowMajorMatrices.cpp
- TransposeRowMajorMatrices.h
- WrapMain.cpp
- WrapMain.h
