kc3-lang/angle/src/tests/compiler_tests/APPLE_clip_distance_test.cpp

• Show log

  Commit

• Hash : f3d5dac3
  Author :
  Date : 2021-08-23T17:25:15
  

  Vulkan: SPIR-V Gen: Drop dependency to glslang
  
  The SPIR-V gen path is now made default.  Compilation through glslang is
  still supported for debugging, and is enabled on the GLSL* end2end tests
  for smoke testing.  On release builds, glslang is not supported.
  
  To test with glslang, add the following gn arg (only necessary if dcheck
  is disabled):
  
      angle_enable_spirv_gen_through_glslang = true
  
  Then enable the generateSPIRVThroughGlslang feature.  This can be done
  by setting an environment variable:
  
      ANGLE_FEATURE_OVERRIDES_ENABLED=generateSPIRVThroughGlslang ./angle_deqp_gles2_tests
  
  Binary size saving:
  
  - 1.3MB on Linux (SPIR-V gen itself: 240KB)
  - 730KB on Android (SPIR-V gen itself: 140KB)
  
  Perf tests:
  
  - LinkProgramBenchmark.Run/vulkan_compile_single_thread
    * Through glslang:
        truncated mean: 1287033.36
    * Direct SPIR-V Gen:
        truncated mean: 244495.91  (~80% reduction)
  
  - LinkProgramBenchmark.Run/vulkan_compile_multi_thread
    * Through glslang:
        truncated mean: 4565894.83
    * Direct SPIR-V Gen:
        truncated mean: 1158164.10  (~75% reduction)
  
  Bug: angleproject:4889
  Bug: angleproject:6210
  Change-Id: I486342702977c8114e90073b97183aba115a8b2d
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3115140
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  

Download

• src/tests/compiler_tests/APPLE_clip_distance_test.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // APPLE_clip_distance_test.cpp:
  //   Test for APPLE_clip_distance
  //
  
  #include "tests/test_utils/ShaderExtensionTest.h"
  
  namespace
  {
  const char EXTPragma[] = "#extension GL_APPLE_clip_distance : require\n";
  
  // Shader using gl_ClipDistance
  const char ESSL100_APPLEClipDistanceShader1[] =
      R"(
      uniform vec4 uPlane;
  
      attribute vec4 aPosition;
  
      void main()
      {
          gl_Position = aPosition;
          gl_ClipDistance[1] = dot(aPosition, uPlane);
      })";
  
  // Shader redeclares gl_ClipDistance
  const char ESSL100_APPLEClipDistanceShader2[] =
      R"(
      uniform vec4 uPlane;
  
      attribute vec4 aPosition;
  
      varying highp float gl_ClipDistance[4];
  
      void main()
      {
          gl_Position = aPosition;
          gl_ClipDistance[gl_MaxClipDistances - 6 + 1] = dot(aPosition, uPlane);
          gl_ClipDistance[gl_MaxClipDistances - int(aPosition.x)] = dot(aPosition, uPlane);
      })";
  
  class APPLEClipDistanceTest : public sh::ShaderExtensionTest
  {
    public:
      void InitializeCompiler() { InitializeCompiler(SH_GLSL_130_OUTPUT); }
      void InitializeCompiler(ShShaderOutput shaderOutputType)
      {
          DestroyCompiler();
  
          mCompiler = sh::ConstructCompiler(GL_VERTEX_SHADER, testing::get<0>(GetParam()),
                                            shaderOutputType, &mResources);
          ASSERT_TRUE(mCompiler != nullptr) << "Compiler could not be constructed.";
      }
  
      testing::AssertionResult TestShaderCompile(const char *pragma)
      {
          const char *shaderStrings[] = {testing::get<1>(GetParam()), pragma,
                                         testing::get<2>(GetParam())};
          bool success = sh::Compile(mCompiler, shaderStrings, 3, SH_VARIABLES | SH_OBJECT_CODE);
          if (success)
          {
              return ::testing::AssertionSuccess() << "Compilation success";
          }
          return ::testing::AssertionFailure() << sh::GetInfoLog(mCompiler);
      }
  };
  
  // Extension flag is required to compile properly. Expect failure when it is
  // not present.
  TEST_P(APPLEClipDistanceTest, CompileFailsWithoutExtension)
  {
      mResources.APPLE_clip_distance = 0;
      InitializeCompiler();
      EXPECT_FALSE(TestShaderCompile(EXTPragma));
  }
  
  // Extension directive is required to compile properly. Expect failure when
  // it is not present.
  TEST_P(APPLEClipDistanceTest, CompileFailsWithExtensionWithoutPragma)
  {
      mResources.APPLE_clip_distance = 1;
      InitializeCompiler();
      EXPECT_FALSE(TestShaderCompile(""));
  }
  
  // With extension flag and extension directive, compiling succeeds.
  // Also test that the extension directive state is reset correctly.
  TEST_P(APPLEClipDistanceTest, CompileSucceedsWithExtensionAndPragma)
  {
      mResources.APPLE_clip_distance = 1;
      mResources.MaxClipDistances    = 8;
      InitializeCompiler();
      EXPECT_TRUE(TestShaderCompile(EXTPragma));
      // Test reset functionality.
      EXPECT_FALSE(TestShaderCompile(""));
      EXPECT_TRUE(TestShaderCompile(EXTPragma));
  }
  
  #if defined(ANGLE_ENABLE_VULKAN)
  // With extension flag and extension directive, compiling using TranslatorVulkan succeeds.
  TEST_P(APPLEClipDistanceTest, CompileSucceedsVulkan)
  {
      mResources.APPLE_clip_distance = 1;
      mResources.MaxClipDistances    = 8;
  
      InitializeCompiler(SH_SPIRV_VULKAN_OUTPUT);
      EXPECT_TRUE(TestShaderCompile(EXTPragma));
  }
  
  // Test that the SPIR-V gen path can compile a shader when this extension is not supported.
  TEST_P(APPLEClipDistanceTest, CompileSucceedsWithoutExtSupportVulkan)
  {
      mResources.APPLE_clip_distance = 0;
      mResources.MaxClipDistances    = 0;
      mResources.MaxCullDistances    = 0;
  
      InitializeCompiler(SH_SPIRV_VULKAN_OUTPUT);
  
      constexpr char kNoClipCull[] = R"(
      void main()
      {
          gl_Position = vec4(0);
      })";
      const char *shaderStrings[]  = {kNoClipCull};
  
      bool success = sh::Compile(mCompiler, shaderStrings, 1, SH_OBJECT_CODE);
      if (success)
      {
          ::testing::AssertionSuccess() << "Compilation success";
      }
      else
      {
          ::testing::AssertionFailure() << sh::GetInfoLog(mCompiler);
      }
  
      EXPECT_TRUE(success);
  }
  #endif
  
  #if defined(ANGLE_ENABLE_METAL)
  // With extension flag and extension directive, compiling using TranslatorMetal succeeds.
  TEST_P(APPLEClipDistanceTest, CompileSucceedsMetal)
  {
      mResources.APPLE_clip_distance = 1;
      mResources.MaxClipDistances    = 8;
  
      InitializeCompiler(SH_SPIRV_METAL_OUTPUT);
      EXPECT_TRUE(TestShaderCompile(EXTPragma));
  }
  #endif
  
  // The SL #version 100 shaders that are correct work similarly
  // in both GL2 and GL3, with and without the version string.
  INSTANTIATE_TEST_SUITE_P(CorrectESSL100Shaders,
                           APPLEClipDistanceTest,
                           Combine(Values(SH_GLES2_SPEC),
                                   Values(sh::ESSLVersion100),
                                   Values(ESSL100_APPLEClipDistanceShader1,
                                          ESSL100_APPLEClipDistanceShader2)));
  
  }  // anonymous namespace
  

Download