kc3-lang/angle/src/gpu_info_util/SystemInfo_win.cpp

• Show log

  Commit

• Hash : 943aed8c
  Author :
  Date : 2025-08-25T17:37:34
  

  Skip fake device with remote desktop on Windows
  
  When connecting with remote desktop on Windows, a fake device with same
  vendorId, deviceId, and driverVersion may be reported. This commit adds
  logic to skip such device to fix end2end tests.
  
  Bug: angleproject:440892567
  Change-Id: Ie3b602385424bf4a77a302793b34eb06b610bbc9
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6878724
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
  Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
  

Download

• src/gpu_info_util/SystemInfo_win.cpp

• //
  // Copyright 2013 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // SystemInfo_win.cpp: implementation of the Windows-specific parts of SystemInfo.h
  
  #include "gpu_info_util/SystemInfo_internal.h"
  
  #include "common/debug.h"
  #include "common/string_utils.h"
  
  // Windows.h needs to be included first
  #include <windows.h>
  
  #include <dxgi.h>
  
  #include <array>
  #include <sstream>
  
  namespace angle
  {
  
  namespace
  {
  
  bool GetDevicesFromDXGI(std::vector<GPUDeviceInfo> *devices)
  {
  #if defined(ANGLE_ENABLE_WINDOWS_UWP)
      IDXGIFactory1 *factory;
      if (!SUCCEEDED(
              CreateDXGIFactory1(__uuidof(IDXGIFactory1), reinterpret_cast<void **>(&factory))))
      {
          return false;
      }
  #else
      IDXGIFactory *factory;
      if (!SUCCEEDED(CreateDXGIFactory(__uuidof(IDXGIFactory), reinterpret_cast<void **>(&factory))))
      {
          return false;
      }
  #endif
  
      UINT i                = 0;
      IDXGIAdapter *adapter = nullptr;
      while (factory->EnumAdapters(i++, &adapter) != DXGI_ERROR_NOT_FOUND)
      {
          DXGI_ADAPTER_DESC desc;
          adapter->GetDesc(&desc);
  
          LARGE_INTEGER umdVersion;
          if (adapter->CheckInterfaceSupport(__uuidof(IDXGIDevice), &umdVersion) ==
              DXGI_ERROR_UNSUPPORTED)
          {
              adapter->Release();
              continue;
          }
  
          // The UMD driver version here is the same as in the registry except for the last number.
          uint64_t intVersion = umdVersion.QuadPart;
          std::ostringstream o;
  
          constexpr uint64_t kMask16 = std::numeric_limits<uint16_t>::max();
          o << ((intVersion >> 48) & kMask16) << ".";
          o << ((intVersion >> 32) & kMask16) << ".";
          o << ((intVersion >> 16) & kMask16) << ".";
          o << (intVersion & kMask16);
  
          GPUDeviceInfo device;
          device.vendorId      = desc.VendorId;
          device.deviceId      = desc.DeviceId;
          device.driverVersion = o.str();
  
          // Skip duplicate devices that have the same vendorId, deviceId, and driverVersion
          // but different systemDeviceId (can happen with remote desktop connections)
          bool isDuplicate = false;
          for (const auto &existingDevice : *devices)
          {
              if (existingDevice.vendorId == device.vendorId &&
                  existingDevice.deviceId == device.deviceId &&
                  existingDevice.driverVersion == device.driverVersion)
              {
                  isDuplicate = true;
                  break;
              }
          }
  
          if (!isDuplicate)
          {
              device.systemDeviceId =
                  GetSystemDeviceIdFromParts(desc.AdapterLuid.HighPart, desc.AdapterLuid.LowPart);
              devices->push_back(device);
          }
  
          adapter->Release();
      }
  
      factory->Release();
  
      return (i > 0);
  }
  
  }  // anonymous namespace
  
  bool GetSystemInfo(SystemInfo *info)
  {
      if (!GetDevicesFromDXGI(&info->gpus))
      {
          return false;
      }
  
      if (info->gpus.size() == 0)
      {
          return false;
      }
  
      // Call GetDualGPUInfo to populate activeGPUIndex, isOptimus, and isAMDSwitchable.
      GetDualGPUInfo(info);
  
      // Override activeGPUIndex. The first index returned by EnumAdapters is the active GPU. We
      // can override the heuristic to find the active GPU
      info->activeGPUIndex = 0;
  
  #if !defined(ANGLE_ENABLE_WINDOWS_UWP)
      // Override isOptimus. nvd3d9wrap.dll is loaded into all processes when Optimus is enabled.
      HMODULE nvd3d9wrap = GetModuleHandleW(L"nvd3d9wrap.dll");
      info->isOptimus    = nvd3d9wrap != nullptr;
  #endif
  
      return true;
  }
  
  }  // namespace angle
  

Download