kc3-lang/angle/src/tests/gl_tests

Diff

• Show log

  Commit

• Hash : 2156cd6e
  Author :
  Date : 2024-10-31T14:22:31
  

  Metal: Fix rewritten array variables clashes
  
  It was possible to generate MSL name clashes by declaring arrays,
  such as in:
    mat3 a[1]
    mat2 a_0;
  
  Complex GLSL outputs need to be linearized into primitive MSL types.
  This would happen for struct outputs, arrays and matrices. For
  these new MSL variables, the translator needs to invent new names
  that match, generated from both VS and FS.
  
  The clashes were due to the encoding scheme:
  
  For arrays, the MSL vertex output variable was named with _0 suffix for
  the array and _0 for the matrix row 0. In the example above, this
  would create a clash since also non-array mat would be linearized
  row-wise.
  
  For structs, field `a.b` would be encoded as `a_b`. By selecting
  different a and b, clashes could be generated trivially.
  
  It is redundant to encode named semantics in the out variable names. The
  only needed element is the discriminator which associates VS variables
  to FS variables. Currently this is done by using the user-provided
  root field name.
  
  Fix by encoding only the root variable name to the MSL variable name.
  The rest of the field discriminators are just a running number.
  Each GLSL name `a` is unique. MSL names get fixed suffix form `a_X`,
  and thus all of them are unique too.
  
  This is a continuation of following fixes that turned out to be
  incomplete:
  6fe8a399dd Metal: Fix rewritten out variables with underscores
  27423bffff Metal: Generate names for rewritten inputs
  
  Bug: angleproject:376417347
  Change-Id: I407db373d201b3e321c6d8414bafdbecfd82cf19
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5979774
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
  

• Files

• ActiveTextureCacheTest.cpp
• AdvancedBlendTest.cpp
• AtomicCounterBufferTest.cpp
• AttributeLayoutTest.cpp
• BPTCCompressedTextureTest.cpp
• BindGeneratesResourceTest.cpp
• BindUniformLocationTest.cpp
• BlendFuncExtendedTest.cpp
• BlendIntegerTest.cpp
• BlendMinMaxTest.cpp
• BlendPackedTest.cpp
• BlitFramebufferANGLETest.cpp
• BlobCacheTest.cpp
• BufferDataTest.cpp
• BuiltinVariableTest.cpp
• ClearTest.cpp
• ClientArraysTest.cpp
• ClipControlTest.cpp
• ClipDistanceTest.cpp
• ColorMaskTest.cpp
• CompressedTextureFormatsTest.cpp
• ComputeShaderTest.cpp
• ContextLostTest.cpp
• ContextNoErrorTest.cpp
• CopyCompressedTextureTest.cpp
• CopyTexImageTest.cpp
• CopyTexture3DTest.cpp
• CopyTextureTest.cpp
• CubeMapTextureTest.cpp
• D3D11FormatTablesTest.cpp
• D3D11InputLayoutCacheTest.cpp
• D3DImageFormatConversionTest.cpp
• D3DTextureTest.cpp
• DXT1CompressedTextureTest.cpp
• DXTSRGBCompressedTextureTest.cpp
• DXTSRGBCompressedTextureTestData.inl
• DebugMarkerTest.cpp
• DebugTest.cpp
• DepthStencilFormatsTest.cpp
• DepthStencilTest.cpp
• DepthWriteTest.cpp
• DifferentStencilMasksTest.cpp
• DiscardFramebufferEXTTest.cpp
• DrawBaseVertexBaseInstanceTest.cpp
• DrawBaseVertexVariantsTest.cpp
• DrawBuffersTest.cpp
• DrawElementsIndirectTest.cpp
• DrawElementsTest.cpp
• DrawRangeElementsTest.cpp
• EGLImageMECFriendlyTest.cpp
• ETCTextureTest.cpp
• ErrorMessages.cpp
• ExternalBufferTest.cpp
• ExternalWrapTest.cpp
• FenceSyncTests.cpp
• FloatingPointSurfaceTest.cpp
• FormatPrintTest.cpp
• FragDepthTest.cpp
• FramebufferFetchTest.cpp
• FramebufferMixedSamplesTest.cpp
• FramebufferMultiviewTest.cpp
• FramebufferRenderMipmapTest.cpp
• FramebufferTest.cpp
• GLSLTest.cpp
• GeometryShaderTest.cpp
• GetImageTest.cpp
• GetTexLevelParameterTest.cpp
• ImageTest.cpp
• ImageTestMetal.mm
• IncompatibleTextureTest.cpp
• IncompleteTextureTest.cpp
• IndexBufferOffsetTest.cpp
• IndexedPointsTest.cpp
• InstancingTest.cpp
• KTXCompressedTextureTest.cpp
• LineLoopTest.cpp
• LinkAndRelinkTest.cpp
• MatrixTest.cpp
• MaxTextureSizeTest.cpp
• MemoryBarrierTest.cpp
• MemoryObjectTest.cpp
• MemorySizeTest.cpp
• MipmapTest.cpp
• MultiDrawTest.cpp
• MultisampleCompatibilityTest.cpp
• MultisampleTest.cpp
• MultisampledRenderToTextureTest.cpp
• MultithreadingTest.cpp
• MultiviewDrawTest.cpp
• ObjectAllocationTest.cpp
• OcclusionQueriesTest.cpp
• PBOExtensionTest.cpp
• PVRTCCompressedTextureTest.cpp
• PackUnpackTest.cpp
• ParallelShaderCompileTest.cpp
• PbufferTest.cpp
• PixelLocalStorageTest.cpp
• PixmapTest.cpp
• PointSpritesTest.cpp
• PolygonModeTest.cpp
• PolygonOffsetClampTest.cpp
• ProgramBinaryTest.cpp
• ProgramInterfaceTest.cpp
• ProgramParameterTest.cpp
• ProgramPipelineTest.cpp
• ProvokingVertexTest.cpp
• QueryObjectValidation.cpp
• ReadOnlyFeedbackLoopTest.cpp
• ReadPixelsTest.cpp
• RenderbufferMultisampleTest.cpp
• RendererTest.cpp
• RequestExtensionTest.cpp
• RobustBufferAccessBehaviorTest.cpp
• RobustClientMemoryTest.cpp
• RobustFragmentShaderOutputTest.cpp
• RobustResourceInitTest.cpp
• S3TCTextureSizesTest.cpp
• SRGBFramebufferTest.cpp
• SRGBTextureTest.cpp
• SampleVariablesTest.cpp
• SamplersTest.cpp
• SemaphoreTest.cpp
• ShaderAlgorithmTest.cpp
• ShaderBinaryTest.cpp
• ShaderInterpTest.cpp
• ShaderMultisampleInterpolation.cpp
• ShaderNonConstGlobalInitializerTest.cpp
• ShaderOpTest.cpp
• ShaderStorageBufferTest.cpp
• ShadingRateQcomTest.cpp
• ShadowSamplerFunctionsTest.cpp
• SimpleOperationTest.cpp
• SixteenBppTextureTest.cpp
• StateChangeTest.cpp
• SwizzleTest.cpp
• SyncQueriesTest.cpp
• TextureExternalUpdateTest.cpp
• TextureMultisampleTest.cpp
• TextureRectangleTest.cpp
• TextureTest.cpp
• TextureUploadFormatTest.cpp
• TiledRenderingTest.cpp
• TimerQueriesTest.cpp
• TransformFeedbackTest.cpp
• UniformBufferTest.cpp
• UniformTest.cpp
• UnpackAlignmentTest.cpp
• UnpackRowLength.cpp
• VertexAttributeTest.cpp
• ViewportTest.cpp
• VulkanDescriptorSetTest.cpp
• VulkanExternalImageTest.cpp
• VulkanFormatTablesTest.cpp
• VulkanFramebufferTest.cpp
• VulkanImageTest.cpp
• VulkanMultithreadingTest.cpp
• VulkanPerformanceCounterTest.cpp
• VulkanSharedFenceTest.cpp
• VulkanUniformUpdatesTest.cpp
• WEBGLVideoTextureTest.cpp
• WebGLCompatibilityTest.cpp
• WebGLCompressedTextureAvailabilityTest.cpp
• WebGLFramebufferTest.cpp
• WebGLReadOutsideFramebufferTest.cpp
• gles1/
• media/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags