-
Show log
Commit
-
Hash : 6deca89e
Author :
Date : 2023-03-22T22:33:40
Add Spirv Instruction to explicitly cast mediump float to 16 bit If the GLSL shader code expects the comparison between two mediump float values returning true, but the SpirV compiler treats one of them as 32-bit, and treats the other one as 16-bit, the comparison would return false instead. The SpirV compiler may not automatically cast the mediump float values to 16 bits, because it may utilize the RelaxedPrecision decoration to keep a mediump float as 32-bit, so that the compiler can avoid the type cast from 32-bit highp to 16-bit mediump. This change adds an additional OpQuantizeToF16 SpirV instruction to explicitly cast mediump float scalar or mediump float vector to 16 bit, if they are assigned with a highp float value. This ensures that if the GLSL shader code ever compares two meiump float values, the SpirV shader compiler is not accidentally comparing a 16 bit with a 32 bit float value. This fixe the deqp test failure on Pixel 6 and Pixel 7: dEQP-GLES2.functional.shaders.algorithm.rgb_to_hsl_vertex. Bug: b/274859104 Bug: b/274408172 Change-Id: Ifd996cea14c0f77f45ae90f38c8e53cf5035139f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4400404 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
-
Files
- BUILD.gn
- README.md
- angle_deqp_gtest.cpp
- angle_deqp_libtester.h
- angle_deqp_libtester_main.cpp
- angle_deqp_tests_main.cpp
- deqp.gni
- deqp_data_autogen.gni
- deqp_egl_test_expectations.txt
- deqp_gl46_test_expectations.txt
- deqp_gles2_test_expectations.txt
- deqp_gles31_rotate_test_expectations.txt
- deqp_gles31_test_expectations.txt
- deqp_gles3_rotate_test_expectations.txt
- deqp_gles3_test_expectations.txt
- deqp_khr_gles2_test_expectations.txt
- deqp_khr_gles31_test_expectations.txt
- deqp_khr_gles32_test_expectations.txt
- deqp_khr_gles3_test_expectations.txt
- glcTestPackageEntry_override.cpp
- tcuANGLENativeDisplayFactory.cpp
- tcuANGLENativeDisplayFactory.h
- tcuANGLEPlatform.cpp
- tcuANGLEPlatform.h
- tcuRandomOrderExecutor.cpp
- tcuRandomOrderExecutor.h
- tes31Context_override.cpp
-
README.md
-
dEQP Support
ANGLE integrates dEQP (i.e. the OpenGL CTS) for conformance testing. It uses gtest to run tests, and provides the means for dEQP to use ANGLE.
Overriding dEQP files
Occasionally, ANGLE overrides certain dEQP files by copying them to this directory, adding the
_overridesuffix, and modifying them.deqp.gniis used to select these override files to be built with dEQP instead of the original files.This is primarily done to fix tests until they are fixed upstream.
Expectation files format
For every set of dEQP tests, for example GLES3 tests on the Vulkan backend, an expectations file exists to let the test harness know which tests it should skip (as they are known to crash), or expect to see failed. Warnings are generated if a test unexpectedly passes, but an unexpected failure is an error. This let’s ANGLE ensure there are no regressions.
If multiple test expectations in a file match a specific test due to wildcards, the test harness picks the first match in the file as the overriding expectation.
While developing a feature, or testing on a new platform, the expectations files can be modified to reflect the reality of the situation. The expected format for every line in these files is:
{BUG#} {MODIFIERS} : {TEST_NAME} = {PASS,FAIL,FLAKY,TIMEOUT,SKIP}MODIFIERScan be a combination of the below list, combined with a logical AND:WIN XP VISTA WIN7 WIN8 WIN10 MAC LEOPARD SNOWLEOPARD LION MOUNTAINLION MAVERICKS YOSEMITE ELCAPITAN SIERRA HIGHSIERRA MOJAVE LINUX CHROMEOS ANDROID NVIDIA AMD INTEL DEBUG RELEASE D3D9 D3D11 OPENGL GLES VULKAN NEXUS5X PIXEL2ORXL PIXEL4ORXL PIXEL6 QUADROP400 SWIFTSHADER PREROTATION PREROTATION90 PREROTATION180 PREROTATION270 NOSAN ASAN TSAN UBSANTEST_NAMEcan be a specific test name, or set of test names using'*'as wildcard anywhere in the name. Examples:// Disabled everywhere as is too slow: 3445 : dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.48 = SKIP // Crashes on both D3D11 and OPENGL: 1442 OPENGL : dEQP-GLES31.functional.separate_shader.* = SKIP 1442 D3D11 : dEQP-GLES31.functional.separate_shader.* = SKIP // Unsupported feature: 3726 VULKAN ANDROID : dEQP-GLES31.functional.synchronization.inter_call.without_memory_barrier.*atomic_counter* = FAIL // Failing test in Nvidia's OpenGL implementation on windows: 1665 WIN NVIDIA OPENGL : dEQP-GLES31.functional.draw_indirect.negative.command_offset_not_in_buffer_unsigned32_wrap = FAIL // Failing when emulated pre-rotation is enabled, no matter which angle: 1234 PREROTATION : dEQP-GLES3.*blit* = FAIL // Failing when emulated pre-rotation is enabled with 270 degree angle: 1234 PREROTATION270 : dEQP-GLES3.*blit* = FAIL // Flaky when run with thread-sanitizer (TSan) 6678 TSAN : dEQP-EGL.functional.sharing.gles2.multithread.random* = FLAKY