kc3-lang/angle/src/tests/gl_tests/BlendIntegerTest.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/gl_tests/BlendIntegerTest.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "test_utils/ANGLETest.h"
  #include "test_utils/gl_raii.h"
  
  using namespace angle;
  
  class BlendIntegerTest : public ANGLETest<>
  {
    protected:
      BlendIntegerTest()
      {
          setWindowWidth(128);
          setWindowHeight(128);
          setConfigRedBits(8);
          setConfigGreenBits(8);
          setConfigBlueBits(8);
          setConfigAlphaBits(8);
      }
  
      template <typename T, GLuint components>
      void compareValue(const T *value, const char *name, GLenum attachment)
      {
          T pixel[4];
          glReadBuffer(attachment);
          glReadPixels(0, 0, 1, 1, GL_RGBA_INTEGER,
                       std::is_same<T, int32_t>::value ? GL_INT : GL_UNSIGNED_INT, pixel);
          for (size_t componentIdx = 0; componentIdx < components; componentIdx++)
          {
              EXPECT_EQ(value[componentIdx], pixel[componentIdx])
                  << " componentIdx=" << componentIdx << std::endl
                  << " " << name << "[0]=" << value[0] << " pixel[0]=" << pixel[0] << std::endl
                  << " " << name << "[1]=" << value[1] << " pixel[1]=" << pixel[1] << std::endl
                  << " " << name << "[2]=" << value[2] << " pixel[2]=" << pixel[2] << std::endl
                  << " " << name << "[3]=" << value[3] << " pixel[3]=" << pixel[3];
          }
      }
  
      template <GLenum internalformat, GLuint components, bool isSigned>
      void runTest()
      {
          constexpr char kFsui[] =
              "#version 300 es\n"
              "out highp uvec4 o_drawBuffer0;\n"
              "void main(void)\n"
              "{\n"
              "    o_drawBuffer0 = uvec4(1, 1, 1, 1);\n"
              "}\n";
  
          constexpr char kFssi[] =
              "#version 300 es\n"
              "out highp ivec4 o_drawBuffer0;\n"
              "void main(void)\n"
              "{\n"
              "    o_drawBuffer0 = ivec4(-1, -1, -1, -1);\n"
              "}\n";
  
          ANGLE_GL_PROGRAM(program, essl3_shaders::vs::Simple(), isSigned ? kFssi : kFsui);
          glUseProgram(program);
  
          GLFramebuffer framebuffer;
          glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
  
          GLRenderbuffer colorRenderbuffer;
          glBindRenderbuffer(GL_RENDERBUFFER, colorRenderbuffer);
          glRenderbufferStorage(GL_RENDERBUFFER, internalformat, getWindowWidth(), getWindowHeight());
          glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
                                    colorRenderbuffer);
  
          if (isSigned)
          {
              const int32_t clearValueSigned[4] = {-128, -128, -128, -128};
              glClearBufferiv(GL_COLOR, 0, clearValueSigned);
              ASSERT_GL_NO_ERROR();
              compareValue<int32_t, components>(clearValueSigned, "clearValueSigned",
                                                GL_COLOR_ATTACHMENT0);
          }
          else
          {
              const uint32_t clearValueUnsigned[4] = {127, 127, 127, 3};
              glClearBufferuiv(GL_COLOR, 0, clearValueUnsigned);
              ASSERT_GL_NO_ERROR();
              compareValue<uint32_t, components>(clearValueUnsigned, "clearValueUnsigned",
                                                 GL_COLOR_ATTACHMENT0);
          }
  
          glEnable(GL_BLEND);
          glBlendEquation(GL_FUNC_ADD);
          glBlendFunc(GL_ONE, GL_ONE);
  
          drawQuad(program, essl3_shaders::PositionAttrib(), 0.5f);
  
          ASSERT_GL_NO_ERROR();
  
          // Enabled blending must be ignored for integer color attachment.
          if (isSigned)
          {
              const int32_t colorValueSigned[4] = {-1, -1, -1, -1};
              compareValue<int32_t, components>(colorValueSigned, "colorValueSigned",
                                                GL_COLOR_ATTACHMENT0);
          }
          else
          {
              const uint32_t colorValueUnsigned[4] = {1, 1, 1, 1};
              compareValue<uint32_t, components>(colorValueUnsigned, "colorValueUnsigned",
                                                 GL_COLOR_ATTACHMENT0);
          }
      }
  
      template <bool isSigned>
      void runTestMRT()
      {
          constexpr char kFragmentSigned[] = R"(#version 300 es
              layout(location = 1) out highp vec4 o_drawBuffer1;
              layout(location = 2) out highp ivec4 o_drawBuffer2;
              layout(location = 3) out highp vec4 o_drawBuffer3;
              void main(void)
              {
                  o_drawBuffer1 = vec4(0, 0, 0, 0);
                  o_drawBuffer2 = ivec4(0, 0, 0, 0);
                  o_drawBuffer3 = vec4(0, 0, 0, 0);
              })";
  
          constexpr char kFragmentUnsigned[] = R"(#version 300 es
              layout(location = 1) out highp vec4 o_drawBuffer1;
              layout(location = 2) out highp uvec4 o_drawBuffer2;
              layout(location = 3) out highp vec4 o_drawBuffer3;
              void main(void)
              {
                  o_drawBuffer1 = vec4(0, 0, 0, 0);
                  o_drawBuffer2 = uvec4(0, 0, 0, 0);
                  o_drawBuffer3 = vec4(0, 0, 0, 0);
              })";
  
          ANGLE_GL_PROGRAM(program, essl3_shaders::vs::Simple(),
                           isSigned ? kFragmentSigned : kFragmentUnsigned);
          glUseProgram(program);
  
          GLFramebuffer framebuffer;
          glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
  
          GLRenderbuffer colorRenderbuffer1;
          glBindRenderbuffer(GL_RENDERBUFFER, colorRenderbuffer1);
          glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, getWindowWidth(), getWindowHeight());
          glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
                                    colorRenderbuffer1);
  
          GLRenderbuffer colorRenderbuffer2;
          glBindRenderbuffer(GL_RENDERBUFFER, colorRenderbuffer2);
          glRenderbufferStorage(GL_RENDERBUFFER, isSigned ? GL_RGBA32I : GL_RGBA32UI,
                                getWindowWidth(), getWindowHeight());
          glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT2, GL_RENDERBUFFER,
                                    colorRenderbuffer2);
  
          GLRenderbuffer colorRenderbuffer3;
          glBindRenderbuffer(GL_RENDERBUFFER, colorRenderbuffer3);
          glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, getWindowWidth(), getWindowHeight());
          glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT3, GL_RENDERBUFFER,
                                    colorRenderbuffer3);
  
          GLenum drawBuffers[] = {GL_NONE, GL_COLOR_ATTACHMENT1, GL_COLOR_ATTACHMENT2,
                                  GL_COLOR_ATTACHMENT3};
          glDrawBuffers(4, drawBuffers);
  
          if (isSigned)
          {
              const int32_t clearValue[4] = {-1, 2, -3, 4};
              glClearBufferiv(GL_COLOR, 2, clearValue);
              ASSERT_GL_NO_ERROR();
              compareValue<int32_t, 4>(clearValue, "clearValue", GL_COLOR_ATTACHMENT2);
          }
          else
          {
              const uint32_t clearValue[4] = {1, 2, 3, 4};
              glClearBufferuiv(GL_COLOR, 2, clearValue);
              ASSERT_GL_NO_ERROR();
              compareValue<uint32_t, 4>(clearValue, "clearValue", GL_COLOR_ATTACHMENT2);
          }
  
          glBlendEquation(GL_MAX);
          glEnable(GL_BLEND);
  
          drawQuad(program, essl3_shaders::PositionAttrib(), 0.5f);
          ASSERT_GL_NO_ERROR();
  
          if (isSigned)
          {
              const int32_t drawValue[4] = {0, 0, 0, 0};
              compareValue<int32_t, 4>(drawValue, "drawValue", GL_COLOR_ATTACHMENT2);
          }
          else
          {
              const uint32_t drawValue[4] = {0, 0, 0, 0};
              compareValue<uint32_t, 4>(drawValue, "drawValue", GL_COLOR_ATTACHMENT2);
          }
      }
  };
  
  // Test that blending is not applied to signed integer attachments.
  TEST_P(BlendIntegerTest, R8I)
  {
      runTest<GL_R8I, 1, true>();
  }
  
  TEST_P(BlendIntegerTest, R16I)
  {
      runTest<GL_R16I, 1, true>();
  }
  
  TEST_P(BlendIntegerTest, R32I)
  {
      runTest<GL_R32I, 1, true>();
  }
  
  TEST_P(BlendIntegerTest, RG8I)
  {
      runTest<GL_RG8I, 2, true>();
  }
  
  TEST_P(BlendIntegerTest, RG16I)
  {
      runTest<GL_RG16I, 2, true>();
  }
  
  TEST_P(BlendIntegerTest, RG32I)
  {
      runTest<GL_RG32I, 2, true>();
  }
  
  TEST_P(BlendIntegerTest, RGBA8I)
  {
      runTest<GL_RGBA8I, 4, true>();
  }
  
  TEST_P(BlendIntegerTest, RGBA16I)
  {
      runTest<GL_RGBA16I, 4, true>();
  }
  
  TEST_P(BlendIntegerTest, RGBA32I)
  {
      runTest<GL_RGBA32I, 4, true>();
  }
  
  // Test that blending is not applied to unsigned integer attachments.
  TEST_P(BlendIntegerTest, R8UI)
  {
      runTest<GL_R8UI, 1, false>();
  }
  
  TEST_P(BlendIntegerTest, R16UI)
  {
      runTest<GL_R16UI, 1, false>();
  }
  
  TEST_P(BlendIntegerTest, R32UI)
  {
      runTest<GL_R32UI, 1, false>();
  }
  
  TEST_P(BlendIntegerTest, RG8UI)
  {
      runTest<GL_RG8UI, 2, false>();
  }
  
  TEST_P(BlendIntegerTest, RG16UI)
  {
      runTest<GL_RG16UI, 2, false>();
  }
  
  TEST_P(BlendIntegerTest, RG32UI)
  {
      runTest<GL_RG32UI, 2, false>();
  }
  
  TEST_P(BlendIntegerTest, RGBA8UI)
  {
      runTest<GL_RGBA8UI, 4, false>();
  }
  
  TEST_P(BlendIntegerTest, RGBA16UI)
  {
      runTest<GL_RGBA16UI, 4, false>();
  }
  
  TEST_P(BlendIntegerTest, RGBA32UI)
  {
      runTest<GL_RGBA32UI, 4, false>();
  }
  
  TEST_P(BlendIntegerTest, RGB10_A2UI)
  {
      runTest<GL_RGB10_A2UI, 4, false>();
  }
  
  // Test that blending does not cancel draws on signed integer attachments.
  TEST_P(BlendIntegerTest, MRTSigned)
  {
      // http://anglebug.com/42263640
      ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsIntel());
  
      // http://anglebug.com/42263688
      ANGLE_SKIP_TEST_IF(IsOpenGL() && IsMac() && IsIntel());
  
      // http://anglebug.com/42263689
      ANGLE_SKIP_TEST_IF(IsVulkan() && IsAdreno());
  
      runTestMRT<true>();
  }
  
  // Test that blending does not cancel draws on unsigned integer attachments.
  TEST_P(BlendIntegerTest, MRTUnsigned)
  {
      // http://anglebug.com/42263640
      ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsIntel());
  
      // http://anglebug.com/42263688
      ANGLE_SKIP_TEST_IF(IsOpenGL() && IsMac() && IsIntel());
  
      // http://anglebug.com/42263689
      ANGLE_SKIP_TEST_IF(IsVulkan() && IsAdreno());
  
      runTestMRT<false>();
  }
  
  // Use this to select which configurations (e.g. which renderer, which GLES major version) these
  // tests should be run against.
  GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(BlendIntegerTest);
  ANGLE_INSTANTIATE_TEST_ES3(BlendIntegerTest);
  

Download