kc3-lang/angle/src/tests/gl_tests/MemoryObjectTest.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/gl_tests/MemoryObjectTest.cpp

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // MemoryObjectTest.cpp : Tests of the GL_EXT_memory_object extension.
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "test_utils/ANGLETest.h"
  
  #include "test_utils/gl_raii.h"
  
  namespace angle
  {
  
  class MemoryObjectTest : public ANGLETest<>
  {
    protected:
      MemoryObjectTest()
      {
          setWindowWidth(1);
          setWindowHeight(1);
          setConfigRedBits(8);
          setConfigGreenBits(8);
          setConfigBlueBits(8);
          setConfigAlphaBits(8);
      }
  };
  
  // glIsMemoryObjectEXT must identify memory objects.
  TEST_P(MemoryObjectTest, MemoryObjectShouldBeMemoryObject)
  {
      ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object"));
  
      // http://anglebug.com/42263921
      ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
  
      constexpr GLsizei kMemoryObjectCount = 2;
      GLuint memoryObjects[kMemoryObjectCount];
      glCreateMemoryObjectsEXT(kMemoryObjectCount, memoryObjects);
  
      EXPECT_FALSE(glIsMemoryObjectEXT(0));
  
      for (GLsizei i = 0; i < kMemoryObjectCount; ++i)
      {
          EXPECT_TRUE(glIsMemoryObjectEXT(memoryObjects[i]));
      }
  
      glDeleteMemoryObjectsEXT(kMemoryObjectCount, memoryObjects);
  
      EXPECT_GL_NO_ERROR();
  }
  
  // glImportMemoryFdEXT must fail for handle types that are not file descriptors.
  TEST_P(MemoryObjectTest, ShouldFailValidationOnImportFdUnsupportedHandleType)
  {
      ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object_fd"));
  
      // http://anglebug.com/42263921
      ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
  
      {
          GLMemoryObject memoryObject;
          GLsizei deviceMemorySize = 1;
          int fd                   = -1;
          glImportMemoryFdEXT(memoryObject, deviceMemorySize, GL_HANDLE_TYPE_OPAQUE_WIN32_EXT, fd);
          EXPECT_GL_ERROR(GL_INVALID_ENUM);
      }
  
      EXPECT_GL_NO_ERROR();
  }
  
  // Test memory object queries
  TEST_P(MemoryObjectTest, MemoryObjectQueries)
  {
      ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object"));
  
      // http://anglebug.com/42263921
      ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
  
      // Validate that configuring or querying memory object zero fails
      {
          GLint dedicatedMemory = GL_TRUE;
          glMemoryObjectParameterivEXT(0, GL_DEDICATED_MEMORY_OBJECT_EXT, &dedicatedMemory);
          EXPECT_GL_ERROR(GL_INVALID_VALUE);
  
          glGetMemoryObjectParameterivEXT(0, GL_DEDICATED_MEMORY_OBJECT_EXT, &dedicatedMemory);
          EXPECT_GL_ERROR(GL_INVALID_VALUE);
          EXPECT_EQ(dedicatedMemory, GL_TRUE);
      }
  
      GLMemoryObject memoryObject;
  
      // Validate that the initial state of GL_DEDICATED_MEMORY_OBJECT_EXT is GL_FALSE
      {
          GLint dedicatedMemory = 0;
          glGetMemoryObjectParameterivEXT(memoryObject, GL_DEDICATED_MEMORY_OBJECT_EXT,
                                          &dedicatedMemory);
          EXPECT_GL_NO_ERROR();
          EXPECT_GL_FALSE(dedicatedMemory);
      }
  
      // Change GL_DEDICATED_MEMORY_OBJECT_EXT to GL_TRUE
      {
          GLint dedicatedMemory = GL_TRUE;
          glMemoryObjectParameterivEXT(memoryObject, GL_DEDICATED_MEMORY_OBJECT_EXT,
                                       &dedicatedMemory);
          EXPECT_GL_NO_ERROR();
      }
  
      // Confirm that GL_DEDICATED_MEMORY_OBJECT_EXT is now TRUE
      {
          GLint dedicatedMemory = 0;
          glGetMemoryObjectParameterivEXT(memoryObject, GL_DEDICATED_MEMORY_OBJECT_EXT,
                                          &dedicatedMemory);
          EXPECT_GL_NO_ERROR();
          EXPECT_GL_TRUE(dedicatedMemory);
      }
  
      EXPECT_GL_NO_ERROR();
  }
  
  // Use this to select which configurations (e.g. which renderer, which GLES major version) these
  // tests should be run against.
  ANGLE_INSTANTIATE_TEST_ES2_AND_ES3(MemoryObjectTest);
  
  }  // namespace angle
  

Download