Hash :
25390156
Author :
Date :
2025-08-21T00:13:19
Suppress unsafe buffers on a file-by-file basis in src/ [1 of N] In this CL, we suppress many files but stop short of actually enabling the warning by not removing the line from the unsafe_buffers_paths.txt file. That will happen in a follow-on CL, along with resolving any stragglers missed here. This is mostly a manual change so as to familiarize myself with the kinds of issues faced by the Angle codebase when applying buffer safety warnings. -- Re-generate affected hashes. -- Clang-format applied to all changed files. -- Add a few missing .reserve() calls to vectors as noticed. -- Fix some mismatches between file names and header comments. -- Be more consistent with header comment format (blank lines and trailing //-only lines when a filename comment adjoins license boilerplate). Bug: b/436880895 Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538
//
// Copyright 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#ifdef UNSAFE_BUFFERS_BUILD
# pragma allow_unsafe_libc_calls
#endif
// system_utils_posix.cpp: Implementation of POSIX OS-specific functions.
#include "common/debug.h"
#include "system_utils.h"
#include <array>
#include <iostream>
#include <dlfcn.h>
#include <grp.h>
#include <inttypes.h>
#include <pwd.h>
#include <signal.h>
#include <string.h>
#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <unistd.h>
#include "common/string_utils.h"
#ifdef ANGLE_PLATFORM_FUCHSIA
# include <zircon/process.h>
# include <zircon/syscalls.h>
#else
# include <sys/resource.h>
#endif
namespace angle
{
namespace
{
std::string GetModulePath(void *moduleOrSymbol)
{
Dl_info dlInfo;
if (dladdr(moduleOrSymbol, &dlInfo) == 0)
{
return "";
}
#ifdef ANGLE_PLATFORM_LINUX
// Chrome changes process title on Linux that causes dladdr returns wrong module
// file name for executable binary, so return GetExecutablePath() if dli_fname
// doesn't exist.
struct stat buf;
if (stat(dlInfo.dli_fname, &buf) != 0)
{
return GetExecutablePath();
}
#endif
return dlInfo.dli_fname;
}
void *OpenPosixLibrary(const std::string &fullPath, int extraFlags, std::string *errorOut)
{
void *module = dlopen(fullPath.c_str(), RTLD_NOW | extraFlags);
if (module)
{
if (errorOut)
{
*errorOut = fullPath;
}
}
else if (errorOut)
{
*errorOut = "dlopen(";
*errorOut += fullPath;
*errorOut += ") failed with error: ";
*errorOut += dlerror();
struct stat sfile;
if (-1 == stat(fullPath.c_str(), &sfile))
{
*errorOut += ", stat() call failed.";
}
else
{
*errorOut += ", stat() info: ";
struct passwd *pwuser = getpwuid(sfile.st_uid);
if (pwuser)
{
*errorOut += "owner: ";
*errorOut += pwuser->pw_name;
*errorOut += ", ";
}
struct group *grpnam = getgrgid(sfile.st_gid);
if (grpnam)
{
*errorOut += "group: ";
*errorOut += grpnam->gr_name;
*errorOut += ", ";
}
*errorOut += "perms: ";
*errorOut += std::to_string(sfile.st_mode);
*errorOut += ", links: ";
*errorOut += std::to_string(sfile.st_nlink);
*errorOut += ", size: ";
*errorOut += std::to_string(sfile.st_size);
}
}
return module;
}
} // namespace
Optional<std::string> GetCWD()
{
std::array<char, 4096> pathBuf;
char *result = getcwd(pathBuf.data(), pathBuf.size());
if (result == nullptr)
{
return Optional<std::string>::Invalid();
}
return std::string(pathBuf.data());
}
bool SetCWD(const char *dirName)
{
return (chdir(dirName) == 0);
}
bool UnsetEnvironmentVar(const char *variableName)
{
return (unsetenv(variableName) == 0);
}
bool SetEnvironmentVar(const char *variableName, const char *value)
{
return (setenv(variableName, value, 1) == 0);
}
std::string GetEnvironmentVar(const char *variableName)
{
const char *value = getenv(variableName);
return (value == nullptr ? std::string() : std::string(value));
}
const char *GetPathSeparatorForEnvironmentVar()
{
return ":";
}
std::string GetModuleDirectoryAndGetError(std::string *errorOut)
{
std::string directory;
static int placeholderSymbol = 0;
std::string moduleName = GetModulePath(&placeholderSymbol);
if (!moduleName.empty())
{
directory = moduleName.substr(0, moduleName.find_last_of('/') + 1);
}
// Ensure we return the full path to the module, not the relative path
if (!IsFullPath(directory))
{
if (errorOut)
{
*errorOut += "Directory: '";
*errorOut += directory;
*errorOut += "' is not full path";
}
Optional<std::string> cwd = GetCWD();
if (cwd.valid())
{
directory = ConcatenatePath(cwd.value(), directory);
if (errorOut)
{
*errorOut += ", so it has been modified to: '";
*errorOut += directory;
*errorOut += "'. ";
}
}
else if (errorOut)
{
*errorOut += " and getcwd was invalid. ";
}
}
return directory;
}
std::string GetModuleDirectory()
{
return GetModuleDirectoryAndGetError(nullptr);
}
void *OpenSystemLibraryWithExtensionAndGetError(const char *libraryName,
SearchType searchType,
std::string *errorOut)
{
std::string directory;
if (searchType == SearchType::ModuleDir)
{
#if ANGLE_PLATFORM_IOS_FAMILY
// On iOS, shared libraries must be loaded from within the app bundle.
directory = GetExecutableDirectory() + "/Frameworks/";
#elif ANGLE_PLATFORM_FUCHSIA
// On Fuchsia the dynamic loader always looks up libraries in /pkg/lib
// and disallows loading of libraries via absolute paths.
directory = "";
#else
directory = GetModuleDirectoryAndGetError(errorOut);
#endif
}
int extraFlags = 0;
if (searchType == SearchType::AlreadyLoaded)
{
extraFlags = RTLD_NOLOAD;
}
std::string fullPath = directory + libraryName;
return OpenPosixLibrary(fullPath, extraFlags, errorOut);
}
void *GetLibrarySymbol(void *libraryHandle, const char *symbolName)
{
if (!libraryHandle)
{
return nullptr;
}
return dlsym(libraryHandle, symbolName);
}
std::string GetLibraryPath(void *libraryHandle)
{
if (!libraryHandle)
{
return "";
}
return GetModulePath(libraryHandle);
}
void CloseSystemLibrary(void *libraryHandle)
{
if (libraryHandle)
{
dlclose(libraryHandle);
}
}
bool IsDirectory(const char *filename)
{
struct stat st;
int result = stat(filename, &st);
return result == 0 && ((st.st_mode & S_IFDIR) == S_IFDIR);
}
bool IsDebuggerAttached()
{
// This could have a fuller implementation.
// See https://cs.chromium.org/chromium/src/base/debug/debugger_posix.cc
return false;
}
bool IsSameFileDescriptor(int fd1, int fd2)
{
struct stat stat1, stat2;
if (fstat(fd1, &stat1) < 0)
{
return false;
}
if (fstat(fd2, &stat2) < 0)
{
return false;
}
// Comparing st_ino (the unique identifier within a filesystem) and
// st_dev (the identifier of the filesystem) uniquely identifies a
// file within a POSIX-conforming system
return (stat1.st_dev == stat2.st_dev) && (stat1.st_ino == stat2.st_ino);
}
void BreakDebugger()
{
// This could have a fuller implementation.
// See https://cs.chromium.org/chromium/src/base/debug/debugger_posix.cc
abort();
}
const char *GetExecutableExtension()
{
return "";
}
char GetPathSeparator()
{
return '/';
}
std::string GetRootDirectory()
{
return "/";
}
bool CreateDirectories(const std::string &path)
{
// First sanitize path so we can use "/" as universal path separator
std::string sanitizedPath(path);
MakeForwardSlashThePathSeparator(sanitizedPath);
size_t pos = 0;
do
{
pos = sanitizedPath.find("/", pos);
std::string checkPath(sanitizedPath.substr(0, pos));
if (!checkPath.empty() && !IsDirectory(checkPath.c_str()))
{
if (mkdir(checkPath.c_str(), S_IRWXU | S_IRWXG | S_IRWXO) == -1)
{
return false;
}
}
if (pos == std::string::npos)
{
break;
}
++pos;
} while (true);
return true;
}
void MakeForwardSlashThePathSeparator(std::string &path)
{
// Nothing to do here for *nix side
return;
}
Optional<std::string> GetTempDirectory()
{
const char *tmp = getenv("TMPDIR");
if (tmp != nullptr)
{
return std::string(tmp);
}
#if defined(ANGLE_PLATFORM_ANDROID)
// Not used right now in the ANGLE test runner.
// return PathService::Get(DIR_CACHE, path);
return Optional<std::string>::Invalid();
#else
return std::string("/tmp");
#endif
}
Optional<std::string> CreateTemporaryFileInDirectory(const std::string &directory)
{
return CreateTemporaryFileInDirectoryWithExtension(directory, std::string());
}
Optional<std::string> CreateTemporaryFileInDirectoryWithExtension(const std::string &directory,
const std::string &extension)
{
std::string tempFileTemplate = directory + "/.angle.XXXXXX" + extension;
int fd = mkstemps(&tempFileTemplate[0], static_cast<int>(extension.size()));
close(fd);
if (fd != -1)
{
return tempFileTemplate;
}
return Optional<std::string>::Invalid();
}
double GetCurrentProcessCpuTime()
{
#ifdef ANGLE_PLATFORM_FUCHSIA
static zx_handle_t me = zx_process_self();
zx_info_task_runtime_t task_runtime;
zx_object_get_info(me, ZX_INFO_TASK_RUNTIME, &task_runtime, sizeof(task_runtime), nullptr,
nullptr);
return static_cast<double>(task_runtime.cpu_time) * 1e-9;
#else
// We could also have used /proc/stat, but that requires us to read the
// filesystem and convert from jiffies. /proc/stat also relies on jiffies
// (lower resolution) while getrusage can potentially use a sched_clock()
// underneath that has higher resolution.
struct rusage usage;
getrusage(RUSAGE_SELF, &usage);
double userTime = usage.ru_utime.tv_sec + usage.ru_utime.tv_usec * 1e-6;
double systemTime = usage.ru_stime.tv_sec + usage.ru_stime.tv_usec * 1e-6;
return userTime + systemTime;
#endif
}
namespace
{
bool SetMemoryProtection(uintptr_t start, size_t size, int protections)
{
int ret = mprotect(reinterpret_cast<void *>(start), size, protections);
if (ret < 0)
{
perror("mprotect failed");
}
return ret == 0;
}
class PosixPageFaultHandler : public PageFaultHandler
{
public:
PosixPageFaultHandler(PageFaultCallback callback) : PageFaultHandler(callback) {}
~PosixPageFaultHandler() override {}
bool enable() override;
bool disable() override;
void handle(int sig, siginfo_t *info, void *unused);
private:
struct sigaction mDefaultBusAction = {};
struct sigaction mDefaultSegvAction = {};
};
PosixPageFaultHandler *gPosixPageFaultHandler = nullptr;
void SegfaultHandlerFunction(int sig, siginfo_t *info, void *unused)
{
gPosixPageFaultHandler->handle(sig, info, unused);
}
void PosixPageFaultHandler::handle(int sig, siginfo_t *info, void *unused)
{
bool found = false;
if ((sig == SIGSEGV || sig == SIGBUS) &&
(info->si_code == SEGV_ACCERR || info->si_code == SEGV_MAPERR))
{
found = mCallback(reinterpret_cast<uintptr_t>(info->si_addr)) ==
PageFaultHandlerRangeType::InRange;
}
// Fall back to default signal handler
if (!found)
{
if (sig == SIGSEGV)
{
mDefaultSegvAction.sa_sigaction(sig, info, unused);
}
else if (sig == SIGBUS)
{
mDefaultBusAction.sa_sigaction(sig, info, unused);
}
else
{
UNREACHABLE();
}
}
}
bool PosixPageFaultHandler::disable()
{
return sigaction(SIGSEGV, &mDefaultSegvAction, nullptr) == 0 &&
sigaction(SIGBUS, &mDefaultBusAction, nullptr) == 0;
}
bool PosixPageFaultHandler::enable()
{
struct sigaction sigAction = {};
sigAction.sa_flags = SA_SIGINFO;
sigAction.sa_sigaction = &SegfaultHandlerFunction;
sigemptyset(&sigAction.sa_mask);
// Some POSIX implementations use SIGBUS for mprotect faults
return sigaction(SIGSEGV, &sigAction, &mDefaultSegvAction) == 0 &&
sigaction(SIGBUS, &sigAction, &mDefaultBusAction) == 0;
}
} // namespace
// Set write protection
bool ProtectMemory(uintptr_t start, size_t size)
{
return SetMemoryProtection(start, size, PROT_READ);
}
// Allow reading and writing
bool UnprotectMemory(uintptr_t start, size_t size)
{
return SetMemoryProtection(start, size, PROT_READ | PROT_WRITE);
}
size_t GetPageSize()
{
long pageSize = sysconf(_SC_PAGE_SIZE);
if (pageSize < 0)
{
perror("Could not get sysconf page size");
return 0;
}
return static_cast<size_t>(pageSize);
}
PageFaultHandler *CreatePageFaultHandler(PageFaultCallback callback)
{
gPosixPageFaultHandler = new PosixPageFaultHandler(callback);
return gPosixPageFaultHandler;
}
uint64_t GetProcessMemoryUsageKB()
{
FILE *file = fopen("/proc/self/status", "r");
if (!file)
{
return 0;
}
const char *kSearchString = "VmRSS:";
constexpr size_t kMaxLineSize = 100;
std::array<char, kMaxLineSize> line = {};
uint64_t kb = 0;
while (fgets(line.data(), line.size(), file) != nullptr)
{
if (strncmp(line.data(), kSearchString, strlen(kSearchString)) == 0)
{
std::vector<std::string> strings;
SplitStringAlongWhitespace(line.data(), &strings);
sscanf(strings[1].c_str(), "%" SCNu64, &kb);
break;
}
}
fclose(file);
return kb;
}
} // namespace angle