Hash :
56aee5d6
Author :
Date :
2021-12-10T12:32:58
Reland "system_utils: Add memory protection functionality." This is a reland of b1c703e5f5e44514e8db958a5fb39ff16e514fd8 that was reverted in 663831aa676c59829cc3d822340812f016bf77f6. Skip PageFaultHandlerProtect and PageFaultHandlerDefaultHandler on macOS and Fuchsia. Original change's description: > Reland "system_utils: Add memory protection functionality." > > This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401 > that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f. > > Implement PageFaultHandler and memory protection functions. > Uses mprotect and sigaction on POSIX and equivalent Win API functions on > win32. > > Add tests to system_utils_unittests. > > Add stubs for winuwp. > > Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler > test to make it succeed on release builds, as the code was optimized > out. Furthermore the test did not correctly remove protection from the > whole area it protected, which caused a hang after deinitialization on > some build configurations, since the custom page fault handler was also > still in place. The test now correclty removes protection from the whole > area and sets back the original page fault handler. > > Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" > Bug: angleproject:5857 > Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" Bug: angleproject:5857 Change-Id: Ifaa966a7c569aa9ff0112897a02fa8f873cd52dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3329610 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267
//
// Copyright 2019 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// system_utils_win32.cpp: Implementation of OS-specific functions for Windows.
#include "common/FastVector.h"
#include "system_utils.h"
#include <windows.h>
#include <array>
namespace angle
{
bool UnsetEnvironmentVar(const char *variableName)
{
return (SetEnvironmentVariableA(variableName, nullptr) == TRUE);
}
bool SetEnvironmentVar(const char *variableName, const char *value)
{
return (SetEnvironmentVariableA(variableName, value) == TRUE);
}
std::string GetEnvironmentVar(const char *variableName)
{
FastVector<char, MAX_PATH> value;
DWORD result;
// First get the length of the variable, including the null terminator
result = GetEnvironmentVariableA(variableName, nullptr, 0);
// Zero means the variable was not found, so return now.
if (result == 0)
{
return std::string();
}
// Now size the vector to fit the data, and read the environment variable.
value.resize(result, 0);
result = GetEnvironmentVariableA(variableName, value.data(), result);
return std::string(value.data());
}
class Win32Library : public Library
{
public:
Win32Library(const char *libraryName, SearchType searchType)
{
switch (searchType)
{
case SearchType::ModuleDir:
{
std::string moduleRelativePath = ConcatenatePath(GetModuleDirectory(), libraryName);
mModule = LoadLibraryA(moduleRelativePath.c_str());
break;
}
case SearchType::SystemDir:
mModule = LoadLibraryExA(libraryName, nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32);
break;
case SearchType::AlreadyLoaded:
mModule = GetModuleHandleA(libraryName);
break;
}
}
~Win32Library() override
{
if (mModule)
{
FreeLibrary(mModule);
}
}
void *getSymbol(const char *symbolName) override
{
if (!mModule)
{
fprintf(stderr, "Module was not loaded\n");
return nullptr;
}
return reinterpret_cast<void *>(GetProcAddress(mModule, symbolName));
}
void *getNative() const override { return reinterpret_cast<void *>(mModule); }
std::string getPath() const override
{
if (!mModule)
{
return "";
}
std::array<char, MAX_PATH> buffer;
if (GetModuleFileNameA(mModule, buffer.data(), buffer.size()) == 0)
{
return "";
}
return std::string(buffer.data());
}
private:
HMODULE mModule = nullptr;
};
std::string GetSharedLibraryName(const char *libraryName, SearchType searchType)
{
char buffer[MAX_PATH];
int ret = snprintf(buffer, MAX_PATH, "%s.%s", libraryName, GetSharedLibraryExtension());
if (ret > 0 && ret < MAX_PATH)
{
return std::string(buffer);
}
else
{
return std::string("");
}
}
Library *OpenSharedLibrary(const char *libraryName, SearchType searchType)
{
char buffer[MAX_PATH];
int ret = snprintf(buffer, MAX_PATH, "%s.%s", libraryName, GetSharedLibraryExtension());
if (ret > 0 && ret < MAX_PATH)
{
return new Win32Library(buffer, searchType);
}
else
{
fprintf(stderr, "Error loading shared library: 0x%x", ret);
return nullptr;
}
}
Library *OpenSharedLibraryWithExtension(const char *libraryName, SearchType searchType)
{
return new Win32Library(libraryName, searchType);
}
namespace
{
class Win32PageFaultHandler : public PageFaultHandler
{
public:
Win32PageFaultHandler(PageFaultCallback callback) : PageFaultHandler(callback) {}
~Win32PageFaultHandler() override {}
bool enable() override;
bool disable() override;
LONG handle(PEXCEPTION_POINTERS pExceptionInfo);
private:
void *mVectoredExceptionHandler = nullptr;
};
Win32PageFaultHandler *gWin32PageFaultHandler = nullptr;
static LONG CALLBACK VectoredExceptionHandler(PEXCEPTION_POINTERS info)
{
return gWin32PageFaultHandler->handle(info);
}
bool SetMemoryProtection(uintptr_t start, size_t size, DWORD protections)
{
DWORD oldProtect;
BOOL res = VirtualProtect(reinterpret_cast<LPVOID>(start), size, protections, &oldProtect);
if (!res)
{
DWORD lastError = GetLastError();
fprintf(stderr, "VirtualProtect failed: 0x%lx\n", lastError);
return false;
}
return true;
}
LONG Win32PageFaultHandler::handle(PEXCEPTION_POINTERS info)
{
bool found = false;
if (info->ExceptionRecord->ExceptionCode == EXCEPTION_ACCESS_VIOLATION &&
info->ExceptionRecord->NumberParameters >= 2 &&
info->ExceptionRecord->ExceptionInformation[0] == 1)
{
found = mCallback(static_cast<uintptr_t>(info->ExceptionRecord->ExceptionInformation[1])) ==
PageFaultHandlerRangeType::InRange;
}
if (found)
{
return EXCEPTION_CONTINUE_EXECUTION;
}
else
{
return EXCEPTION_CONTINUE_SEARCH;
}
}
bool Win32PageFaultHandler::disable()
{
if (mVectoredExceptionHandler)
{
ULONG res = RemoveVectoredExceptionHandler(mVectoredExceptionHandler);
mVectoredExceptionHandler = nullptr;
if (res == 0)
{
DWORD lastError = GetLastError();
fprintf(stderr, "RemoveVectoredExceptionHandler failed: 0x%lx\n", lastError);
return false;
}
}
return true;
}
bool Win32PageFaultHandler::enable()
{
if (mVectoredExceptionHandler)
{
return true;
}
PVECTORED_EXCEPTION_HANDLER handler =
reinterpret_cast<PVECTORED_EXCEPTION_HANDLER>(&VectoredExceptionHandler);
mVectoredExceptionHandler = AddVectoredExceptionHandler(1, handler);
if (!mVectoredExceptionHandler)
{
DWORD lastError = GetLastError();
fprintf(stderr, "AddVectoredExceptionHandler failed: 0x%lx\n", lastError);
return false;
}
return true;
}
} // namespace
// Set write protection
bool ProtectMemory(uintptr_t start, size_t size)
{
return SetMemoryProtection(start, size, PAGE_READONLY);
}
// Allow reading and writing
bool UnprotectMemory(uintptr_t start, size_t size)
{
return SetMemoryProtection(start, size, PAGE_READWRITE);
}
size_t GetPageSize()
{
SYSTEM_INFO info;
GetSystemInfo(&info);
return static_cast<size_t>(info.dwPageSize);
}
PageFaultHandler *CreatePageFaultHandler(PageFaultCallback callback)
{
gWin32PageFaultHandler = new Win32PageFaultHandler(callback);
return gWin32PageFaultHandler;
}
} // namespace angle