kc3-lang/angle/src/compiler/translator/OutputVulkanGLSL.h

• Show log

  Commit

• Hash : feb3b6cc
  Author :
  Date : 2020-01-13T22:58:59
  

  Vulkan: Remove row->col major shader transformation
  
  This was done based on the incorrect assumption that Vulkan GLSL doesn't
  allow layout qualifiers on interface block fields.  This was due to
  glslang compile failures in some shaders that included mixed row- and
  column-major fields in interface blocks.
  
  However, the failures were only in the case the interface block is
  inactive, in which case glslang wrapper previously replaced the
  layout/qualifier of the interface block with |struct|, which left the
  shader with an unused struct definition with fields that have layout
  qualifiers; an invalid shader.
  
  The change introduced in
  https://chromium-review.googlesource.com/c/angle/angle/+/1951523
  removes inactive shader interface declarations.  The above scenario thus
  never occurs, rendering the row- to column-major transformation
  unnecessary.
  
  Bug: angleproject:3443
  Change-Id: Ice34a0fc6e047b79a4d44f04b730ec59bdfafe33
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961098
  Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
  Reviewed-by: Cody Northrop <cnorthrop@google.com>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/OutputVulkanGLSL.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // OutputVulkanGLSL:
  //   Code that outputs shaders that fit GL_KHR_vulkan_glsl.
  //   The shaders are then fed into glslang to spit out SPIR-V (libANGLE-side).
  //   See: https://www.khronos.org/registry/vulkan/specs/misc/GL_KHR_vulkan_glsl.txt
  //
  
  #include "compiler/translator/OutputGLSL.h"
  
  namespace sh
  {
  
  class TOutputVulkanGLSL : public TOutputGLSL
  {
    public:
      TOutputVulkanGLSL(TInfoSinkBase &objSink,
                        ShArrayIndexClampingStrategy clampingStrategy,
                        ShHashFunction64 hashFunction,
                        NameMap &nameMap,
                        TSymbolTable *symbolTable,
                        sh::GLenum shaderType,
                        int shaderVersion,
                        ShShaderOutput output,
                        ShCompileOptions compileOptions);
  
      void writeStructType(const TStructure *structure);
  
    protected:
      void writeLayoutQualifier(TIntermTyped *variable) override;
      void writeQualifier(TQualifier qualifier, const TType &type, const TSymbol *symbol) override;
      void writeVariableType(const TType &type,
                             const TSymbol *symbol,
                             bool isFunctionArgument) override;
  };
  
  }  // namespace sh
  

Download