kc3-lang/angle/src/compiler/translator/tree_ops/RemoveInactiveInterfaceVariables.h

• Show log

  Commit

• Hash : a5dd3888
  Author :
  Date : 2019-12-04T14:31:57
  

  Vulkan: fix handling of inactive atomic counters
  
  The translator emulates atomic counters with a storage buffer array
  during translation to Vulkan GLSL.  Glslang wrapper then should assign
  set/binding to this buffer.  However, if the atomic counters are
  actually unused in the shader, this assignment is never done.
  
  This change adds a small tree transformation for Vulkan that removes any
  uniform or interface block declaration that's not active.  In
  particular, this makes atomic counter emulation a no-op if no atomic
  counters are used.  It also has the benefit of not requiring glslang
  wrapper to remove such inactive resources.
  
  Bug: angleproject:4190
  Change-Id: I286c199854ec2379558ad1ec48b4d2c4bf5544d0
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951523
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
  

Download

• src/compiler/translator/tree_ops/RemoveInactiveInterfaceVariables.h

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // RemoveInactiveInterfaceVariables.h:
  //  Drop shader interface variable declarations for those that are inactive.  This step needs to be
  //  done after CollectVariables.  This avoids having to emulate them (e.g. atomic counters for
  //  Vulkan) or remove them in glslang wrapper (again, for Vulkan).
  //
  //  Shouldn't be run for the GL backend, as it queries shader interface variables from GL itself,
  //  instead of relying on what was gathered during CollectVariables.
  //
  
  #ifndef COMPILER_TRANSLATOR_TREEOPS_REMOVEINACTIVEVARIABLES_H_
  #define COMPILER_TRANSLATOR_TREEOPS_REMOVEINACTIVEVARIABLES_H_
  
  #include "common/angleutils.h"
  
  namespace sh
  {
  
  struct InterfaceBlock;
  struct ShaderVariable;
  class TCompiler;
  class TIntermBlock;
  class TSymbolTable;
  
  ANGLE_NO_DISCARD bool RemoveInactiveInterfaceVariables(
      TCompiler *compiler,
      TIntermBlock *root,
      const std::vector<sh::ShaderVariable> &uniforms,
      const std::vector<sh::InterfaceBlock> &interfaceBlocks);
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_TREEOPS_REMOVEINACTIVEVARIABLES_H_
  

Download