kc3-lang/angle/src/tests/test_utils/runner

Diff

  • Show log

    Commit

  • Hash : b3cbfd55
    Author : Kenneth Russell
    Date : 2021-07-07T12:31:57 

    Fix multiple end2end crashes in direct-to-MSL compiler.

This set of changes:

 - Adds a single place (CompilerMtl::useDirectToMSLCompiler) where the
   direct-to-MSL compiler can be enabled, still at compile time rather
   than run time. It is still disabled by default.
 - Initializes MTLWaitableCompileEventImpl::mShader, without which all
   shader compiles crash.
 - Fixes a mismatch of the ANGLERasterizerDisabled variable name in
   the generated MSL.
 - Removes the transform feedback bindings as an argument to the
   vertex shader's main0(). Transform feedback support needs to be
   reimplemented in this compiler backend.
 - Added an option to the DriverUniform class to emit as either an
   interface block or a struct. The direct-to-MSL backend assumes it
   is a struct.
 - Disable variable reference validation when referencing either
   sample mask or rasterizer discard functionality in the shader.
 - Disable struct usage validation when inserting references to
   ANGLE_TextureEnv. This occurs during pipeline rewriting and it's
   infeasible to disable it at that point, so disable it during
   pipeline rewriting - which means it's disabled for all shaders.
 - For angle_end2end_tests, disable the file API hooking which
   disables the Metal shader cache. This speeds up the tests
   significantly - by roughly a factor of 5.

With these changes, several hundred angle_end2end_tests run without
any assertion failures, though still with many test failures. The next
crash is in:
 GLSLTest.NamelessScopedStructs/ES2_Metal
and will likely require a larger bug fix, or more changes to be
upstreamed from WebKit's repository.

Bug: angleproject:5505
Change-Id: Ia1ea9a13867f00035d4aeccf907fd032255588e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010486
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github
    Users
    		 kc3_lang_org www_kmx_io thodg_w thodg_l thodg thodg_m
    Tags

  • README.md

  • ANGLE Test Harness

    The ANGLE test harness is a harness around GoogleTest that provides functionality similar to the Chromium test harness. It features:

    • splitting a test set into shards
    • catching and reporting crashes and timeouts
    • outputting to the Chromium JSON test results format
    • multi-process execution

    Command-Line Arguments

    The ANGLE test harness accepts all standard GoogleTest arguments. The harness also accepts the following additional command-line arguments:

    • --batch-size limits the number of tests to run in each batch
    • --batch-timeout limits the amount of time spent in each batch
    • --bot-mode enables multi-process execution and test batching
    • --debug-test-groups dumps the test config categories when using bot-mode
    • --filter-file allows passing a larger gtest_filter via a file
    • --histogram-json-file outputs a formatted JSON file for perf dashboards
    • --max-processes limits the number of simuntaneous processes
    • --results-directory specifies a directory to write test results to
    • --results-file specifies a location for the JSON test result output
    • --shard-count and --shard-index control the test sharding
    • --test-timeout limits the amount of time spent in each test
    • --flaky-retries allows for tests to fail a fixed number of times and still pass
    • --disable-crash-handler forces off OS-level crash handling
    • --isolated-outdir specifies a test artifacts directory
    • --max-failures specifies a count of failures after which the harness early exits.

    --isolated-script-test-output and --isolated-script-perf-test-output mirror --results-file and --histogram-json-file respectively.

    As well as the custom command-line arguments we support a few standard GoogleTest arguments:

    • gtest_filter works as it normally does with GoogleTest
    • gtest_also_run_disabled_tests works as it normally does as well

    Other GoogleTest arguments are not supported although they may work.

    Implementation Notes

    • The test harness only requires angle_common and angle_util.
    • It does not depend on any Chromium browser code. This allows us to compile on other non-Clang platforms.
    • It uses rapidjson to read and write JSON files.
    • Test execution is not currently deterministic in multi-process mode.

    Normal Mode vs Bot Mode

    The test runner has two main modes of operation: normal and bot mode.

    During normal mode:

    • Tests are executed single-process and single-thread.
    • The test runner executes the GoogleTest Run function.
    • We use a TestEventListener to record test results for our output JSON file.
    • A watchdog thread will force a fast exit if no test results get recorded after a timeout.
    • Crashes are handled via ANGLE’s test crash handling code.

    During bot mode:

    • Tests are run in multiple processes depending on the system processor count.
    • A server process records the child processes’ stdout and stderr.
    • The server terminates a child process if there’s no progress after a timeout.
    • The server sorts work into batches according to the back-end configuration.
    • This prevents driver errors from using multiple back-ends in the same process.
    • Batches are striped to help split up slow groups of tests.
    • The server passes test batches to child processes via a gtest_filter file.
    • Bot mode does not work on Android or Fuchsia.

    See the source code for more details: TestSuite.h and TestSuite.cpp.

    Potential Areas of Improvement

    • Deterministic test execution.
    • Using sockets to communicate with test children. Similar to dEQP’s test harness.
    • Closer integration with ANGLE’s test expectations and system config libraries.
    • Supporting a GoogleTest-free integration.

kmx.io     mail     discord kmxgit v0.4.0