kc3-lang/angle/src/tests/preprocessor_tests/comment_test.cpp

• Show log

  Commit

• Hash : f1cf5e63
  Author :
  Date : 2016-11-22T17:36:49
  

  Prevent stack overflow in macro expansion
  
  Add a configurable limit for how many nested MacroExpander objects can
  be created in the preprocessor, so that stack overflow can be
  prevented in case of malicious shaders. By default the limit is set to
  1000. In unit tests the limit is set lower to make the test run
  faster.
  
  Includes refactoring of most of the preprocessor tests so that they
  use utility functions provided by the test class instead of repeating
  the same code for initializing the preprocessor.
  
  BUG=angleproject:1600
  TEST=angle_unittests
  
  Change-Id: I23b5140d9f2dc52df96111650db63150f7238494
  Reviewed-on: https://chromium-review.googlesource.com/413986
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  

Download

• src/tests/preprocessor_tests/comment_test.cpp

• //
  // Copyright (c) 2012 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "PreprocessorTest.h"
  #include "compiler/preprocessor/Token.h"
  
  class CommentTest : public SimplePreprocessorTest, public testing::WithParamInterface<const char *>
  {
  };
  
  TEST_P(CommentTest, CommentIgnored)
  {
      const char* str = GetParam();
  
      pp::Token token;
      lexSingleToken(str, &token);
      EXPECT_EQ(pp::Token::LAST, token.type);
  }
  
  INSTANTIATE_TEST_CASE_P(LineComment, CommentTest,
                          testing::Values("//foo\n", // With newline.
                                          "//foo",   // Without newline.
                                          "//**/",   // Nested block comment.
                                          "////",    // Nested line comment.
                                          "//\""));  // Invalid character.  
  
  INSTANTIATE_TEST_CASE_P(BlockComment, CommentTest,
                          testing::Values("/*foo*/",
                                          "/*foo\n*/", // With newline.
                                          "/*//*/",    // Nested line comment.
                                          "/*/**/",    // Nested block comment.
                                          "/***/",     // With lone '*'.
                                          "/*\"*/"));  // Invalid character.
  
  class BlockCommentTest : public SimplePreprocessorTest
  {
  };
  
  TEST_F(BlockCommentTest, CommentReplacedWithSpace)
  {
      const char* str = "/*foo*/bar";
  
      pp::Token token;
      lexSingleToken(str, &token);
      EXPECT_EQ(pp::Token::IDENTIFIER, token.type);
      EXPECT_EQ("bar", token.text);
      EXPECT_TRUE(token.hasLeadingSpace());
  }
  
  TEST_F(BlockCommentTest, UnterminatedComment)
  {
      const char* str = "/*foo";
  
      using testing::_;
      EXPECT_CALL(mDiagnostics, print(pp::Diagnostics::PP_EOF_IN_COMMENT, _, _));
  
      preprocess(str);
  }
  

Download