-
Show log
Commit
-
Hash : 2d964a47
Author :
Date : 2020-10-30T16:46:30
Vulkan: Defer clears even if following command is scissored Take the following scenario: 1. glClear 2. glScissor(half of framebuffer) 3. glDrawArrays The clear in step 1 is deferred. When FramebufferVk::syncState is called in step 3, the deferred clear was applied using vkCmdClearColorImage because the draw call is scissored. This causes loadOp=LOAD to be used after the clear because the render pass is started too small (the same size as the scissor). This change makes scissored operations also take advantage of loadOp=LOAD with deferred clears. A number of changes are made to this effect: - FramebufferVk::syncState no longer limits collecting deferred clears to no-scissor. - FramebufferVk::startNewRenderPass automatically expands the render area to full size if it's clearing any attachment. - A number of bugs are fixed where FramebufferVk::flushDeferredClears is called with the scissor area. Instead, flushDeferredClears now unconditionally uses the complete render area. Note that these bugs didn't have symptoms as "scissor" and "deferred clears" were mutually exclusive. Bug: angleproject:4988 Change-Id: I24fc3d88bf9c8998869b36c863692d0f0acce994 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511371 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- ActiveTextureCacheTest.cpp
- AtomicCounterBufferTest.cpp
- AttributeLayoutTest.cpp
- BPTCCompressedTextureTest.cpp
- BindGeneratesResourceTest.cpp
- BindUniformLocationTest.cpp
- BlendFuncExtendedTest.cpp
- BlendIntegerTest.cpp
- BlendMinMaxTest.cpp
- BlendPackedTest.cpp
- BlitFramebufferANGLETest.cpp
- BufferDataTest.cpp
- BuiltinVariableTest.cpp
- ClearTest.cpp
- ClientArraysTest.cpp
- ClipDistanceTest.cpp
- ColorMaskTest.cpp
- ComputeShaderTest.cpp
- ContextLostTest.cpp
- ContextNoErrorTest.cpp
- CopyCompressedTextureTest.cpp
- CopyTexImageTest.cpp
- CopyTexture3DTest.cpp
- CopyTextureTest.cpp
- CubeMapTextureTest.cpp
- D3D11EmulatedIndexedBufferTest.cpp
- D3D11FormatTablesTest.cpp
- D3D11InputLayoutCacheTest.cpp
- D3DImageFormatConversionTest.cpp
- D3DTextureTest.cpp
- DXT1CompressedTextureTest.cpp
- DXTSRGBCompressedTextureTest.cpp
- DXTSRGBCompressedTextureTestData.inl
- DebugMarkerTest.cpp
- DebugTest.cpp
- DepthStencilFormatsTest.cpp
- DepthStencilTest.cpp
- DifferentStencilMasksTest.cpp
- DiscardFramebufferEXTTest.cpp
- DrawBaseVertexBaseInstanceTest.cpp
- DrawBaseVertexVariantsTest.cpp
- DrawBuffersTest.cpp
- DrawElementsTest.cpp
- ETCTextureTest.cpp
- ErrorMessages.cpp
- ExplicitContextTest.cpp
- ExternalWrapTest.cpp
- FenceSyncTests.cpp
- FloatingPointSurfaceTest.cpp
- FormatPrintTest.cpp
- FramebufferMixedSamplesTest.cpp
- FramebufferMultiviewTest.cpp
- FramebufferRenderMipmapTest.cpp
- FramebufferTest.cpp
- GLSLTest.cpp
- GeometryShaderTest.cpp
- GetImageTest.cpp
- GetTexLevelParameterTest.cpp
- ImageTest.cpp
- IncompleteTextureTest.cpp
- IndexBufferOffsetTest.cpp
- IndexedPointsTest.cpp
- InstancingTest.cpp
- LineLoopTest.cpp
- LinkAndRelinkTest.cpp
- MatrixTest.cpp
- MaxTextureSizeTest.cpp
- MemoryObjectTest.cpp
- MemorySizeTest.cpp
- MipmapTest.cpp
- MultiDrawTest.cpp
- MultisampleCompatibilityTest.cpp
- MultisampleTest.cpp
- MultisampledRenderToTextureTest.cpp
- MultithreadingTest.cpp
- MultiviewDrawTest.cpp
- ObjectAllocationTest.cpp
- OcclusionQueriesTest.cpp
- PBOExtensionTest.cpp
- PackUnpackTest.cpp
- ParallelShaderCompileTest.cpp
- PbufferTest.cpp
- PixmapTest.cpp
- PointSpritesTest.cpp
- ProgramBinaryTest.cpp
- ProgramInterfaceTest.cpp
- ProgramParameterTest.cpp
- ProgramPipelineTest.cpp
- ProvokingVertexTest.cpp
- ReadOnlyFeedbackLoopTest.cpp
- ReadPixelsTest.cpp
- RenderbufferMultisampleTest.cpp
- RendererTest.cpp
- RequestExtensionTest.cpp
- RobustBufferAccessBehaviorTest.cpp
- RobustClientMemoryTest.cpp
- RobustResourceInitTest.cpp
- S3TCTextureSizesTest.cpp
- SRGBFramebufferTest.cpp
- SRGBTextureTest.cpp
- SamplersTest.cpp
- SemaphoreTest.cpp
- ShaderInterpTest.cpp
- ShaderNonConstGlobalInitializerTest.cpp
- ShaderStorageBufferTest.cpp
- SimpleOperationTest.cpp
- SixteenBppTextureTest.cpp
- StateChangeTest.cpp
- SwizzleTest.cpp
- SyncQueriesTest.cpp
- TextureExternalUpdateTest.cpp
- TextureFilteringHintTest.cpp
- TextureMultisampleTest.cpp
- TextureRectangleTest.cpp
- TextureTest.cpp
- TextureUploadFormatTest.cpp
- TimerQueriesTest.cpp
- TransformFeedbackTest.cpp
- UniformBufferTest.cpp
- UniformTest.cpp
- UnpackAlignmentTest.cpp
- UnpackRowLength.cpp
- VertexAttributeTest.cpp
- ViewportTest.cpp
- VulkanDescriptorSetTest.cpp
- VulkanExternalImageTest.cpp
- VulkanFormatTablesTest.cpp
- VulkanFramebufferTest.cpp
- VulkanMultithreadingTest.cpp
- VulkanPerformanceCounterTest.cpp
- VulkanUniformUpdatesTest.cpp
- WEBGLVideoTextureTest.cpp
- WebGLCompatibilityTest.cpp
- WebGLFramebufferTest.cpp
- WebGLReadOutsideFramebufferTest.cpp
- gles1/
- media/
