-
Show log
Commit
-
Hash : 9e3eec54
Author :
Date : 2020-10-25T15:44:09
Revert "Vulkan: Make DescriptorPoolHelper a Resource" This reverts commit 5dcd29a6e532e4bd617af8767d488120b57f3b2c. Reason for revert: Breaking the ANGLE -> Chromium roller: https://chromium-review.googlesource.com/c/chromium/src/+/2496281 Original change's description: > Vulkan: Make DescriptorPoolHelper a Resource > > Descriptor pools need to live as long as the descriptor sets that are > allocated from them. Using Serials while building a command to judge a > pool's lifetime is prone to errors, since a command's Serial value > isn't known until the command is submitted, leading to deleting pools > too early relative to when the descriptor set is actually used. > > This CL updates DescriptorPoolHelper to inherit from Resource, so the > descriptor pools can be retain()'ed. This allows the Resource's counter > to indicate that a pool is in use until the command's Serial is known > and can be recorded to indicate when the command completes. This > prevents descriptor pools from being destroyed before the command > completes (while the descriptor sets are still in use), or even before > the command has been submitted. Destroying a descriptor pool resets all > of the descriptors that were allocated from it, which can trigger a > variety of VVL errors depending on when it's erroneously performed. > > This CL also adds the necessary retain() calls for the descriptor pools. > In particular, the pools need to be retained each time a cached > descriptor set that was allocated from it is re-used. This is relatively > simple with the current design, since we always clear the descriptor set > caches whenever a new pool is allocated, so the descriptor pool binding > is always accurate. > > Bug: angleproject:5030 > Test: MultithreadingTest::MultiContextDrawSmallDescriptorPools() > Change-Id: I5fdeeb46159448dfd679d7169e423048348be5ab > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2437609 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> TBR=courtneygo@google.com,timvp@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5030 Change-Id: I0fd6d9a0e1b0989b22368ef98652281288699deb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497222 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
-
Files
- AttributeMap.cpp
- AttributeMap.h
- BinaryStream.h
- BinaryStream_unittest.cpp
- BlobCache.cpp
- BlobCache.h
- BlobCache_unittest.cpp
- Buffer.cpp
- Buffer.h
- Caps.cpp
- Caps.h
- Compiler.cpp
- Compiler.h
- Config.cpp
- Config.h
- Config_unittest.cpp
- Constants.h
- Context.cpp
- Context.h
- Context.inl.h
- Context_gl.cpp
- Context_gl_1_0_autogen.h
- Context_gl_1_1_autogen.h
- Context_gl_1_2_autogen.h
- Context_gl_1_3_autogen.h
- Context_gl_1_4_autogen.h
- Context_gl_1_5_autogen.h
- Context_gl_2_0_autogen.h
- Context_gl_2_1_autogen.h
- Context_gl_3_0_autogen.h
- Context_gl_3_1_autogen.h
- Context_gl_3_2_autogen.h
- Context_gl_3_3_autogen.h
- Context_gl_4_0_autogen.h
- Context_gl_4_1_autogen.h
- Context_gl_4_2_autogen.h
- Context_gl_4_3_autogen.h
- Context_gl_4_4_autogen.h
- Context_gl_4_5_autogen.h
- Context_gl_4_6_autogen.h
- Context_gles_1_0.cpp
- Context_gles_1_0_autogen.h
- Context_gles_2_0_autogen.h
- Context_gles_3_0_autogen.h
- Context_gles_3_1_autogen.h
- Context_gles_3_2_autogen.h
- Context_gles_ext_autogen.h
- Debug.cpp
- Debug.h
- Device.cpp
- Device.h
- Display.cpp
- Display.h
- EGLSync.cpp
- EGLSync.h
- Error.cpp
- Error.h
- Error.inc
- ErrorStrings.h
- Fence.cpp
- Fence.h
- Fence_unittest.cpp
- FrameCapture.cpp
- FrameCapture.h
- FrameCapture_mock.cpp
- Framebuffer.cpp
- Framebuffer.h
- FramebufferAttachment.cpp
- FramebufferAttachment.h
- GLES1Renderer.cpp
- GLES1Renderer.h
- GLES1Shaders.inc
- GLES1State.cpp
- GLES1State.h
- HandleAllocator.cpp
- HandleAllocator.h
- HandleAllocator_unittest.cpp
- Image.cpp
- Image.h
- ImageIndex.cpp
- ImageIndex.h
- ImageIndexIterator_unittest.cpp
- Image_unittest.cpp
- IndexRangeCache.cpp
- IndexRangeCache.h
- InfoLog.h
- LoggingAnnotator.cpp
- LoggingAnnotator.h
- MemoryObject.cpp
- MemoryObject.h
- MemoryProgramCache.cpp
- MemoryProgramCache.h
- OWNERS
- Observer.cpp
- Observer.h
- Observer_unittest.cpp
- Overlay.cpp
- Overlay.h
- OverlayWidgets.cpp
- OverlayWidgets.h
- Overlay_autogen.cpp
- Overlay_autogen.h
- Overlay_font_autogen.cpp
- Overlay_font_autogen.h
- Platform.cpp
- Program.cpp
- Program.h
- ProgramExecutable.cpp
- ProgramExecutable.h
- ProgramLinkedResources.cpp
- ProgramLinkedResources.h
- ProgramPipeline.cpp
- ProgramPipeline.h
- Program_unittest.cpp
- Query.cpp
- Query.h
- RefCountObject.h
- Renderbuffer.cpp
- Renderbuffer.h
- ResourceManager.cpp
- ResourceManager.h
- ResourceManager_unittest.cpp
- ResourceMap.h
- ResourceMap_unittest.cpp
- Sampler.cpp
- Sampler.h
- Semaphore.cpp
- Semaphore.h
- Shader.cpp
- Shader.h
- SizedMRUCache.h
- SizedMRUCache_unittest.cpp
- State.cpp
- State.h
- Stream.cpp
- Stream.h
- Surface.cpp
- Surface.h
- Surface_unittest.cpp
- Texture.cpp
- Texture.h
- Thread.cpp
- Thread.h
- TransformFeedback.cpp
- TransformFeedback.h
- TransformFeedback_unittest.cpp
- Uniform.cpp
- Uniform.h
- VaryingPacking.cpp
- VaryingPacking.h
- VaryingPacking_unittest.cpp
- Version.h
- Version.inc
- VertexArray.cpp
- VertexArray.h
- VertexArray_unittest.cpp
- VertexAttribute.cpp
- VertexAttribute.h
- VertexAttribute.inc
- WorkerThread.cpp
- WorkerThread.h
- WorkerThread_unittest.cpp
- angletypes.cpp
- angletypes.h
- angletypes.inc
- angletypes_unittest.cpp
- capture_gles_1_0_autogen.cpp
- capture_gles_1_0_autogen.h
- capture_gles_1_0_params.cpp
- capture_gles_2_0_autogen.cpp
- capture_gles_2_0_autogen.h
- capture_gles_2_0_params.cpp
- capture_gles_3_0_autogen.cpp
- capture_gles_3_0_autogen.h
- capture_gles_3_0_params.cpp
- capture_gles_3_1_autogen.cpp
- capture_gles_3_1_autogen.h
- capture_gles_3_1_params.cpp
- capture_gles_3_2_autogen.cpp
- capture_gles_3_2_autogen.h
- capture_gles_3_2_params.cpp
- capture_gles_ext_autogen.cpp
- capture_gles_ext_autogen.h
- capture_gles_ext_params.cpp
- entry_points_utils.h
- es3_copy_conversion_formats.json
- es3_copy_conversion_table_autogen.cpp
- es3_format_type_combinations.json
- features.h
- format_map_autogen.cpp
- format_map_data.json
- format_map_desktop.cpp
- formatutils.cpp
- formatutils.h
- frame_capture_replay_autogen.cpp
- frame_capture_utils.cpp
- frame_capture_utils.h
- frame_capture_utils_autogen.cpp
- frame_capture_utils_autogen.h
- gen_copy_conversion_table.py
- gen_format_map.py
- gen_overlay_fonts.py
- gen_overlay_widgets.py
- gl_enum_utils.cpp
- gl_enum_utils.h
- gl_enum_utils_autogen.cpp
- gl_enum_utils_autogen.h
- histogram_macros.h
- overlay/
- overlay_widgets.json
- queryconversions.cpp
- queryconversions.h
- queryutils.cpp
- queryutils.h
- renderer/
- trace.h
- validationEGL.cpp
- validationEGL.h
- validationES.cpp
- validationES.h
- validationES1.cpp
- validationES1.h
- validationES1_autogen.h
- validationES2.cpp
- validationES2.h
- validationES2_autogen.h
- validationES3.cpp
- validationES3.h
- validationES31.cpp
- validationES31.h
- validationES31_autogen.h
- validationES32.cpp
- validationES32.h
- validationES32_autogen.h
- validationES3_autogen.h
- validationESEXT.cpp
- validationESEXT.h
- validationESEXT_autogen.h
- validationGL1.cpp
- validationGL11.cpp
- validationGL11_autogen.h
- validationGL12.cpp
- validationGL12_autogen.h
- validationGL13.cpp
- validationGL13_autogen.h
- validationGL14.cpp
- validationGL14_autogen.h
- validationGL15.cpp
- validationGL15_autogen.h
- validationGL1_autogen.h
- validationGL2.cpp
- validationGL21.cpp
- validationGL21_autogen.h
- validationGL2_autogen.h
- validationGL3.cpp
- validationGL31.cpp
- validationGL31_autogen.h
- validationGL32.cpp
- validationGL32_autogen.h
- validationGL33.cpp
- validationGL33_autogen.h
- validationGL3_autogen.h
- validationGL4.cpp
- validationGL41.cpp
- validationGL41_autogen.h
- validationGL42.cpp
- validationGL42_autogen.h
- validationGL43.cpp
- validationGL43_autogen.h
- validationGL44.cpp
- validationGL44_autogen.h
- validationGL45.cpp
- validationGL45_autogen.h
- validationGL46.cpp
- validationGL46_autogen.h
- validationGL4_autogen.h
