Hash :
7c985f5c
Author :
Date :
2018-11-29T18:16:17
Make angle::Result an enum. This moves away from a class type to a value type. This should improve performance when using angle::Result as a return value. Previously the generated code would return a pointer instead of a value. Improves performance in the most targeted microbenchmark by 10%. In more realistic scanarios it will have a smaller improvement. Also simplifies the class implementation and usage. Includes some unrelated code generation changes. Bug: angleproject:2491 Change-Id: Ifcf86870bf1c00a2f73c39ea6e4f05ca705050aa Reviewed-on: https://chromium-review.googlesource.com/c/1356139 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// SurfaceNULL.cpp:
// Implements the class methods for SurfaceNULL.
//
#include "libANGLE/renderer/null/SurfaceNULL.h"
#include "common/debug.h"
#include "libANGLE/renderer/null/FramebufferNULL.h"
namespace rx
{
SurfaceNULL::SurfaceNULL(const egl::SurfaceState &surfaceState) : SurfaceImpl(surfaceState) {}
SurfaceNULL::~SurfaceNULL() {}
egl::Error SurfaceNULL::initialize(const egl::Display *display)
{
return egl::NoError();
}
FramebufferImpl *SurfaceNULL::createDefaultFramebuffer(const gl::Context *context,
const gl::FramebufferState &state)
{
return new FramebufferNULL(state);
}
egl::Error SurfaceNULL::swap(const gl::Context *context)
{
return egl::NoError();
}
egl::Error SurfaceNULL::postSubBuffer(const gl::Context *context,
EGLint x,
EGLint y,
EGLint width,
EGLint height)
{
return egl::NoError();
}
egl::Error SurfaceNULL::querySurfacePointerANGLE(EGLint attribute, void **value)
{
UNREACHABLE();
return egl::NoError();
}
egl::Error SurfaceNULL::bindTexImage(const gl::Context *context,
gl::Texture *texture,
EGLint buffer)
{
return egl::NoError();
}
egl::Error SurfaceNULL::releaseTexImage(const gl::Context *context, EGLint buffer)
{
return egl::NoError();
}
egl::Error SurfaceNULL::getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc)
{
UNIMPLEMENTED();
return egl::EglBadAccess();
}
void SurfaceNULL::setSwapInterval(EGLint interval) {}
EGLint SurfaceNULL::getWidth() const
{
// TODO(geofflang): Read from an actual window?
return 100;
}
EGLint SurfaceNULL::getHeight() const
{
// TODO(geofflang): Read from an actual window?
return 100;
}
EGLint SurfaceNULL::isPostSubBufferSupported() const
{
return EGL_TRUE;
}
EGLint SurfaceNULL::getSwapBehavior() const
{
return EGL_BUFFER_PRESERVED;
}
angle::Result SurfaceNULL::initializeContents(const gl::Context *context,
const gl::ImageIndex &imageIndex)
{
return angle::Result::Continue;
}
} // namespace rx