-
Show log
Commit
-
Hash : 93b659f9
Author :
Date : 2025-07-04T12:35:29
Remove PoolAllocator push/pop feature PoolAllocator would manage a stack of memory pools upon client calling push() and pop(). This made the code unnecessarily complicated. The feature was only used with nesting of one, to mark the memory unused after a shader compile. Fix by removing the push/pop feature. Instantiate PoolAllocator in places the previous push() was and uninstantiating instead of previous pop(). This removes the feature where the PoolAllocator would hold on to the allocated memory in order to reuse it. This is seen as a progression: the allocator is held by the compiler, the compiler is held by the shader and each shader typically see only one compile. Thus the free pages were just leaking unused until the shader was destroyed. Instead, destructing the PoolAllocator instead of pop() will donate the memory back to platform/OS, where it is likely more useful. To preserve existing Vulkan behavior, add PoolAllocator::reset() which would mark the memory unused but leave them reserved for the PoolAllocator. Removes UB where PageHeader::nextPage would be accessed after ~PageHeader. Bug: angleproject:429513168 Change-Id: I21e58b46e0887380db3a2cab5ce22f0042cfae9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6701153 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- ANGLETest.cpp
- ANGLETest.h
- ANGLETestCL.cpp
- ANGLETestCL.h
- ConstantFoldingTest.cpp
- ConstantFoldingTest.h
- MultiThreadSteps.cpp
- MultiThreadSteps.h
- MultiviewTest.cpp
- MultiviewTest.h
- RenderDoc.cpp
- RenderDoc.h
- ShaderCompileTreeTest.cpp
- ShaderCompileTreeTest.h
- ShaderExtensionTest.h
- VulkanHelper.cpp
- VulkanHelper.h
- angle_test_configs.cpp
- angle_test_configs.h
- angle_test_instantiate.cpp
- angle_test_instantiate.h
- angle_test_instantiate_apple.h
- angle_test_instantiate_apple.mm
- angle_test_platform.cpp
- angle_test_platform.h
- compiler_test.cpp
- compiler_test.h
- draw_call_perf_utils.cpp
- draw_call_perf_utils.h
- gl_raii.h
- runner/
- system_info_util.cpp
- system_info_util.h
- third_party/
