Hash :
91976352
Author :
Date :
2022-06-21T15:41:02
Use C++17 attributes instead of custom macros Bug: angleproject:6747 Change-Id: Iad6c7cd8a18d028e01da49b647c5d01af11e0522 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3718999 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Implementation of the integer pow expressions HLSL bug workaround.
// See header for more info.
#include "compiler/translator/tree_ops/d3d/ExpandIntegerPowExpressions.h"
#include <cmath>
#include <cstdlib>
#include "compiler/translator/tree_util/IntermNode_util.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
namespace sh
{
namespace
{
class Traverser : public TIntermTraverser
{
public:
[[nodiscard]] static bool Apply(TCompiler *compiler,
TIntermNode *root,
TSymbolTable *symbolTable);
private:
Traverser(TSymbolTable *symbolTable);
bool visitAggregate(Visit visit, TIntermAggregate *node) override;
void nextIteration();
bool mFound = false;
};
// static
bool Traverser::Apply(TCompiler *compiler, TIntermNode *root, TSymbolTable *symbolTable)
{
Traverser traverser(symbolTable);
do
{
traverser.nextIteration();
root->traverse(&traverser);
if (traverser.mFound)
{
if (!traverser.updateTree(compiler, root))
{
return false;
}
}
} while (traverser.mFound);
return true;
}
Traverser::Traverser(TSymbolTable *symbolTable) : TIntermTraverser(true, false, false, symbolTable)
{}
void Traverser::nextIteration()
{
mFound = false;
}
bool Traverser::visitAggregate(Visit visit, TIntermAggregate *node)
{
if (mFound)
{
return false;
}
// Test 0: skip non-pow operators.
if (node->getOp() != EOpPow)
{
return true;
}
const TIntermSequence *sequence = node->getSequence();
ASSERT(sequence->size() == 2u);
const TIntermConstantUnion *constantExponent = sequence->at(1)->getAsConstantUnion();
// Test 1: check for a single constant.
if (!constantExponent || constantExponent->getNominalSize() != 1)
{
return true;
}
float exponentValue = constantExponent->getConstantValue()->getFConst();
// Test 2: exponentValue is in the problematic range.
if (exponentValue < -5.0f || exponentValue > 9.0f)
{
return true;
}
// Test 3: exponentValue is integer or pretty close to an integer.
if (std::abs(exponentValue - std::round(exponentValue)) > 0.0001f)
{
return true;
}
// Test 4: skip -1, 0, and 1
int exponent = static_cast<int>(std::round(exponentValue));
int n = std::abs(exponent);
if (n < 2)
{
return true;
}
// Potential problem case detected, apply workaround.
TIntermTyped *lhs = sequence->at(0)->getAsTyped();
ASSERT(lhs);
TIntermDeclaration *lhsVariableDeclaration = nullptr;
TVariable *lhsVariable =
DeclareTempVariable(mSymbolTable, lhs, EvqTemporary, &lhsVariableDeclaration);
insertStatementInParentBlock(lhsVariableDeclaration);
// Create a chain of n-1 multiples.
TIntermTyped *current = CreateTempSymbolNode(lhsVariable);
for (int i = 1; i < n; ++i)
{
TIntermBinary *mul = new TIntermBinary(EOpMul, current, CreateTempSymbolNode(lhsVariable));
mul->setLine(node->getLine());
current = mul;
}
// For negative pow, compute the reciprocal of the positive pow.
if (exponent < 0)
{
TConstantUnion *oneVal = new TConstantUnion();
oneVal->setFConst(1.0f);
TIntermConstantUnion *oneNode = new TIntermConstantUnion(oneVal, node->getType());
TIntermBinary *div = new TIntermBinary(EOpDiv, oneNode, current);
current = div;
}
queueReplacement(current, OriginalNode::IS_DROPPED);
mFound = true;
return false;
}
} // anonymous namespace
bool ExpandIntegerPowExpressions(TCompiler *compiler, TIntermNode *root, TSymbolTable *symbolTable)
{
return Traverser::Apply(compiler, root, symbolTable);
}
} // namespace sh