-
Show log
Commit
-
Hash : 4a636cdd
Author :
Date : 2022-07-20T22:44:30
Require all PLS formats to consume exactly 4 bytes of storage D3D 11.0 UAVs only support R32_FLOAT, R32_UINT, R32_SINT formats. EXT_shader_pixel_local_storage explicitly states that all PLS variables consume exactly 4 bytes. ESSL images can only have both read and write access if their format is r32f, r32i, r32ui. (We were able to circumvent this via aliasing, but it was a huge source of bugs.) There is a large precedent for only supporting 4 bytes of storage in the capabilities we use for PLS, so this CL removes support for all PLS storage formats that are not 4 bytes. It also implements an "R32" mode for PLS, that does manual packing and unpacking of r32* image formats. If the application wants larger formats, it can always define multiple PLS planes and piece them together. Next up we ought to be able to support rg16* types with more packing/unpacking. With aliasing gone, and with a bit of tweaking, the PLS tests now pass on the Pixel 4 GLES bot. Bug: angleproject:7279 Bug: angleproject:7388 Bug: angleproject:7524 Bug: angleproject:7527 Change-Id: I6b8f62c2428ade6cb5413e33360d734e55dda0eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782579 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
-
Files
- AsNode.h
- BuiltIn.h
- BuiltIn_ESSL_autogen.h
- BuiltIn_complete_autogen.h
- DriverUniform.cpp
- DriverUniform.h
- FindFunction.cpp
- FindFunction.h
- FindMain.cpp
- FindMain.h
- FindPreciseNodes.cpp
- FindPreciseNodes.h
- FindSymbolNode.cpp
- FindSymbolNode.h
- IntermNodePatternMatcher.cpp
- IntermNodePatternMatcher.h
- IntermNode_util.cpp
- IntermNode_util.h
- IntermRebuild.cpp
- IntermRebuild.h
- IntermTraverse.cpp
- IntermTraverse.h
- NodeSearch.h
- NodeType.h
- ReplaceArrayOfMatrixVarying.cpp
- ReplaceArrayOfMatrixVarying.h
- ReplaceClipCullDistanceVariable.cpp
- ReplaceClipCullDistanceVariable.h
- ReplaceShadowingVariables.cpp
- ReplaceShadowingVariables.h
- ReplaceVariable.cpp
- ReplaceVariable.h
- RewriteSampleMaskVariable.cpp
- RewriteSampleMaskVariable.h
- RunAtTheBeginningOfShader.cpp
- RunAtTheBeginningOfShader.h
- RunAtTheEndOfShader.cpp
- RunAtTheEndOfShader.h
- SpecializationConstant.cpp
- SpecializationConstant.h
- Visit.h
