Hash :
ab334105
Author :
Date :
2023-01-23T10:09:56
BuiltInResourcesString is no longer a part of shader cache key The stringified version of `ShBuiltInResources` is poorly maintained and has a large overhead while computing hashes. Instead use the `ShBuiltInResources` blob directly. The shader object now computes and caches its key, refactor MemoryProgramCache to query the shader object for its key instead of recomputing it. Tests: EGLProgramCacheControlTest* Bug: angleproject:7833 Change-Id: I67a22f9460cee10ab0f7571df7d6525b476a5a78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4185759 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
//
// Copyright 2017 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// MemoryProgramCache: Stores compiled and linked programs in memory so they don't
// always have to be re-compiled. Can be used in conjunction with the platform
// layer to warm up the cache from disk.
// Include zlib first, otherwise FAR gets defined elsewhere.
#define USE_SYSTEM_ZLIB
#include "compression_utils_portable.h"
#include "libANGLE/MemoryProgramCache.h"
#include <GLSLANG/ShaderVars.h>
#include <anglebase/sha1.h>
#include "common/BinaryStream.h"
#include "common/angle_version_info.h"
#include "common/utilities.h"
#include "libANGLE/Context.h"
#include "libANGLE/Debug.h"
#include "libANGLE/Uniform.h"
#include "libANGLE/capture/FrameCapture.h"
#include "libANGLE/histogram_macros.h"
#include "libANGLE/renderer/ProgramImpl.h"
#include "platform/PlatformMethods.h"
namespace gl
{
namespace
{
void WriteProgramBindings(BinaryOutputStream *stream, const ProgramBindings &bindings)
{
for (const auto &binding : bindings.getStableIterationMap())
{
stream->writeString(binding.first);
stream->writeInt(binding.second);
}
}
void WriteProgramAliasedBindings(BinaryOutputStream *stream, const ProgramAliasedBindings &bindings)
{
for (const auto &binding : bindings.getStableIterationMap())
{
stream->writeString(binding.first);
stream->writeInt(binding.second.location);
}
}
void WriteVariableLocations(BinaryOutputStream *stream,
const std::vector<gl::VariableLocation> &locations)
{
for (const auto &loc : locations)
{
stream->writeInt(loc.index);
stream->writeInt(loc.arrayIndex);
stream->writeBool(loc.ignored);
}
}
} // anonymous namespace
MemoryProgramCache::MemoryProgramCache(egl::BlobCache &blobCache) : mBlobCache(blobCache) {}
MemoryProgramCache::~MemoryProgramCache() {}
void MemoryProgramCache::ComputeHash(const Context *context,
const Program *program,
egl::BlobCache::Key *hashOut)
{
// Compute the program hash. Start with the shader hashes.
BinaryOutputStream hashStream;
for (ShaderType shaderType : AllShaderTypes())
{
Shader *shader = program->getAttachedShader(shaderType);
if (shader)
{
shader->writeShaderKey(&hashStream);
}
}
// Add some ANGLE metadata and Context properties, such as version and back-end.
hashStream.writeString(angle::GetANGLEShaderProgramVersion());
hashStream.writeInt(angle::GetANGLESHVersion());
hashStream.writeInt(context->getClientMajorVersion());
hashStream.writeInt(context->getClientMinorVersion());
hashStream.writeString(reinterpret_cast<const char *>(context->getString(GL_RENDERER)));
// Hash pre-link program properties.
WriteProgramBindings(&hashStream, program->getAttributeBindings());
WriteProgramAliasedBindings(&hashStream, program->getUniformLocationBindings());
WriteProgramAliasedBindings(&hashStream, program->getFragmentOutputLocations());
WriteProgramAliasedBindings(&hashStream, program->getFragmentOutputIndexes());
for (const std::string &transformFeedbackVaryingName :
program->getState().getTransformFeedbackVaryingNames())
{
hashStream.writeString(transformFeedbackVaryingName);
}
hashStream.writeInt(program->getState().getTransformFeedbackBufferMode());
WriteVariableLocations(&hashStream, program->getState().getOutputLocations());
WriteVariableLocations(&hashStream, program->getState().getSecondaryOutputLocations());
// Include the status of FrameCapture, which adds source strings to the binary
hashStream.writeBool(context->getShareGroup()->getFrameCaptureShared()->enabled());
// Call the secure SHA hashing function.
const std::vector<uint8_t> &programKey = hashStream.getData();
angle::base::SHA1HashBytes(programKey.data(), programKey.size(), hashOut->data());
}
angle::Result MemoryProgramCache::getProgram(const Context *context,
Program *program,
egl::BlobCache::Key *hashOut)
{
// If caching is effectively disabled, don't bother calculating the hash.
if (!mBlobCache.isCachingEnabled())
{
return angle::Result::Incomplete;
}
ComputeHash(context, program, hashOut);
angle::MemoryBuffer uncompressedData;
switch (mBlobCache.getAndDecompress(context->getScratchBuffer(), *hashOut, &uncompressedData))
{
case egl::BlobCache::GetAndDecompressResult::NotFound:
return angle::Result::Incomplete;
case egl::BlobCache::GetAndDecompressResult::DecompressFailure:
ANGLE_PERF_WARNING(context->getState().getDebug(), GL_DEBUG_SEVERITY_LOW,
"Error decompressing program binary data fetched from cache.");
return angle::Result::Incomplete;
case egl::BlobCache::GetAndDecompressResult::GetSuccess:
angle::Result result =
program->loadBinary(context, GL_PROGRAM_BINARY_ANGLE, uncompressedData.data(),
static_cast<int>(uncompressedData.size()));
ANGLE_TRY(result);
if (result == angle::Result::Continue)
return angle::Result::Continue;
// Cache load failed, evict
ANGLE_PERF_WARNING(context->getState().getDebug(), GL_DEBUG_SEVERITY_LOW,
"Failed to load program binary from cache.");
remove(*hashOut);
return angle::Result::Incomplete;
}
UNREACHABLE();
return angle::Result::Incomplete;
}
bool MemoryProgramCache::getAt(size_t index,
const egl::BlobCache::Key **hashOut,
egl::BlobCache::Value *programOut)
{
return mBlobCache.getAt(index, hashOut, programOut);
}
void MemoryProgramCache::remove(const egl::BlobCache::Key &programHash)
{
mBlobCache.remove(programHash);
}
angle::Result MemoryProgramCache::putProgram(const egl::BlobCache::Key &programHash,
const Context *context,
const Program *program)
{
// If caching is effectively disabled, don't bother serializing the program.
if (!mBlobCache.isCachingEnabled())
{
return angle::Result::Incomplete;
}
angle::MemoryBuffer serializedProgram;
ANGLE_TRY(program->serialize(context, &serializedProgram));
angle::MemoryBuffer compressedData;
if (!egl::CompressBlobCacheData(serializedProgram.size(), serializedProgram.data(),
&compressedData))
{
ANGLE_PERF_WARNING(context->getState().getDebug(), GL_DEBUG_SEVERITY_LOW,
"Error compressing binary data.");
return angle::Result::Incomplete;
}
{
std::scoped_lock<std::mutex> lock(mBlobCache.getMutex());
// TODO: http://anglebug.com/7568
// This was a workaround for Chrome until it added support for EGL_ANDROID_blob_cache,
// tracked by http://anglebug.com/2516. This issue has since been closed, but removing this
// still causes a test failure.
auto *platform = ANGLEPlatformCurrent();
platform->cacheProgram(platform, programHash, compressedData.size(), compressedData.data());
}
mBlobCache.put(programHash, std::move(compressedData));
return angle::Result::Continue;
}
angle::Result MemoryProgramCache::updateProgram(const Context *context, const Program *program)
{
egl::BlobCache::Key programHash;
ComputeHash(context, program, &programHash);
return putProgram(programHash, context, program);
}
bool MemoryProgramCache::putBinary(const egl::BlobCache::Key &programHash,
const uint8_t *binary,
size_t length)
{
// Copy the binary.
angle::MemoryBuffer newEntry;
if (!newEntry.resize(length))
{
return false;
}
memcpy(newEntry.data(), binary, length);
// Store the binary.
mBlobCache.populate(programHash, std::move(newEntry));
return true;
}
void MemoryProgramCache::clear()
{
mBlobCache.clear();
}
void MemoryProgramCache::resize(size_t maxCacheSizeBytes)
{
mBlobCache.resize(maxCacheSizeBytes);
}
size_t MemoryProgramCache::entryCount() const
{
return mBlobCache.entryCount();
}
size_t MemoryProgramCache::trim(size_t limit)
{
return mBlobCache.trim(limit);
}
size_t MemoryProgramCache::size() const
{
return mBlobCache.size();
}
size_t MemoryProgramCache::maxSize() const
{
return mBlobCache.maxSize();
}
} // namespace gl