Hash :
ab334105
Author :
Date :
2023-01-23T10:09:56
BuiltInResourcesString is no longer a part of shader cache key The stringified version of `ShBuiltInResources` is poorly maintained and has a large overhead while computing hashes. Instead use the `ShBuiltInResources` blob directly. The shader object now computes and caches its key, refactor MemoryProgramCache to query the shader object for its key instead of recomputing it. Tests: EGLProgramCacheControlTest* Bug: angleproject:7833 Change-Id: I67a22f9460cee10ab0f7571df7d6525b476a5a78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4185759 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120
//
// Copyright 2022 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// MemoryShaderCache: Stores compiled shader in memory so they don't
// always have to be re-compiled. Can be used in conjunction with the platform
// layer to warm up the cache from disk.
#include "libANGLE/MemoryShaderCache.h"
#include <GLSLANG/ShaderVars.h>
#include <anglebase/sha1.h>
#include "common/BinaryStream.h"
#include "common/utilities.h"
#include "libANGLE/Compiler.h"
#include "libANGLE/Context.h"
#include "libANGLE/Debug.h"
#include "libANGLE/Uniform.h"
#include "libANGLE/histogram_macros.h"
#include "libANGLE/renderer/ShaderImpl.h"
#include "platform/PlatformMethods.h"
namespace gl
{
MemoryShaderCache::MemoryShaderCache(egl::BlobCache &blobCache) : mBlobCache(blobCache) {}
MemoryShaderCache::~MemoryShaderCache() {}
angle::Result MemoryShaderCache::getShader(const Context *context,
Shader *shader,
const ShCompileOptions &compileOptions,
const ShCompilerInstance &compilerInstance,
const egl::BlobCache::Key &shaderHash)
{
// If caching is effectively disabled, don't bother calculating the hash.
if (!mBlobCache.isCachingEnabled())
{
return angle::Result::Incomplete;
}
angle::MemoryBuffer uncompressedData;
switch (mBlobCache.getAndDecompress(context->getScratchBuffer(), shaderHash, &uncompressedData))
{
case egl::BlobCache::GetAndDecompressResult::DecompressFailure:
ANGLE_PERF_WARNING(context->getState().getDebug(), GL_DEBUG_SEVERITY_LOW,
"Error decompressing shader binary data from cache.");
return angle::Result::Incomplete;
case egl::BlobCache::GetAndDecompressResult::NotFound:
return angle::Result::Incomplete;
case egl::BlobCache::GetAndDecompressResult::GetSuccess:
angle::Result result = shader->loadBinary(context, uncompressedData.data(),
static_cast<int>(uncompressedData.size()));
{
std::scoped_lock<std::mutex> lock(mHistogramMutex);
ANGLE_HISTOGRAM_BOOLEAN("GPU.ANGLE.ShaderCache.LoadBinarySuccess",
result == angle::Result::Continue);
}
ANGLE_TRY(result);
if (result == angle::Result::Continue)
return angle::Result::Continue;
// Cache load failed, evict.
ANGLE_PERF_WARNING(context->getState().getDebug(), GL_DEBUG_SEVERITY_LOW,
"Failed to load shader binary from cache.");
mBlobCache.remove(shaderHash);
return angle::Result::Incomplete;
}
UNREACHABLE();
return angle::Result::Incomplete;
}
angle::Result MemoryShaderCache::putShader(const Context *context,
const egl::BlobCache::Key &shaderHash,
const Shader *shader)
{
// If caching is effectively disabled, don't bother serializing the shader.
if (!mBlobCache.isCachingEnabled())
{
return angle::Result::Incomplete;
}
angle::MemoryBuffer serializedShader;
ANGLE_TRY(shader->serialize(nullptr, &serializedShader));
size_t compressedSize;
if (!mBlobCache.compressAndPut(shaderHash, std::move(serializedShader), &compressedSize))
{
ANGLE_PERF_WARNING(context->getState().getDebug(), GL_DEBUG_SEVERITY_LOW,
"Error compressing shader binary data for insertion into cache.");
return angle::Result::Incomplete;
}
{
std::scoped_lock<std::mutex> lock(mHistogramMutex);
ANGLE_HISTOGRAM_COUNTS("GPU.ANGLE.ShaderCache.ShaderBinarySizeBytes",
static_cast<int>(compressedSize));
}
return angle::Result::Continue;
}
void MemoryShaderCache::clear()
{
mBlobCache.clear();
}
size_t MemoryShaderCache::maxSize() const
{
return mBlobCache.maxSize();
}
} // namespace gl