kc3-lang/angle/src/libANGLE/renderer/DisplayImpl.cpp

• Show log

  Commit

• Hash : fbff065c
  Author :
  Date : 2023-05-03T22:19:07
  

  Replace GetResourceFromHashSet with map lookup
  
  Function GetResourceFromHashSet had linear time complexity
  because it was sweeping through the set until a resource with a
  matching ID was found.  This change replaces hash sets with hash
  maps to get constant time lookup. This solves, among other things,
  O(N^2) time complexity for rendering scenes containing a large
  number of surfaces.
  
  Function GetResourceFromHashSet was consuming over 50% of all CPU time
  on the main thread of Chrome's GPU process while running the MotionMark
  1.2 Images test. With this change, the benchmark score increases by
  70% on an M1 MacBook running a PGO official build of Chrome.
  
  Bug: chromium:1435066
  Change-Id: I895ac0141a91d324c63adec2c0efb8e030d9675b
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4505950
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Justin Novosad <junov@chromium.org>
  Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/DisplayImpl.cpp

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // DisplayImpl.cpp: Implementation methods of egl::Display
  
  #include "libANGLE/renderer/DisplayImpl.h"
  
  #include "libANGLE/Display.h"
  #include "libANGLE/Surface.h"
  #include "libANGLE/renderer/DeviceImpl.h"
  
  namespace rx
  {
  namespace
  {
  // For back-ends that do not implement EGLDevice.
  class MockDevice : public DeviceImpl
  {
    public:
      MockDevice() = default;
      egl::Error initialize() override { return egl::NoError(); }
      egl::Error getAttribute(const egl::Display *display, EGLint attribute, void **outValue) override
      {
          UNREACHABLE();
          return egl::EglBadAttribute();
      }
      EGLint getType() override
      {
          UNREACHABLE();
          return EGL_NONE;
      }
      void generateExtensions(egl::DeviceExtensions *outExtensions) const override
      {
          *outExtensions = egl::DeviceExtensions();
      }
  };
  }  // anonymous namespace
  
  DisplayImpl::DisplayImpl(const egl::DisplayState &state)
      : mState(state), mExtensionsInitialized(false), mCapsInitialized(false), mBlobCache(nullptr)
  {}
  
  DisplayImpl::~DisplayImpl()
  {
      ASSERT(mState.surfaceMap.empty());
  }
  
  egl::Error DisplayImpl::prepareForCall()
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::releaseThread()
  {
      return egl::NoError();
  }
  
  const egl::DisplayExtensions &DisplayImpl::getExtensions() const
  {
      if (!mExtensionsInitialized)
      {
          generateExtensions(&mExtensions);
          mExtensionsInitialized = true;
      }
  
      return mExtensions;
  }
  
  egl::Error DisplayImpl::handleGPUSwitch()
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::forceGPUSwitch(EGLint gpuIDHigh, EGLint gpuIDLow)
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::waitUntilWorkScheduled()
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::validateClientBuffer(const egl::Config *configuration,
                                               EGLenum buftype,
                                               EGLClientBuffer clientBuffer,
                                               const egl::AttributeMap &attribs) const
  {
      UNREACHABLE();
      return egl::EglBadDisplay() << "DisplayImpl::validateClientBuffer unimplemented.";
  }
  
  egl::Error DisplayImpl::validateImageClientBuffer(const gl::Context *context,
                                                    EGLenum target,
                                                    EGLClientBuffer clientBuffer,
                                                    const egl::AttributeMap &attribs) const
  {
      UNREACHABLE();
      return egl::EglBadDisplay() << "DisplayImpl::validateImageClientBuffer unimplemented.";
  }
  
  egl::Error DisplayImpl::validatePixmap(const egl::Config *config,
                                         EGLNativePixmapType pixmap,
                                         const egl::AttributeMap &attributes) const
  {
      UNREACHABLE();
      return egl::EglBadDisplay() << "DisplayImpl::valdiatePixmap unimplemented.";
  }
  
  const egl::Caps &DisplayImpl::getCaps() const
  {
      if (!mCapsInitialized)
      {
          generateCaps(&mCaps);
          mCapsInitialized = true;
      }
  
      return mCaps;
  }
  
  DeviceImpl *DisplayImpl::createDevice()
  {
      return new MockDevice();
  }
  
  bool DisplayImpl::isX11() const
  {
      return false;
  }
  
  bool DisplayImpl::isWayland() const
  {
      return false;
  }
  
  bool DisplayImpl::isGBM() const
  {
      return false;
  }
  
  bool DisplayImpl::supportsDmaBufFormat(EGLint format) const
  {
      UNREACHABLE();
      return false;
  }
  
  egl::Error DisplayImpl::queryDmaBufFormats(EGLint max_formats, EGLint *formats, EGLint *num_formats)
  {
      UNREACHABLE();
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::queryDmaBufModifiers(EGLint format,
                                               EGLint max_modifiers,
                                               EGLuint64KHR *modifiers,
                                               EGLBoolean *external_only,
                                               EGLint *num_modifiers)
  {
      UNREACHABLE();
      return egl::NoError();
  }
  }  // namespace rx
  

Download