Hash :
de09f8db
Author :
Date :
2021-09-02T18:21:37
Revert "GL: Update StateManagerGL binding funcs to use ANGLE_GL_TRY" This reverts commit 4b5a774e855af2493d64b0635f56053bd795c5c5. Reason for revert: broken on iOS and Skia Original change's description: > GL: Update StateManagerGL binding funcs to use ANGLE_GL_TRY > > Bug: angleproject:3020 > Change-Id: Iff460a1012d06e1c5feff84d91117de87e7c870a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3123167 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:3020 Change-Id: I54d81a7b734d007f65ff97990008f5e6eb8536f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3140453 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169
//
// Copyright 2015 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// TransformFeedbackGL.cpp: Implements the class methods for TransformFeedbackGL.
#include "libANGLE/renderer/gl/TransformFeedbackGL.h"
#include "common/debug.h"
#include "libANGLE/Context.h"
#include "libANGLE/State.h"
#include "libANGLE/renderer/gl/BufferGL.h"
#include "libANGLE/renderer/gl/FunctionsGL.h"
#include "libANGLE/renderer/gl/ProgramGL.h"
#include "libANGLE/renderer/gl/StateManagerGL.h"
#include "libANGLE/renderer/gl/renderergl_utils.h"
namespace rx
{
TransformFeedbackGL::TransformFeedbackGL(const gl::TransformFeedbackState &state,
const FunctionsGL *functions,
StateManagerGL *stateManager)
: TransformFeedbackImpl(state),
mFunctions(functions),
mStateManager(stateManager),
mTransformFeedbackID(0),
mIsActive(false),
mIsPaused(false),
mActiveProgram(0)
{
mFunctions->genTransformFeedbacks(1, &mTransformFeedbackID);
}
TransformFeedbackGL::~TransformFeedbackGL()
{
mStateManager->deleteTransformFeedback(mTransformFeedbackID);
mTransformFeedbackID = 0;
}
angle::Result TransformFeedbackGL::begin(const gl::Context *context,
gl::PrimitiveMode primitiveMode)
{
mStateManager->onTransformFeedbackStateChange();
return angle::Result::Continue;
}
angle::Result TransformFeedbackGL::end(const gl::Context *context)
{
mStateManager->onTransformFeedbackStateChange();
// Immediately end the transform feedback so that the results are visible.
syncActiveState(context, false, gl::PrimitiveMode::InvalidEnum);
return angle::Result::Continue;
}
angle::Result TransformFeedbackGL::pause(const gl::Context *context)
{
mStateManager->onTransformFeedbackStateChange();
syncPausedState(true);
return angle::Result::Continue;
}
angle::Result TransformFeedbackGL::resume(const gl::Context *context)
{
mStateManager->onTransformFeedbackStateChange();
return angle::Result::Continue;
}
angle::Result TransformFeedbackGL::bindIndexedBuffer(
const gl::Context *context,
size_t index,
const gl::OffsetBindingPointer<gl::Buffer> &binding)
{
const angle::FeaturesGL &features = GetFeaturesGL(context);
// Directly bind buffer (not through the StateManager methods) because the buffer bindings are
// tracked per transform feedback object
mStateManager->bindTransformFeedback(GL_TRANSFORM_FEEDBACK, mTransformFeedbackID);
if (binding.get() != nullptr)
{
const BufferGL *bufferGL = GetImplAs<BufferGL>(binding.get());
if (features.bindTransformFeedbackBufferBeforeBindBufferRange.enabled)
{
// Generic binding will be overwritten by the bindRange/bindBase below.
ANGLE_GL_TRY(context, mFunctions->bindBuffer(GL_TRANSFORM_FEEDBACK_BUFFER,
bufferGL->getBufferID()));
}
if (binding.getSize() != 0)
{
ANGLE_GL_TRY(context,
mFunctions->bindBufferRange(
GL_TRANSFORM_FEEDBACK_BUFFER, static_cast<GLuint>(index),
bufferGL->getBufferID(), binding.getOffset(), binding.getSize()));
}
else
{
ANGLE_GL_TRY(context, mFunctions->bindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER,
static_cast<GLuint>(index),
bufferGL->getBufferID()));
}
}
else
{
ANGLE_GL_TRY(context, mFunctions->bindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER,
static_cast<GLuint>(index), 0));
}
return angle::Result::Continue;
}
GLuint TransformFeedbackGL::getTransformFeedbackID() const
{
return mTransformFeedbackID;
}
void TransformFeedbackGL::syncActiveState(const gl::Context *context,
bool active,
gl::PrimitiveMode primitiveMode) const
{
if (mIsActive != active)
{
mIsActive = active;
mIsPaused = false;
mStateManager->bindTransformFeedback(GL_TRANSFORM_FEEDBACK, mTransformFeedbackID);
if (mIsActive)
{
ASSERT(primitiveMode != gl::PrimitiveMode::InvalidEnum);
mActiveProgram = GetImplAs<ProgramGL>(mState.getBoundProgram())->getProgramID();
mStateManager->useProgram(mActiveProgram);
mFunctions->beginTransformFeedback(gl::ToGLenum(primitiveMode));
}
else
{
// Implementations disagree about what should happen if a different program is bound
// when calling EndTransformFeedback. We avoid the ambiguity by always re-binding the
// program associated with this transform feedback.
GLuint previousProgram = mStateManager->getProgramID();
mStateManager->useProgram(mActiveProgram);
mFunctions->endTransformFeedback();
// Restore the current program if we changed it.
mStateManager->useProgram(previousProgram);
}
}
}
void TransformFeedbackGL::syncPausedState(bool paused) const
{
if (mIsActive && mIsPaused != paused)
{
mIsPaused = paused;
mStateManager->bindTransformFeedback(GL_TRANSFORM_FEEDBACK, mTransformFeedbackID);
if (mIsPaused)
{
mFunctions->pauseTransformFeedback();
}
else
{
mFunctions->resumeTransformFeedback();
}
}
}
} // namespace rx