kc3-lang/angle/src/libANGLE/validationES3.h

• Show log

  Commit

• Hash : 9f693aa3
  Author :
  Date : 2022-10-22T14:45:59
  

  Implement an allow list for PLS
  
  In order to guarantee no data is lost while using the
  EXT_shader_pixel_local_storage extension, we need to restrict
  applications to a small subset of commands while pixel local storage is
  active. This CL implements the allow list for GL entrypoints using
  wildcard matching inside the code generator, and adds custom validation
  for the more specific restrictions that go into effect when PLS is
  active.
  
  Bug: angleproject:7279
  Change-Id: I5dd48bd93c10e8775f32be32a4fcf17855eb2f0e
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3932552
  Reviewed-by: Kenneth Russell <kbr@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Chris Dalton <chris@rive.app>
  

Download

• src/libANGLE/validationES3.h

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // validationES3.h:
  //  Inlined validation functions for OpenGL ES 3.0 entry points.
  
  #ifndef LIBANGLE_VALIDATION_ES3_H_
  #define LIBANGLE_VALIDATION_ES3_H_
  
  #include "libANGLE/ErrorStrings.h"
  #include "libANGLE/validationES3_autogen.h"
  
  namespace gl
  {
  bool ValidateES3TexImageParametersBase(const Context *context,
                                         angle::EntryPoint entryPoint,
                                         TextureTarget target,
                                         GLint level,
                                         GLenum internalformat,
                                         bool isCompressed,
                                         bool isSubImage,
                                         GLint xoffset,
                                         GLint yoffset,
                                         GLint zoffset,
                                         GLsizei width,
                                         GLsizei height,
                                         GLsizei depth,
                                         GLint border,
                                         GLenum format,
                                         GLenum type,
                                         GLsizei imageSize,
                                         const void *pixels);
  
  bool ValidateES3TexStorageParametersLevel(const Context *context,
                                            angle::EntryPoint entryPoint,
                                            TextureType target,
                                            GLsizei levels,
                                            GLsizei width,
                                            GLsizei height,
                                            GLsizei depth);
  
  bool ValidateES3TexStorageParametersExtent(const Context *context,
                                             angle::EntryPoint entryPoint,
                                             TextureType target,
                                             GLsizei levels,
                                             GLsizei width,
                                             GLsizei height,
                                             GLsizei depth);
  
  bool ValidateES3TexStorageParametersTexObject(const Context *context,
                                                angle::EntryPoint entryPoint,
                                                TextureType target);
  
  bool ValidateES3TexStorageParametersFormat(const Context *context,
                                             angle::EntryPoint entryPoint,
                                             TextureType target,
                                             GLsizei levels,
                                             GLenum internalformat,
                                             GLsizei width,
                                             GLsizei height,
                                             GLsizei depth);
  
  bool ValidateProgramParameteriBase(const Context *context,
                                     angle::EntryPoint entryPoint,
                                     ShaderProgramID program,
                                     GLenum pname,
                                     GLint value);
  
  // ANGLE_shader_pixel_local_storage: INVALID_OPERATION is generated by many commands if pixel local
  // storage is active and:
  //
  //   <drawBufferIdx> < MAX_COLOR_ATTACHMENTS_WITH_ACTIVE_PIXEL_LOCAL_STORAGE_ANGLE
  //   <drawBufferIdx> < (MAX_COMBINED_DRAW_BUFFERS_AND_PIXEL_LOCAL_STORAGE_PLANES_ANGLE -
  //                      ACTIVE_PIXEL_LOCAL_STORAGE_PLANES_ANGLE)
  //
  bool ValidateDrawBufferIndexIfActivePLS(const Context *,
                                          angle::EntryPoint,
                                          GLuint drawBufferIdx,
                                          const char *argumentName);
  }  // namespace gl
  
  #endif  // LIBANGLE_VALIDATION_ES3_H_
  

Download