Hash :
fcb6b5a5
Author :
Date :
2020-11-25T22:16:15
Vulkan: Fix precision transformation for geometry shaders
When a varying precision mismatch is present between two stages, the
SPIR-V transformer transforms the following:
in precision1 type1 inVar;
out precision2 type2 outVar;
void main()
{
f(inVar);
outVar = g();
}
to:
in precision3 type1 inVarModified;
out precision4 type2 outVarModified;
precision1 type1 inVarTurnedPrivate;
precision2 type2 outVarTurnedPrivate;
void main()
{
// Input preamble
inVarTurnedPrivate = inVarModified;
f(inVarTurnedPrivate);
outVarTurnedPrivate = g();
// Output preamble
outVarModified = outVarTurnedPrivate;
}
This doesn't work for geometry shaders as they take the varying outputs
on EmitVertex() as opposed to return from main. This change simply
places the output preamble before every EmitVertex() instead of at the
end of the shader, if it's a geometry shader.
Bug: angleproject:5403
Change-Id: Ie395a3270c6903c54b49f64a26bc5297044cbaeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561939
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
ANGLE integrates dEQP (i.e. the OpenGL CTS) for conformance testing. It uses gtest to run tests, and provides the means for dEQP to use ANGLE.
Occasionally, ANGLE overrides certain dEQP files by copying them to this directory, adding the
_override suffix, and modifying them. deqp.gni is used to select these override files to be
built with dEQP instead of the original files.
This is primarily done to fix tests until they are fixed upstream.
For every set of dEQP tests, for example GLES3 tests on the Vulkan backend, an expectations file exists to let the test harness know which tests it should skip (as they are known to crash), or expect to see failed. Warnings are generated if a test unexpectedly passes, but an unexpected failure is an error. This let’s ANGLE ensure there are no regressions.
While developing a feature, or testing on a new platform, the expectations files can be modified to reflect the reality of the situation. The expected format for every line in these files is:
{BUG#} {MODIFIERS} : {TEST_NAME} = {PASS,FAIL,FLAKY,TIMEOUT,SKIP}
MODIFIERS can be a combination of the below list, combined with a logical AND:
WIN XP VISTA WIN7 WIN8 WIN10
MAC LEOPARD SNOWLEOPARD LION MOUNTAINLION MAVERICKS YOSEMITE ELCAPITAN SIERRA HIGHSIERRA MOJAVE
LINUX CHROMEOS ANDROID
NVIDIA AMD INTEL
DEBUG RELEASE
D3D9 D3D11 OPENGL GLES VULKAN
NEXUS5X PIXEL2ORXL
QUADROP400
SWIFTSHADER
PREROTATION PREROTATION90 PREROTATION180 PREROTATION270
TEST_NAME can be a specific test name, or set of test names using '*' as wildcard anywhere in
the name. Examples:
// Disabled everywhere as is too slow:
3445 : dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.48 = SKIP
// Crashes on both D3D11 and OPENGL:
1442 OPENGL : dEQP-GLES31.functional.separate_shader.* = SKIP
1442 D3D11 : dEQP-GLES31.functional.separate_shader.* = SKIP
// Bug in older drivers:
3726 VULKAN ANDROID : dEQP-GLES31.functional.synchronization.inter_call.without_memory_barrier.*atomic_counter* = FAIL
// Failing test in Nvidia's OpenGL implementation on windows:
1665 WIN NVIDIA OPENGL : dEQP-GLES31.functional.draw_indirect.negative.command_offset_not_in_buffer_unsigned32_wrap = FAIL
// Failing when emulated pre-rotation is enabled, no matter which angle:
1234 PREROTATION : dEQP-GLES3.*blit* = FAIL
// Failing when emulated pre-rotation is enabled with 270 degree angle:
1234 PREROTATION270 : dEQP-GLES3.*blit* = FAIL