kc3-lang/angle/src/compiler/translator/ValidateAST.h

• Show log

  Commit

• Hash : daeac238
  Author :
  Date : 2021-05-08T22:09:38
  

  Translator: Ensure structs and blocks are uniquely defined
  
  A new AST validation is added to ensure that the same TStructure or
  TInterfaceBlock is not redundantly defined.  This helps with SPIR-V
  generation by allowing the id to be used as key in a hash map that looks
  up the corresponding SPIR-V type id.
  
  A bug is fixed where the Vulkan driver uniform declaration created two
  identical declarations for ANGLEDepthRangeParams.
  
  A number of other bugs are also fixed in this change, where if a
  variable declaration is eliminated (for example due to constant folding,
  or inactive interface variable removal) and it contained a struct
  specifier, the struct declaration was also removed.  OutputGLSLBase had
  a hack where structs were declared on first encounter, which was
  incorrect as the scope of the declaration could change.  Those bugs are
  fixed and this hack is removed.
  
  Bug: angleproject:2733
  Bug: angleproject:4889
  Bug: angleproject:5936
  Change-Id: I8e13748c0bf552ae8b052249282769a1f0775603
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2881942
  Reviewed-by: Charlie Lao <cclao@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/ValidateAST.h

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifndef COMPILER_TRANSLATOR_VALIDATEAST_H_
  #define COMPILER_TRANSLATOR_VALIDATEAST_H_
  
  #include "compiler/translator/BaseTypes.h"
  #include "compiler/translator/Common.h"
  
  namespace sh
  {
  class TDiagnostics;
  class TIntermNode;
  
  // The following options (stored in Compiler) tell the validator what to validate.  Some validations
  // are conditional to certain passes.
  struct ValidateASTOptions
  {
      // TODO: add support for the flags marked with TODO. http://anglebug.com/2733
  
      // Check that every node always has only one parent,
      bool validateSingleParent = true;
      // Check that all symbols reference TVariables that have been declared.
      bool validateVariableReferences = true;
      // Check that all EOpCallFunctionInAST have their corresponding function definitions in the AST,
      // with matching symbol ids. There should also be at least a prototype declaration before the
      // function is called.
      bool validateFunctionCall = true;  // TODO
      // Check that there are no null nodes where they are not allowed, for example as children of
      // TIntermDeclaration or TIntermBlock.
      bool validateNullNodes = true;
      // Check that symbols that reference variables have consistent qualifiers and symbol ids with
      // the variable declaration. For example, references to function out parameters should be
      // EvqOut.
      bool validateQualifiers = true;  // TODO
      // Check that variable declarations that can't have initializers don't have initializers
      // (varyings, uniforms for example).
      bool validateInitializers = true;  // TODO
      // Check that there is only one TFunction with each function name referenced in the nodes (no
      // two TFunctions with the same name, taking internal/non-internal namespaces into account).
      bool validateUniqueFunctions = true;  // TODO
      // Check that references to structs are matched with the corresponding struct declaration.  This
      // is only done for references to structs inside other struct or interface blocks declarations,
      // as validateVariableReferences already ensures other references to the struct match the
      // declaration.
      bool validateStructUsage = true;
      // Check that expression nodes have the correct type considering their operand(s).
      bool validateExpressionTypes = true;  // TODO
      // If SeparateDeclarations has been run, check for the absence of multi declarations as well.
      bool validateMultiDeclarations = false;
  };
  
  // Check for errors and output error messages on the context.
  // Returns true if there are no errors.
  bool ValidateAST(TIntermNode *root, TDiagnostics *diagnostics, const ValidateASTOptions &options);
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_VALIDATESWITCH_H_
  

Download