Hash :
382bf288
Author :
Date :
2020-12-24T23:56:39
Organize AST transforms per backend Most of the AST transforms are written as a workaround to an issue that affects a single backend. This change identifies such transforms and organizes them by backend. They are then only built if the respective backend is. Additionally, about half of the GL transforms are due to mac workarounds, including the large RewriteRowMajorMatrices transform. Mac-specific workarounds are additionally only built on said platform. This change reduces the ANGLE binary size: - 106KB in a Vulkan-only build on Linux - 27KB in a GL-only build on Android (60KB on Linux) Bug: chromium:1084580 Bug: chromium:1161513 Change-Id: I64b334332c0d4f848756c6538af0d8d96864c7e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601346 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
//
// Copyright 2020 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// CheckEarlyFragmentTestOptimization is an AST traverser to check if early fragment
// test as an optimization is feasible.
//
#include "compiler/translator/tree_ops/vulkan/EarlyFragmentTestsOptimization.h"
#include "compiler/translator/InfoSink.h"
#include "compiler/translator/Symbol.h"
#include "compiler/translator/tree_util/IntermNode_util.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
namespace sh
{
namespace
{
// Traverser that check conditions that would prevent early fragment tests optmization.
class CheckEFTOptimizationTraverser : public TIntermTraverser
{
public:
CheckEFTOptimizationTraverser();
void visitSymbol(TIntermSymbol *node) override;
bool visitBranch(Visit visit, TIntermBranch *node) override;
bool isFragDepthUsed() { return mFragDepthUsed; }
bool isDiscardOpUsed() { return mDiscardOpUsed; }
protected:
bool mFragDepthUsed;
bool mDiscardOpUsed;
};
CheckEFTOptimizationTraverser::CheckEFTOptimizationTraverser()
: TIntermTraverser(true, false, false), mFragDepthUsed(false), mDiscardOpUsed(false)
{}
void CheckEFTOptimizationTraverser::visitSymbol(TIntermSymbol *node)
{
// Check the qualifier from the variable, not from the symbol node. The node may have a
// different qualifier if it's the result of a folded ternary node.
TQualifier qualifier = node->variable().getType().getQualifier();
if (qualifier == EvqFragDepth || qualifier == EvqFragDepthEXT)
{
mFragDepthUsed = true;
}
}
bool CheckEFTOptimizationTraverser::visitBranch(Visit visit, TIntermBranch *node)
{
if (node->getFlowOp() == EOpKill)
{
mDiscardOpUsed = true;
}
return true;
}
} // namespace
bool CheckEarlyFragmentTestsFeasible(TCompiler *compiler, TIntermNode *root)
{
CheckEFTOptimizationTraverser traverser;
root->traverse(&traverser);
if (traverser.isFragDepthUsed() || traverser.isDiscardOpUsed())
{
return false;
}
return true;
}
} // namespace sh