Hash :
25390156
Author :
Date :
2025-08-21T00:13:19
Suppress unsafe buffers on a file-by-file basis in src/ [1 of N] In this CL, we suppress many files but stop short of actually enabling the warning by not removing the line from the unsafe_buffers_paths.txt file. That will happen in a follow-on CL, along with resolving any stragglers missed here. This is mostly a manual change so as to familiarize myself with the kinds of issues faced by the Angle codebase when applying buffer safety warnings. -- Re-generate affected hashes. -- Clang-format applied to all changed files. -- Add a few missing .reserve() calls to vectors as noticed. -- Fix some mismatches between file names and header comments. -- Be more consistent with header comment format (blank lines and trailing //-only lines when a filename comment adjoins license boilerplate). Bug: b/436880895 Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200
//
// Copyright 2015 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include "test_utils/ANGLETest.h"
#ifdef UNSAFE_BUFFERS_BUILD
# pragma allow_unsafe_buffers
#endif
using namespace angle;
class BlendMinMaxTest : public ANGLETest<>
{
protected:
BlendMinMaxTest()
{
setWindowWidth(128);
setWindowHeight(128);
setConfigRedBits(8);
setConfigGreenBits(8);
setConfigBlueBits(8);
setConfigAlphaBits(8);
setConfigDepthBits(24);
mProgram = 0;
mColorLocation = -1;
mFramebuffer = 0;
mColorRenderbuffer = 0;
}
struct Color
{
float values[4];
};
static float getExpected(bool blendMin, float curColor, float prevColor)
{
return blendMin ? std::min(curColor, prevColor) : std::max(curColor, prevColor);
}
void runTest(GLenum colorFormat, GLenum type)
{
ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 &&
!IsGLExtensionEnabled("GL_EXT_blend_minmax"));
SetUpFramebuffer(colorFormat);
int minValue = 0;
int maxValue = 1;
if (type == GL_FLOAT)
{
minValue = -1024;
maxValue = 1024;
}
const size_t colorCount = 128;
Color colors[colorCount];
for (size_t i = 0; i < colorCount; i++)
{
for (size_t j = 0; j < 4; j++)
{
colors[i].values[j] =
static_cast<float>(minValue + (rand() % (maxValue - minValue)));
}
}
float prevColor[4];
for (size_t i = 0; i < colorCount; i++)
{
const Color &color = colors[i];
glUseProgram(mProgram);
glUniform4f(mColorLocation, color.values[0], color.values[1], color.values[2],
color.values[3]);
bool blendMin = (rand() % 2 == 0);
glBlendEquation(blendMin ? GL_MIN : GL_MAX);
drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
float pixel[4];
if (type == GL_UNSIGNED_BYTE)
{
GLubyte ubytePixel[4];
glReadPixels(0, 0, 1, 1, GL_RGBA, GL_UNSIGNED_BYTE, ubytePixel);
for (size_t componentIdx = 0; componentIdx < ArraySize(pixel); componentIdx++)
{
pixel[componentIdx] = ubytePixel[componentIdx] / 255.0f;
}
}
else if (type == GL_FLOAT)
{
glReadPixels(0, 0, 1, 1, GL_RGBA, GL_FLOAT, pixel);
}
else
{
FAIL() << "Unexpected pixel type";
}
if (i > 0)
{
const float errorRange = 1.0f / 255.0f;
for (size_t componentIdx = 0; componentIdx < ArraySize(pixel); componentIdx++)
{
EXPECT_NEAR(
getExpected(blendMin, color.values[componentIdx], prevColor[componentIdx]),
pixel[componentIdx], errorRange)
<< " blendMin=" << blendMin << " componentIdx=" << componentIdx << std::endl
<< " color.values[0]=" << color.values[0]
<< " prevColor[0]=" << prevColor[0] << std::endl
<< " color.values[1]=" << color.values[1]
<< " prevColor[1]=" << prevColor[1] << std::endl
<< " color.values[2]=" << color.values[2]
<< " prevColor[2]=" << prevColor[2] << std::endl
<< " color.values[3]=" << color.values[3]
<< " prevColor[3]=" << prevColor[3];
}
}
memcpy(prevColor, pixel, sizeof(pixel));
}
}
void testSetUp() override
{
mProgram = CompileProgram(essl1_shaders::vs::Simple(), essl1_shaders::fs::UniformColor());
if (mProgram == 0)
{
FAIL() << "shader compilation failed.";
}
mColorLocation = glGetUniformLocation(mProgram, essl1_shaders::ColorUniform());
glUseProgram(mProgram);
glClearColor(0, 0, 0, 0);
glClearDepthf(0.0);
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
glEnable(GL_BLEND);
glDisable(GL_DEPTH_TEST);
}
void SetUpFramebuffer(GLenum colorFormat)
{
glGenFramebuffers(1, &mFramebuffer);
glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
glGenRenderbuffers(1, &mColorRenderbuffer);
glBindRenderbuffer(GL_RENDERBUFFER, mColorRenderbuffer);
glRenderbufferStorage(GL_RENDERBUFFER, colorFormat, getWindowWidth(), getWindowHeight());
glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
mColorRenderbuffer);
glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
glClear(GL_COLOR_BUFFER_BIT);
ASSERT_GL_NO_ERROR();
}
void testTearDown() override
{
glDeleteProgram(mProgram);
glDeleteFramebuffers(1, &mFramebuffer);
glDeleteRenderbuffers(1, &mColorRenderbuffer);
}
GLuint mProgram;
GLint mColorLocation;
GLuint mFramebuffer;
GLuint mColorRenderbuffer;
};
TEST_P(BlendMinMaxTest, RGBA8)
{
runTest(GL_RGBA8, GL_UNSIGNED_BYTE);
}
TEST_P(BlendMinMaxTest, RGBA32F)
{
ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 || !IsGLExtensionEnabled("GL_EXT_float_blend") ||
!IsGLExtensionEnabled("GL_EXT_color_buffer_float"));
runTest(GL_RGBA32F, GL_FLOAT);
}
TEST_P(BlendMinMaxTest, RGBA16F)
{
ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 &&
!IsGLExtensionEnabled("GL_EXT_color_buffer_half_float"));
runTest(GL_RGBA16F, GL_FLOAT);
}
// Use this to select which configurations (e.g. which renderer, which GLES major version) these
// tests should be run against.
ANGLE_INSTANTIATE_TEST_ES2_AND_ES3(BlendMinMaxTest);