kc3-lang/angle/src/tests/gl_tests/gles1/MatrixBuiltinsTest.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/gl_tests/gles1/MatrixBuiltinsTest.cpp

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // MatrixBuiltinsTest.cpp: Tests basic usage of builtin matrix operations.
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "test_utils/ANGLETest.h"
  #include "test_utils/gl_raii.h"
  
  #include "common/matrix_utils.h"
  #include "util/random_utils.h"
  
  #include <stdint.h>
  
  using namespace angle;
  
  class MatrixBuiltinsTest : public ANGLETest<>
  {
    protected:
      MatrixBuiltinsTest()
      {
          setWindowWidth(32);
          setWindowHeight(32);
          setConfigRedBits(8);
          setConfigGreenBits(8);
          setConfigBlueBits(8);
          setConfigAlphaBits(8);
          setConfigDepthBits(24);
      }
  };
  
  // Test rotation and check the matrix for closeness to a rotation matrix.
  TEST_P(MatrixBuiltinsTest, Rotate)
  {
      constexpr float angle = 90.0f;
      constexpr float x     = 1.0f;
      constexpr float y     = 1.0f;
      constexpr float z     = 1.0f;
  
      angle::Mat4 testMatrix = angle::Mat4::Rotate(angle, angle::Vector3(x, y, z));
  
      glRotatef(angle, x, y, z);
      EXPECT_GL_NO_ERROR();
  
      angle::Mat4 outputMatrix;
      glGetFloatv(GL_MODELVIEW_MATRIX, outputMatrix.data());
      EXPECT_GL_NO_ERROR();
  
      EXPECT_TRUE(testMatrix.nearlyEqual(0.00001f, outputMatrix));
  }
  
  // Test that rotation of a (0, 0, 0) Vector doesn't result in NaN values.
  TEST_P(MatrixBuiltinsTest, RotateAxisZero)
  {
      constexpr float angle = 90.0f;
      constexpr float x     = 0.0f;
      constexpr float y     = 0.0f;
      constexpr float z     = 0.0f;
  
      angle::Mat4 testMatrix = angle::Mat4::Rotate(angle, angle::Vector3(x, y, z));
  
      glRotatef(angle, x, y, z);
      EXPECT_GL_NO_ERROR();
  
      angle::Mat4 outputMatrix;
      glGetFloatv(GL_MODELVIEW_MATRIX, outputMatrix.data());
      EXPECT_GL_NO_ERROR();
  
      const float *inputArray  = testMatrix.data();
      const float *outputArray = outputMatrix.data();
      for (int index = 0; index < 16; index++)
      {
          EXPECT_FALSE(isnan(inputArray[index]));
          EXPECT_FALSE(isnan(outputArray[index]));
      }
  }
  
  // Test translation and check the matrix for closeness to a translation matrix.
  TEST_P(MatrixBuiltinsTest, Translate)
  {
      constexpr float x = 1.0f;
      constexpr float y = 1.0f;
      constexpr float z = 1.0f;
  
      angle::Mat4 testMatrix = angle::Mat4::Translate(angle::Vector3(x, y, z));
  
      glTranslatef(1.0f, 0.0f, 0.0f);
      glTranslatef(0.0f, 1.0f, 0.0f);
      glTranslatef(0.0f, 0.0f, 1.0f);
      EXPECT_GL_NO_ERROR();
  
      angle::Mat4 outputMatrix;
      glGetFloatv(GL_MODELVIEW_MATRIX, outputMatrix.data());
      EXPECT_GL_NO_ERROR();
  
      EXPECT_TRUE(testMatrix.nearlyEqual(0.00001f, outputMatrix));
  }
  
  // Test scale and check the matrix for closeness to a scale matrix.
  TEST_P(MatrixBuiltinsTest, Scale)
  {
      constexpr float x = 3.0f;
      constexpr float y = 9.0f;
      constexpr float z = 27.0f;
  
      angle::Mat4 testMatrix = angle::Mat4::Scale(angle::Vector3(x, y, z));
  
      glScalef(3.0f, 3.0f, 3.0f);
      glScalef(1.0f, 3.0f, 3.0f);
      glScalef(1.0f, 1.0f, 3.0f);
      EXPECT_GL_NO_ERROR();
  
      angle::Mat4 outputMatrix;
      glGetFloatv(GL_MODELVIEW_MATRIX, outputMatrix.data());
      EXPECT_GL_NO_ERROR();
  
      EXPECT_TRUE(testMatrix.nearlyEqual(0.00001f, outputMatrix));
  }
  
  // Test frustum projection and check the matrix values.
  TEST_P(MatrixBuiltinsTest, Frustum)
  {
  
      constexpr float l = -1.0f;
      constexpr float r = 1.0f;
      constexpr float b = -1.0f;
      constexpr float t = 1.0f;
      constexpr float n = 0.1f;
      constexpr float f = 1.0f;
  
      angle::Mat4 testMatrix = angle::Mat4::Frustum(l, r, b, t, n, f);
  
      glFrustumf(l, r, b, t, n, f);
      EXPECT_GL_NO_ERROR();
  
      angle::Mat4 outputMatrix;
      glGetFloatv(GL_MODELVIEW_MATRIX, outputMatrix.data());
      EXPECT_GL_NO_ERROR();
  
      EXPECT_TRUE(testMatrix.nearlyEqual(0.00001f, outputMatrix));
  }
  
  // Test orthographic projection and check the matrix values.
  TEST_P(MatrixBuiltinsTest, Ortho)
  {
      constexpr float l = -1.0f;
      constexpr float r = 1.0f;
      constexpr float b = -1.0f;
      constexpr float t = 1.0f;
      constexpr float n = 0.1f;
      constexpr float f = 1.0f;
  
      angle::Mat4 testMatrix = angle::Mat4::Ortho(l, r, b, t, n, f);
  
      glOrthof(l, r, b, t, n, f);
      EXPECT_GL_NO_ERROR();
  
      angle::Mat4 outputMatrix;
      glGetFloatv(GL_MODELVIEW_MATRIX, outputMatrix.data());
      EXPECT_GL_NO_ERROR();
  
      EXPECT_TRUE(testMatrix.nearlyEqual(0.00001f, outputMatrix));
  }
  
  // Test that GL_INVALID_VALUE is issued if potential divide by zero situations happen for
  // glFrustumf.
  TEST_P(MatrixBuiltinsTest, FrustumNegative)
  {
      glFrustumf(1.0f, 1.0f, 0.0f, 1.0f, 0.1f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
      glFrustumf(0.0f, 1.0f, 1.0f, 1.0f, 0.1f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
      glFrustumf(0.0f, 1.0f, 0.0f, 1.0f, 1.0f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
      glFrustumf(0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
      glFrustumf(0.0f, 1.0f, 0.0f, 1.0f, 1.0f, 0.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
      glFrustumf(0.0f, 1.0f, 0.0f, 1.0f, -1.0f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
  }
  
  // Test that GL_INVALID_VALUE is issued if potential divide by zero situations happen for glOrthof.
  TEST_P(MatrixBuiltinsTest, OrthoNegative)
  {
      glOrthof(1.0f, 1.0f, 0.0f, 1.0f, 0.1f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
      glOrthof(0.0f, 1.0f, 1.0f, 1.0f, 0.1f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
      glOrthof(0.0f, 1.0f, 0.0f, 1.0f, 1.0f, 1.0f);
      EXPECT_GL_ERROR(GL_INVALID_VALUE);
  }
  
  // Test that glOrtho{fx} don't issue error result if near or far is negative.
  TEST_P(MatrixBuiltinsTest, OrthoNegativeNearFar)
  {
      glOrthof(-1.0f, 1.0f, -1.0f, 1.0f, -1.0f, 0.0f);
      EXPECT_GL_NO_ERROR();
      glOrthof(-1.0f, 1.0f, -1.0f, 1.0f, 0.0f, -1.0f);
      EXPECT_GL_NO_ERROR();
      glOrthox(-1, 1, -1, 1, -1, 0);
      EXPECT_GL_NO_ERROR();
      glOrthox(-1, 1, -1, 1, 0, -1);
      EXPECT_GL_NO_ERROR();
  }
  
  ANGLE_INSTANTIATE_TEST_ES1(MatrixBuiltinsTest);
  

Download