kc3-lang/angle/src/tests/test_utils/MultiThreadSteps.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/test_utils/MultiThreadSteps.cpp

• //
  // Copyright 2022 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // MultiThreadSteps.cpp:
  //   Synchronization help for tests that use multiple threads.
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "MultiThreadSteps.h"
  
  #include "angle_test_platform.h"
  #include "gtest/gtest.h"
  #include "util/EGLWindow.h"
  
  namespace angle
  {
  
  void RunLockStepThreads(EGLWindow *window, size_t threadCount, LockStepThreadFunc threadFuncs[])
  {
      constexpr EGLint kPBufferSize = 256;
      RunLockStepThreadsWithSize(window, kPBufferSize, kPBufferSize, threadCount, threadFuncs);
  }
  
  void RunLockStepThreadsWithSize(EGLWindow *window,
                                  EGLint width,
                                  EGLint height,
                                  size_t threadCount,
                                  LockStepThreadFunc threadFuncs[])
  {
      EGLDisplay dpy   = window->getDisplay();
      EGLConfig config = window->getConfig();
  
      // Initialize the pbuffer and context
      EGLint pbufferAttributes[] = {
          EGL_WIDTH, width, EGL_HEIGHT, height, EGL_NONE, EGL_NONE,
      };
  
      std::vector<EGLSurface> surfaces(threadCount);
      std::vector<EGLContext> contexts(threadCount);
  
      // Create N surfaces and shared contexts, one for each thread
      for (size_t threadIndex = 0; threadIndex < threadCount; ++threadIndex)
      {
          surfaces[threadIndex] = eglCreatePbufferSurface(dpy, config, pbufferAttributes);
          EXPECT_EQ(eglGetError(), EGL_SUCCESS);
          EGLint extraAttributes[] = {EGL_CONTEXT_VIRTUALIZATION_GROUP_ANGLE,
                                      static_cast<EGLint>(threadIndex), EGL_NONE};
          if (!IsEGLDisplayExtensionEnabled(dpy, "EGL_ANGLE_context_virtualization"))
          {
              extraAttributes[0] = EGL_NONE;
          }
          contexts[threadIndex] =
              window->createContext(threadIndex == 0 ? EGL_NO_CONTEXT : contexts[0], extraAttributes);
          EXPECT_NE(EGL_NO_CONTEXT, contexts[threadIndex]) << threadIndex;
      }
  
      std::vector<std::thread> threads(threadCount);
  
      // Run the threads
      for (size_t threadIndex = 0; threadIndex < threadCount; ++threadIndex)
      {
          threads[threadIndex] = std::thread(std::move(threadFuncs[threadIndex]), dpy,
                                             surfaces[threadIndex], contexts[threadIndex]);
      }
  
      // Wait for them to finish
      for (size_t threadIndex = 0; threadIndex < threadCount; ++threadIndex)
      {
          threads[threadIndex].join();
  
          // Clean up
          eglDestroySurface(dpy, surfaces[threadIndex]);
          eglDestroyContext(dpy, contexts[threadIndex]);
      }
  }
  }  // namespace angle
  

Download