-
Show log
Commit
-
Hash : 7a85d114
Author :
Date : 2022-03-25T15:01:17
Use [[nodiscard]] on RAII classes Scoped* classes provide an RAII way of adding cleanup/restore state/etc in a robust way. Unfortunatley, it's very easy to mistakenly leave the variable name, leading to the destructor being called immediately instead of at the end of the scope: { ScopedX(parameters); // instead of ScopedX x(parameters); // Code here is run after destructor } The [[nodiscard]] attribute, if specified on the ScopedX class would lead to a warning (turned to error with -Werror). This change does that for classes named *Scoped* in ANGLE. Bug: chromium:1103817 Change-Id: I65c9922c9b4eba1f9c033e093fe8fe534648ab62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552092 Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Files
- DiagnosticsBase.cpp
- DiagnosticsBase.h
- DirectiveHandlerBase.cpp
- DirectiveHandlerBase.h
- DirectiveParser.cpp
- DirectiveParser.h
- ExpressionParser.h
- Input.cpp
- Input.h
- Lexer.cpp
- Lexer.h
- Macro.cpp
- Macro.h
- MacroExpander.cpp
- MacroExpander.h
- Preprocessor.cpp
- Preprocessor.h
- SourceLocation.h
- Token.cpp
- Token.h
- Tokenizer.h
- generate_parser.py
- numeric_lex.h
- preprocessor.l
- preprocessor.y
- preprocessor_lex_autogen.cpp
- preprocessor_tab_autogen.cpp
