kc3-lang/angle/src/libANGLE/renderer/vulkan/FramebufferVk.h

• Show log

  Commit

• Hash : f6c937f8
  Author :
  Date : 2019-04-02T17:04:08
  

  Vulkan: fix masked stencil clear
  
  Previously, masked stencil clear was done by clearing every stencil bit
  to the ClearValue & Mask.  The correct behavior as implemented in this
  change is to clear only the bits that are set in Mask.  This can only be
  done through a draw call, with ClearValue as the stencil reference, and
  Mask as the stencil write mask.
  
  Note: this change relies on the depthClamp Vulkan feature which is not
  available on ARM.
  
  Bug: angleproject:3241
  Change-Id: I0a181c32f881ee813f144e7bdd6f42c8ea6f1966
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548442
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Tobin Ehlis <tobine@google.com>
  

Download

• src/libANGLE/renderer/vulkan/FramebufferVk.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // FramebufferVk.h:
  //    Defines the class interface for FramebufferVk, implementing FramebufferImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_VULKAN_FRAMEBUFFERVK_H_
  #define LIBANGLE_RENDERER_VULKAN_FRAMEBUFFERVK_H_
  
  #include "libANGLE/renderer/FramebufferImpl.h"
  #include "libANGLE/renderer/RenderTargetCache.h"
  #include "libANGLE/renderer/vulkan/BufferVk.h"
  #include "libANGLE/renderer/vulkan/CommandGraph.h"
  #include "libANGLE/renderer/vulkan/vk_cache_utils.h"
  
  namespace rx
  {
  class RendererVk;
  class RenderTargetVk;
  class WindowSurfaceVk;
  
  class FramebufferVk : public FramebufferImpl
  {
    public:
      // Factory methods so we don't have to use constructors with overloads.
      static FramebufferVk *CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state);
  
      // The passed-in SurfaceVK must be destroyed after this FBO is destroyed. Our Surface code is
      // ref-counted on the number of 'current' contexts, so we shouldn't get any dangling surface
      // references. See Surface::setIsCurrent(bool).
      static FramebufferVk *CreateDefaultFBO(RendererVk *renderer,
                                             const gl::FramebufferState &state,
                                             WindowSurfaceVk *backbuffer);
  
      ~FramebufferVk() override;
      void destroy(const gl::Context *context) override;
  
      angle::Result discard(const gl::Context *context,
                            size_t count,
                            const GLenum *attachments) override;
      angle::Result invalidate(const gl::Context *context,
                               size_t count,
                               const GLenum *attachments) override;
      angle::Result invalidateSub(const gl::Context *context,
                                  size_t count,
                                  const GLenum *attachments,
                                  const gl::Rectangle &area) override;
  
      angle::Result clear(const gl::Context *context, GLbitfield mask) override;
      angle::Result clearBufferfv(const gl::Context *context,
                                  GLenum buffer,
                                  GLint drawbuffer,
                                  const GLfloat *values) override;
      angle::Result clearBufferuiv(const gl::Context *context,
                                   GLenum buffer,
                                   GLint drawbuffer,
                                   const GLuint *values) override;
      angle::Result clearBufferiv(const gl::Context *context,
                                  GLenum buffer,
                                  GLint drawbuffer,
                                  const GLint *values) override;
      angle::Result clearBufferfi(const gl::Context *context,
                                  GLenum buffer,
                                  GLint drawbuffer,
                                  GLfloat depth,
                                  GLint stencil) override;
  
      GLenum getImplementationColorReadFormat(const gl::Context *context) const override;
      GLenum getImplementationColorReadType(const gl::Context *context) const override;
      angle::Result readPixels(const gl::Context *context,
                               const gl::Rectangle &area,
                               GLenum format,
                               GLenum type,
                               void *pixels) override;
  
      angle::Result blit(const gl::Context *context,
                         const gl::Rectangle &sourceArea,
                         const gl::Rectangle &destArea,
                         GLbitfield mask,
                         GLenum filter) override;
  
      bool checkStatus(const gl::Context *context) const override;
  
      angle::Result syncState(const gl::Context *context,
                              const gl::Framebuffer::DirtyBits &dirtyBits) override;
  
      angle::Result getSamplePosition(const gl::Context *context,
                                      size_t index,
                                      GLfloat *xy) const override;
      RenderTargetVk *getDepthStencilRenderTarget() const;
  
      // Internal helper function for readPixels operations.
      angle::Result readPixelsImpl(ContextVk *contextVk,
                                   const gl::Rectangle &area,
                                   const PackPixelsParams &packPixelsParams,
                                   VkImageAspectFlagBits copyAspectFlags,
                                   RenderTargetVk *renderTarget,
                                   void *pixels);
  
      gl::Extents getReadImageExtents() const;
  
      const gl::DrawBufferMask &getEmulatedAlphaAttachmentMask() const;
      RenderTargetVk *getColorReadRenderTarget() const;
  
      // This will clear the current write operation if it is complete.
      bool appendToStartedRenderPass(Serial currentQueueSerial, vk::CommandBuffer **commandBufferOut)
      {
          return mFramebuffer.appendToStartedRenderPass(currentQueueSerial, commandBufferOut);
      }
  
      vk::FramebufferHelper *getFramebuffer() { return &mFramebuffer; }
  
      angle::Result startNewRenderPass(ContextVk *context, vk::CommandBuffer **commandBufferOut);
  
      RenderTargetVk *getFirstRenderTarget() const;
      GLint getSamples() const;
  
      const vk::RenderPassDesc &getRenderPassDesc() const { return mRenderPassDesc; }
  
    private:
      FramebufferVk(RendererVk *renderer,
                    const gl::FramebufferState &state,
                    WindowSurfaceVk *backbuffer);
  
      // Helper for appendToStarted/else startNewRenderPass.
      angle::Result getCommandBufferForDraw(ContextVk *contextVk,
                                            vk::CommandBuffer **commandBufferOut,
                                            vk::RecordingMode *modeOut);
  
      // The 'in' rectangles must be clipped to the scissor and FBO. The clipping is done in 'blit'.
      angle::Result blitWithCommand(ContextVk *contextVk,
                                    const gl::Rectangle &readRectIn,
                                    const gl::Rectangle &drawRectIn,
                                    RenderTargetVk *readRenderTarget,
                                    RenderTargetVk *drawRenderTarget,
                                    GLenum filter,
                                    bool colorBlit,
                                    bool depthBlit,
                                    bool stencilBlit,
                                    bool flipSource,
                                    bool flipDest);
  
      // Note that 'copyArea' must be clipped to the scissor and FBO. The clipping is done in 'blit'.
      angle::Result blitWithCopy(ContextVk *contextVk,
                                 const gl::Rectangle &copyArea,
                                 RenderTargetVk *readRenderTarget,
                                 RenderTargetVk *drawRenderTarget,
                                 bool blitDepthBuffer,
                                 bool blitStencilBuffer);
  
      angle::Result blitWithReadback(ContextVk *contextVk,
                                     const gl::Rectangle &copyArea,
                                     VkImageAspectFlagBits aspect,
                                     RenderTargetVk *readRenderTarget,
                                     RenderTargetVk *drawRenderTarget);
  
      angle::Result getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut);
  
      angle::Result clearImpl(const gl::Context *context,
                              gl::DrawBufferMask clearColorBuffers,
                              bool clearDepth,
                              bool clearStencil,
                              const VkClearColorValue &clearColorValue,
                              const VkClearDepthStencilValue &clearDepthStencilValue);
      angle::Result clearWithRenderPassOp(ContextVk *contextVk,
                                          gl::DrawBufferMask clearColorBuffers,
                                          bool clearDepth,
                                          bool clearStencil,
                                          const VkClearColorValue &clearColorValue,
                                          const VkClearDepthStencilValue &clearDepthStencilValue);
      angle::Result clearWithClearAttachments(ContextVk *contextVk,
                                              gl::DrawBufferMask clearColorBuffers,
                                              bool clearDepth,
                                              bool clearStencil,
                                              const VkClearColorValue &clearColorValue,
                                              const VkClearDepthStencilValue &clearDepthStencilValue);
      angle::Result clearWithDraw(ContextVk *contextVk,
                                  gl::DrawBufferMask clearColorBuffers,
                                  bool clearDepth,
                                  bool clearStencil,
                                  VkColorComponentFlags colorMaskFlags,
                                  uint8_t stencilMask,
                                  const VkClearColorValue &clearColorValue,
                                  const VkClearDepthStencilValue &clearDepthStencilValue);
      void updateActiveColorMasks(size_t colorIndex, bool r, bool g, bool b, bool a);
      void updateRenderPassDesc();
  
      WindowSurfaceVk *mBackbuffer;
  
      vk::RenderPassDesc mRenderPassDesc;
      vk::FramebufferHelper mFramebuffer;
      RenderTargetCache<RenderTargetVk> mRenderTargetCache;
  
      // These two variables are used to quickly compute if we need to do a masked clear. If a color
      // channel is masked out, we check against the Framebuffer Attachments (RenderTargets) to see
      // if the masked out channel is present in any of the attachments.
      VkColorComponentFlags mActiveColorComponents;
      gl::DrawBufferMask mActiveColorComponentMasksForClear[4];
      vk::DynamicBuffer mReadPixelBuffer;
      vk::DynamicBuffer mBlitPixelBuffer;
  
      // When we draw to the framebuffer, and the real format has an alpha channel but the format of
      // the framebuffer does not, we need to mask out the alpha channel. This DrawBufferMask will
      // contain the mask to apply to the alpha channel when drawing.
      gl::DrawBufferMask mEmulatedAlphaAttachmentMask;
  };
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_VULKAN_FRAMEBUFFERVK_H_
  

Download