kc3-lang/angle/src/libANGLE/entry_points_utils.h

• Show log

  Commit

• Hash : d43d24bb
  Author :
  Date : 2019-07-30T17:22:20
  

  Capture/Replay: Refactor entry points.
  
  This change does two things:
  
   * only call validation functions once per entry point.
   * move the capture call after the entry point call.
  
  Moving the capure after the call allows us to process the results of
  the call. Also we can clean up the validation double call by doing a
  bit of entry point refactoring. The code changes shouldn't impact the
  resulting code size when capture is disabled.
  
  Bug: angleproject:3611
  Change-Id: I9e74ba0a8266903d3e9d1f2eac6acdd2932e5743
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1706561
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  

Download

• src/libANGLE/entry_points_utils.h

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // entry_point_utils:
  //   These helpers are used in GL/GLES entry point routines.
  
  #ifndef LIBANGLE_ENTRY_POINT_UTILS_H_
  #define LIBANGLE_ENTRY_POINT_UTILS_H_
  
  #include "angle_gl.h"
  #include "common/Optional.h"
  #include "common/PackedEnums.h"
  #include "common/angleutils.h"
  #include "common/mathutil.h"
  #include "libANGLE/entry_points_enum_autogen.h"
  
  namespace gl
  {
  // A template struct for determining the default value to return for each entry point.
  template <EntryPoint EP, typename ReturnType>
  struct DefaultReturnValue;
  
  // Default return values for each basic return type.
  template <EntryPoint EP>
  struct DefaultReturnValue<EP, GLint>
  {
      static constexpr GLint kValue = -1;
  };
  
  // This doubles as the GLenum return value.
  template <EntryPoint EP>
  struct DefaultReturnValue<EP, GLuint>
  {
      static constexpr GLuint kValue = 0;
  };
  
  template <EntryPoint EP>
  struct DefaultReturnValue<EP, GLboolean>
  {
      static constexpr GLboolean kValue = GL_FALSE;
  };
  
  // Catch-all rules for pointer types.
  template <EntryPoint EP, typename PointerType>
  struct DefaultReturnValue<EP, const PointerType *>
  {
      static constexpr const PointerType *kValue = nullptr;
  };
  
  template <EntryPoint EP, typename PointerType>
  struct DefaultReturnValue<EP, PointerType *>
  {
      static constexpr PointerType *kValue = nullptr;
  };
  
  // Overloaded to return invalid index
  template <>
  struct DefaultReturnValue<EntryPoint::GetUniformBlockIndex, GLuint>
  {
      static constexpr GLuint kValue = GL_INVALID_INDEX;
  };
  
  // Specialized enum error value.
  template <>
  struct DefaultReturnValue<EntryPoint::ClientWaitSync, GLenum>
  {
      static constexpr GLenum kValue = GL_WAIT_FAILED;
  };
  
  // glTestFenceNV should still return TRUE for an invalid fence.
  template <>
  struct DefaultReturnValue<EntryPoint::TestFenceNV, GLboolean>
  {
      static constexpr GLboolean kValue = GL_TRUE;
  };
  
  template <EntryPoint EP, typename ReturnType>
  constexpr ANGLE_INLINE ReturnType GetDefaultReturnValue()
  {
      return DefaultReturnValue<EP, ReturnType>::kValue;
  }
  
  #if ANGLE_CAPTURE_ENABLED
  #    define ANGLE_CAPTURE(Func, ...) \
          CaptureCallToFrameCapture("gl" ANGLE_STRINGIFY(Func), Capture##Func, __VA_ARGS__)
  #else
  #    define ANGLE_CAPTURE(...)
  #endif  // ANGLE_CAPTURE_ENABLED
  
  }  // namespace gl
  
  #endif  // LIBANGLE_ENTRY_POINT_UTILS_H_
  

Download