Hash :
d919870f
Author :
Date :
2023-09-14T16:00:07
Vulkan: Do host image copy without holding the share group lock When an application uploads texture data such as with `glTexSubImage2D`, the share group lock is being hold while the data is being copied. Without VK_EXT_host_image_copy, this is a copy to a staging buffer, which may itself be expensive. With VK_EXT_host_image_copy, the cost of the copy is higher and so the lock would be held for a longer duration. This is particularly harmful to applications that spawn a separate thread for texture uploads (as the main thread is unable to make GL calls). This change moves the actual copy call to the tail of the call after the share group lock has been released. As a result: - The upload thread may be a bit slower, but - The copy does not interfere with the main thread, and - The copy does not interfere with the GPU's rendering work. As a result, games that load content seamlessly during gameplay should experience less stutter during texture uploads. Bug: angleproject:8341 Change-Id: I818c4389d4bf828847578da89414623e4b5e844e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4864290 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202
{
"scripts/egl_angle_ext.xml":
"6dfa1582a1b978d62813d8be6e35b306",
"scripts/entry_point_packed_egl_enums.json":
"a72ae855c6b403912103b519139951a1",
"scripts/entry_point_packed_gl_enums.json":
"1c6b036918aabb9822a638fbf33f87f4",
"scripts/generate_entry_points.py":
"5d89d83629a4d055dfbeefaa0322af81",
"scripts/gl_angle_ext.xml":
"3d6d9529c6d0da797652c366ddaa9087",
"scripts/registry_xml.py":
"47ea795fada7b13232c7c9445ccfadb6",
"src/common/entry_points_enum_autogen.cpp":
"1c7b8562eebccb8c980dbb664bb9ff3b",
"src/common/entry_points_enum_autogen.h":
"4f1fc20116d6e5d3a5c23f2e2d2c09fc",
"src/common/frame_capture_utils_autogen.cpp":
"1984fe7b49b4d8fce4decbca540f71e0",
"src/common/frame_capture_utils_autogen.h":
"48a21fd19220368da07e3e211ac8a188",
"src/libANGLE/Context_gl_1_autogen.h":
"47775529739b839b2e58db334050cfb0",
"src/libANGLE/Context_gl_2_autogen.h":
"0bfab6582307ead0da9ddfea1ee4d428",
"src/libANGLE/Context_gl_3_autogen.h":
"b62001f26c3877022a0f6be7e25d990f",
"src/libANGLE/Context_gl_4_autogen.h":
"b4d43e03bb0705969da5b88ee0c821ee",
"src/libANGLE/Context_gles_1_0_autogen.h":
"cb1cfe652972d301a5a98b4f233fcc4f",
"src/libANGLE/Context_gles_2_0_autogen.h":
"bf03a51e6a27817e503bb822868d290e",
"src/libANGLE/Context_gles_3_0_autogen.h":
"d1697421290173be5ca0bc236fd479b4",
"src/libANGLE/Context_gles_3_1_autogen.h":
"17b51301bb3edd475460e8e77ff21a1c",
"src/libANGLE/Context_gles_3_2_autogen.h":
"cf9900e0067812fc6773e8ae4664da33",
"src/libANGLE/Context_gles_ext_autogen.h":
"b0c882fbdb59cbb5a70443cc97508562",
"src/libANGLE/capture/capture_egl_autogen.cpp":
"13734e23717732184a23fe7c872a0016",
"src/libANGLE/capture/capture_egl_autogen.h":
"bd88ae42c440c2782a6ee1d9ca1ede56",
"src/libANGLE/capture/capture_gl_1_autogen.cpp":
"b99498721b4a7b1094ce7e37f9a7481c",
"src/libANGLE/capture/capture_gl_1_autogen.h":
"f4e2d346cf9d0eaf541f3912ce0e635f",
"src/libANGLE/capture/capture_gl_2_autogen.cpp":
"5117dda94f2bbe25625b675f228ffe52",
"src/libANGLE/capture/capture_gl_2_autogen.h":
"1e5b7623566fe1282567e3b31cddbee1",
"src/libANGLE/capture/capture_gl_3_autogen.cpp":
"a113c2fc738f031704e79c46fe3784e3",
"src/libANGLE/capture/capture_gl_3_autogen.h":
"32e061964a2bccfc27dc95eb1a69558e",
"src/libANGLE/capture/capture_gl_4_autogen.cpp":
"91733fd9c3e87cd7a7867cf006b9ed8d",
"src/libANGLE/capture/capture_gl_4_autogen.h":
"82443f9fe7783ae63128e6785b466f61",
"src/libANGLE/capture/capture_gles_1_0_autogen.cpp":
"d203de86be595ac05578ef01b362380a",
"src/libANGLE/capture/capture_gles_1_0_autogen.h":
"141838b474dda3d9a6122e73d3621972",
"src/libANGLE/capture/capture_gles_2_0_autogen.cpp":
"94f04888c6130a39539bcd7cef1244ff",
"src/libANGLE/capture/capture_gles_2_0_autogen.h":
"73d813905e7e938cf11d1722f98de84b",
"src/libANGLE/capture/capture_gles_3_0_autogen.cpp":
"6705cab4f78501fcbca133b169671037",
"src/libANGLE/capture/capture_gles_3_0_autogen.h":
"5b8aacc112d422326de384edc9425326",
"src/libANGLE/capture/capture_gles_3_1_autogen.cpp":
"a266d12eab9874144d2c948755ee1b76",
"src/libANGLE/capture/capture_gles_3_1_autogen.h":
"414b92fe8db95146d8af3c13830e3685",
"src/libANGLE/capture/capture_gles_3_2_autogen.cpp":
"7e6560b176108a579e281f727d75c410",
"src/libANGLE/capture/capture_gles_3_2_autogen.h":
"74ed7366af3a46c0661397cfa29ec6fc",
"src/libANGLE/capture/capture_gles_ext_autogen.cpp":
"158bce866c1a96f27602c6869401c299",
"src/libANGLE/capture/capture_gles_ext_autogen.h":
"937cc0195111a894f32c5423b2918516",
"src/libANGLE/context_private_call_gl_autogen.h":
"40c4fa88e0947ed35a04f2b112b6d708",
"src/libANGLE/context_private_call_gles_autogen.h":
"adb142dca00cbcbc5ebfeff649467fe6",
"src/libANGLE/validationCL_autogen.h":
"0022d0cdb6a9e2ef4a59b71164f62333",
"src/libANGLE/validationEGL_autogen.h":
"4026d8dc0b611e652ac884c1dbfc1a48",
"src/libANGLE/validationES1_autogen.h":
"06762456388a02b9258d6262c1bf4a1b",
"src/libANGLE/validationES2_autogen.h":
"42a3c5a51ed936d5e47ab08ef2a17c9e",
"src/libANGLE/validationES31_autogen.h":
"1ed81afa47644b88a05e1e2bd72b3393",
"src/libANGLE/validationES32_autogen.h":
"03fbf790c2db53d5b677747d40f5bbd6",
"src/libANGLE/validationES3_autogen.h":
"29b3f384a582a4ffd45a898a481839fd",
"src/libANGLE/validationESEXT_autogen.h":
"44ce386575af7dbe3ddcf902d704b15b",
"src/libANGLE/validationGL1_autogen.h":
"6024574ab4afbee4462d4a1f0c897c9a",
"src/libANGLE/validationGL2_autogen.h":
"97cd7b1827278eb9abfbea6fb8cbfd97",
"src/libANGLE/validationGL3_autogen.h":
"64d2792b07817ba99d049d6856a10271",
"src/libANGLE/validationGL4_autogen.h":
"7057fa33057b1d857f902e9db3f14535",
"src/libEGL/libEGL_autogen.cpp":
"af9d60a668dff7f38870d7c4b95f5893",
"src/libEGL/libEGL_autogen.def":
"cdae26a50a3dd1a78dc2b74811a32c32",
"src/libGLESv2/cl_stubs_autogen.h":
"6d880c6b65284192b5842f0e42ad2741",
"src/libGLESv2/egl_context_lock_autogen.h":
"a4294db0bc9c9c69b6dc77776925eb3f",
"src/libGLESv2/egl_ext_stubs_autogen.h":
"253cf14df6bc11adb825fa34ca9bd62e",
"src/libGLESv2/egl_get_labeled_object_data.json":
"2f4148b2ddf34e62670e32c5e6da4937",
"src/libGLESv2/egl_stubs_autogen.h":
"66ee6957861e78ae4090ef6dd735202a",
"src/libGLESv2/entry_points_cl_autogen.cpp":
"9d5320f3b59bb43408aa2646019ceaa0",
"src/libGLESv2/entry_points_cl_autogen.h":
"dde2f94c3004874a7da995dae69da811",
"src/libGLESv2/entry_points_egl_autogen.cpp":
"66320459d4a7d1df208cf9fc15779b80",
"src/libGLESv2/entry_points_egl_autogen.h":
"3bc7a8df9deadd7cfd615d0cfad0c6a8",
"src/libGLESv2/entry_points_egl_ext_autogen.cpp":
"23f30e2c3e1cf0196e838cfecd8ac279",
"src/libGLESv2/entry_points_egl_ext_autogen.h":
"2d005f4cb16dcdd61e08cfec97a12f86",
"src/libGLESv2/entry_points_gl_1_autogen.cpp":
"b40ded56c7002839bce50301ffbc7bc4",
"src/libGLESv2/entry_points_gl_1_autogen.h":
"fc92166806eac5dc285f6a3f06e89d2b",
"src/libGLESv2/entry_points_gl_2_autogen.cpp":
"abd7fae96c2022a96f2f3ce0dbaf0ac2",
"src/libGLESv2/entry_points_gl_2_autogen.h":
"ff42b86b47d77aeb902b6f0f5bd31758",
"src/libGLESv2/entry_points_gl_3_autogen.cpp":
"2293568a5eab5207d362c91ee46e7506",
"src/libGLESv2/entry_points_gl_3_autogen.h":
"88fcf08e2c1aa73819067f28c0fd1eba",
"src/libGLESv2/entry_points_gl_4_autogen.cpp":
"9510df58c1ad699a2b123145904f0877",
"src/libGLESv2/entry_points_gl_4_autogen.h":
"ec1171de9a494598d53bce149ba7b26d",
"src/libGLESv2/entry_points_gles_1_0_autogen.cpp":
"9d9f2bd08db54769bb04ce15118974c7",
"src/libGLESv2/entry_points_gles_1_0_autogen.h":
"1d3aef77845a416497070985a8e9cb31",
"src/libGLESv2/entry_points_gles_2_0_autogen.cpp":
"282985d3f481622d4e184c398114694d",
"src/libGLESv2/entry_points_gles_2_0_autogen.h":
"691c60c2dfed9beca68aa1f32aa2c71b",
"src/libGLESv2/entry_points_gles_3_0_autogen.cpp":
"7565c5307371d42ae528e7ef1a4a96ce",
"src/libGLESv2/entry_points_gles_3_0_autogen.h":
"4ac2582759cdc6a30f78f83ab684d555",
"src/libGLESv2/entry_points_gles_3_1_autogen.cpp":
"23c0a83b83ba21fb4530d1ccfa473a83",
"src/libGLESv2/entry_points_gles_3_1_autogen.h":
"a7327c330a91665fc31accbb78793b42",
"src/libGLESv2/entry_points_gles_3_2_autogen.cpp":
"5f1e7f4b2db9a22dd873dcc5200e52ac",
"src/libGLESv2/entry_points_gles_3_2_autogen.h":
"647f932a299cdb4726b60bbba059f0d2",
"src/libGLESv2/entry_points_gles_ext_autogen.cpp":
"bc3f7f1625e6e0996b1a3f76756fdcf9",
"src/libGLESv2/entry_points_gles_ext_autogen.h":
"f1895ec530403d4a5cee26a2a1637854",
"src/libGLESv2/libGLESv2_autogen.cpp":
"1f9e135e10493da8f7a495b014b17111",
"src/libGLESv2/libGLESv2_autogen.def":
"51d7215acec8b53aa7ea107c235a8f76",
"src/libGLESv2/libGLESv2_no_capture_autogen.def":
"8c09d706e4c2dba8ca77eb2c08491bff",
"src/libGLESv2/libGLESv2_with_capture_autogen.def":
"0d4959936fedaa3d829fe5c61e6e26ab",
"src/libOpenCL/libOpenCL_autogen.cpp":
"10849978c910dc1af5dd4f0c815d1581",
"third_party/EGL-Registry/src/api/egl.xml":
"2056d54ea07156f1988ca1366bdee21a",
"third_party/OpenCL-Docs/src/xml/cl.xml":
"6d0bf09e20a8f8c3ae440d79eda08bf9",
"third_party/OpenGL-Registry/src/xml/gl.xml":
"49f0afe5cac23951c74420e457b0cb23",
"third_party/OpenGL-Registry/src/xml/glx.xml":
"94f3eee4b076801d117804eb466714b7",
"third_party/OpenGL-Registry/src/xml/wgl.xml":
"eae784bf4d1b983a42af5671b140b7c4",
"util/capture/frame_capture_replay_autogen.cpp":
"d2da61e3c43d91abadada2e2ba103cd9"
}