Hash :
baca10b7
Author :
Date :
2021-05-29T16:26:57
CL: Remove object cache and fix multi-threading All CL front end objects used to be cached to be able to determine if an object has been created by the front end to check its validity. The validity is now checked with the existence of an intrinsic value (the dispatch table pointer), which is consistent with the patterns found in Mesa and clvk (though clvk uses a magic value). This allows the removal of all cached objects. The cached objects were stored with std::unique_ptr. These are now gone and all remaining pointers are now custom intrinsic reference count pointers. Also remove global lock which causes deadlocks, e.g. when CL API is called from a separate thread to unlock a blocking call with a user event. Most of the front end is constant and already thread-safe. The ref count is also thread-safe now (atomic). A few remaining locks will follow. Without the global lock it was now possible to make the API reentrant, and to remove the workaround with the Khronos ICD loader to skip ANGLE's OpenCL library. Bug: angleproject:6001 Change-Id: I7d3b52db9011a02cb7ea9ebdeb6e22c4c702ef5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927395 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177
{
"scripts/cl.xml":
"f923201d4ea3e1130763b19fa7faa7a2",
"scripts/egl.xml":
"013c552e6c523abdcf268268ea47e9fe",
"scripts/egl_angle_ext.xml":
"5bcc01462b355d933cf3ada15198fb68",
"scripts/entry_point_packed_egl_enums.json":
"0175304f39aec0f1816760c6460b6d62",
"scripts/entry_point_packed_gl_enums.json":
"4f7b43863a5e61991bba4010db463679",
"scripts/generate_entry_points.py":
"225ece78a0a952b688bf2de8e578454e",
"scripts/gl.xml":
"2a73a58a7e26d8676a2c0af6d528cae6",
"scripts/gl_angle_ext.xml":
"08f74b35d908b7c02b45fdf45572c434",
"scripts/registry_xml.py":
"eb509ae9d21851a359419775615abfcd",
"scripts/wgl.xml":
"c36001431919e1c435f1215a85f7e1db",
"src/common/entry_points_enum_autogen.cpp":
"c12d59977a450452ee72ddf8d767d654",
"src/common/entry_points_enum_autogen.h":
"a194a0bddfd0a239d7090c47a58a0672",
"src/libANGLE/Context_gl_1_autogen.h":
"6be1391ee21b3754d9e9c512255d4c5d",
"src/libANGLE/Context_gl_2_autogen.h":
"d6e875a405946a968dc565e58c13c8c0",
"src/libANGLE/Context_gl_3_autogen.h":
"cf9b149f033b1349409c0b4ee4042bdd",
"src/libANGLE/Context_gl_4_autogen.h":
"428a1039756f64e034812188f11f585f",
"src/libANGLE/Context_gles_1_0_autogen.h":
"51fce95acbf8de72d21255adbbe0e8cd",
"src/libANGLE/Context_gles_2_0_autogen.h":
"443d00d45de147d1d1e3b66846ea0c29",
"src/libANGLE/Context_gles_3_0_autogen.h":
"6c07c41ebd6f1d0ff9d97894332c9e1a",
"src/libANGLE/Context_gles_3_1_autogen.h":
"bb8198422232ca9ceaa06a5d37c3cd92",
"src/libANGLE/Context_gles_3_2_autogen.h":
"48567dca16fd881dfe6d61fee0e3106f",
"src/libANGLE/Context_gles_ext_autogen.h":
"61a76231e54181f93827affd5e65cd6f",
"src/libANGLE/capture/capture_gles_1_0_autogen.cpp":
"7ec7ef8f779b809a45d74b97502c419b",
"src/libANGLE/capture/capture_gles_1_0_autogen.h":
"141838b474dda3d9a6122e73d3621972",
"src/libANGLE/capture/capture_gles_2_0_autogen.cpp":
"8d1c4534e00a4b373a409704e5d6a0c5",
"src/libANGLE/capture/capture_gles_2_0_autogen.h":
"5d5fb0985b28b67ed094e1a4dcc17211",
"src/libANGLE/capture/capture_gles_3_0_autogen.cpp":
"c4fd6b2e604d8bb30953d5ba6021b683",
"src/libANGLE/capture/capture_gles_3_0_autogen.h":
"0f617befef65c1884072ec1244eca0ef",
"src/libANGLE/capture/capture_gles_3_1_autogen.cpp":
"22d19a77da41f82785cb7f580e39b3db",
"src/libANGLE/capture/capture_gles_3_1_autogen.h":
"d39d7cb1086dfeb870d0496c0d7cb79d",
"src/libANGLE/capture/capture_gles_3_2_autogen.cpp":
"1b836129d15ec1f64241b6cfcda61785",
"src/libANGLE/capture/capture_gles_3_2_autogen.h":
"74ed7366af3a46c0661397cfa29ec6fc",
"src/libANGLE/capture/capture_gles_ext_autogen.cpp":
"f8effaef7e3d0dc04ffa0a3fec1182bf",
"src/libANGLE/capture/capture_gles_ext_autogen.h":
"05b6ea355f9770e3e7b5cd9ff66d352c",
"src/libANGLE/capture/frame_capture_replay_autogen.cpp":
"be218060b02f0b07edb9745eb83d0f75",
"src/libANGLE/capture/frame_capture_utils_autogen.cpp":
"dfad80f141010395be7d0ca59ef8ee7a",
"src/libANGLE/capture/frame_capture_utils_autogen.h":
"4405cac61b4f79b893bd40c7fc452397",
"src/libANGLE/validationCL_autogen.h":
"0022d0cdb6a9e2ef4a59b71164f62333",
"src/libANGLE/validationEGL_autogen.h":
"3927fa260ad183fd9193d65b3f8d82c5",
"src/libANGLE/validationES1_autogen.h":
"c8edb0a5b26303bf7c4692b9d0b05c1f",
"src/libANGLE/validationES2_autogen.h":
"1fc4c7017ae5949160ac2561e6d2e22e",
"src/libANGLE/validationES31_autogen.h":
"ed9066cbf406b6f782c058019895c65e",
"src/libANGLE/validationES32_autogen.h":
"522779ad8b54ead483b1c1ec2182f6f8",
"src/libANGLE/validationES3_autogen.h":
"7435b9caddf8787b937c71a54dda96e1",
"src/libANGLE/validationESEXT_autogen.h":
"e2d4cd8003b499d1f2615135097801ec",
"src/libANGLE/validationGL1_autogen.h":
"439f8ea26dc37ee6608100f4c6f9205c",
"src/libANGLE/validationGL2_autogen.h":
"287405881447aff5c6c05d99799c0a63",
"src/libANGLE/validationGL3_autogen.h":
"967a8367b8ed2330cd942f714840491e",
"src/libANGLE/validationGL4_autogen.h":
"db77968c46394c58896f085265182ffa",
"src/libEGL/libEGL_autogen.cpp":
"01cc619c8493952c24f77ac4fa5d7d8a",
"src/libEGL/libEGL_autogen.def":
"3f504d6280dc1d847bc2dedc51fa2640",
"src/libGL/entry_points_gl_1_autogen.cpp":
"d94883448503706b57e770e628a64088",
"src/libGL/entry_points_gl_1_autogen.h":
"f5d504daaf2434ca7d0b8a6bb1afc61a",
"src/libGL/entry_points_gl_2_autogen.cpp":
"2dbb939ef95c1896f38db585e060ebf1",
"src/libGL/entry_points_gl_2_autogen.h":
"6d3e89c9fa3cb69203153c6cfab9e120",
"src/libGL/entry_points_gl_3_autogen.cpp":
"0be17864bf8a6f46c546f568403e355f",
"src/libGL/entry_points_gl_3_autogen.h":
"2dbae6f95a4f72417e50844e45e6f313",
"src/libGL/entry_points_gl_4_autogen.cpp":
"36be27fb77891bf029fa32694e11df70",
"src/libGL/entry_points_gl_4_autogen.h":
"859b5ca20dbbadd7dbb947df91bc09af",
"src/libGL/libGL_autogen.cpp":
"acd2e1984277482df9cc937a83a5df05",
"src/libGL/libGL_autogen.def":
"2789d87b05eea9f53d52e2aff499b785",
"src/libGLESv2/cl_stubs_autogen.h":
"6d880c6b65284192b5842f0e42ad2741",
"src/libGLESv2/egl_ext_stubs_autogen.h":
"2ef3b8d087f2a97f7270b96077c93856",
"src/libGLESv2/egl_get_labeled_object_data.json":
"2f4148b2ddf34e62670e32c5e6da4937",
"src/libGLESv2/egl_stubs_autogen.h":
"6439daa350c1663e71dd0af37dcc91df",
"src/libGLESv2/entry_points_cl_autogen.cpp":
"da26d01245459eb04827b8e0d7f0e58a",
"src/libGLESv2/entry_points_cl_autogen.h":
"dde2f94c3004874a7da995dae69da811",
"src/libGLESv2/entry_points_egl_autogen.cpp":
"e7b708af1c8de435532058eb165d421e",
"src/libGLESv2/entry_points_egl_autogen.h":
"3bc7a8df9deadd7cfd615d0cfad0c6a8",
"src/libGLESv2/entry_points_egl_ext_autogen.cpp":
"5386f7567505e1eceb3b82440d22508b",
"src/libGLESv2/entry_points_egl_ext_autogen.h":
"5ae83ea21ee98991b68847f66793553f",
"src/libGLESv2/entry_points_gles_1_0_autogen.cpp":
"1afe5067e82a30fbf62979c39ccc16f3",
"src/libGLESv2/entry_points_gles_1_0_autogen.h":
"1d3aef77845a416497070985a8e9cb31",
"src/libGLESv2/entry_points_gles_2_0_autogen.cpp":
"19d90121ace06dcba086e38b37287b19",
"src/libGLESv2/entry_points_gles_2_0_autogen.h":
"e682cd8f55110969f68d6a59573e0312",
"src/libGLESv2/entry_points_gles_3_0_autogen.cpp":
"388b421eaadeb3cd752c02dd81091775",
"src/libGLESv2/entry_points_gles_3_0_autogen.h":
"3ae6c2e3e9791a9c7491c1181a46abab",
"src/libGLESv2/entry_points_gles_3_1_autogen.cpp":
"9f553918b3c44a40339546bf9a1ff570",
"src/libGLESv2/entry_points_gles_3_1_autogen.h":
"0cadd684407fad3e288654da30527f78",
"src/libGLESv2/entry_points_gles_3_2_autogen.cpp":
"1de19dab9aa98e399bbe3c405ca9f13e",
"src/libGLESv2/entry_points_gles_3_2_autogen.h":
"647f932a299cdb4726b60bbba059f0d2",
"src/libGLESv2/entry_points_gles_ext_autogen.cpp":
"cbc3a6c31da056ed969811e4a356479d",
"src/libGLESv2/entry_points_gles_ext_autogen.h":
"87bd5438b4e3ca3945f496cc6c142b55",
"src/libGLESv2/libGLESv2_autogen.cpp":
"a26a3ac995ecd9547f0013088d08cc8d",
"src/libGLESv2/libGLESv2_autogen.def":
"14da2fcddd30eab3de94238be1a90933",
"src/libGLESv2/libGLESv2_no_capture_autogen.def":
"6c05af392a3560fb02e47df6389b8f67",
"src/libGLESv2/libGLESv2_with_capture_autogen.def":
"3f91ef2cb2957b3cd4c3bae32a1ecb8b",
"src/libOpenCL/libOpenCL_autogen.cpp":
"10849978c910dc1af5dd4f0c815d1581"
}