kc3-lang/angle/src/common/BitSetIterator_unittest.cpp

• Show log

  Commit

• Hash : b3a60aa9
  Author :
  Date : 2015-08-14T14:44:06
  

  Store iterator bitset by-value instead of by-reference.
  
  The by-reference method was giving strange problems when using a non-
  LValue as argument to IterateBitSet.
  
  BUG=angleproject:1040
  
  Change-Id: Iec10f7256a5b19b239804e0beba4ae675f53f876
  Reviewed-on: https://chromium-review.googlesource.com/293840
  Tested-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/common/BitSetIterator_unittest.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // BitSetIteratorTest:
  //   Test the IterableBitSet class.
  //
  
  #include <gtest/gtest.h>
  
  #include "common/BitSetIterator.h"
  
  using namespace angle;
  
  namespace
  {
  class BitSetIteratorTest : public testing::Test
  {
    protected:
      std::bitset<40> mStateBits;
  };
  
  // Simple iterator test.
  TEST_F(BitSetIteratorTest, Iterator)
  {
      std::set<unsigned long> originalValues;
      originalValues.insert(2);
      originalValues.insert(6);
      originalValues.insert(8);
      originalValues.insert(35);
  
      for (unsigned long value : originalValues)
      {
          mStateBits.set(value);
      }
  
      std::set<unsigned long> readValues;
      for (unsigned long bit : IterateBitSet(mStateBits))
      {
          EXPECT_EQ(1u, originalValues.count(bit));
          EXPECT_EQ(0u, readValues.count(bit));
          readValues.insert(bit);
      }
  
      EXPECT_EQ(originalValues.size(), readValues.size());
  }
  
  // Test an empty iterator.
  TEST_F(BitSetIteratorTest, EmptySet)
  {
      for (unsigned long bit : IterateBitSet(mStateBits))
      {
          UNUSED_TRACE_VARIABLE(bit);
          FAIL() << "Should not be reached";
      }
  }
  
  // Test iterating a result of combining two bitsets.
  TEST_F(BitSetIteratorTest, NonLValueBitset)
  {
      std::bitset<40> otherBits;
  
      mStateBits.set(1);
      mStateBits.set(2);
      mStateBits.set(3);
      mStateBits.set(4);
  
      otherBits.set(0);
      otherBits.set(1);
      otherBits.set(3);
      otherBits.set(5);
  
      std::set<unsigned long> seenBits;
  
      for (unsigned long bit : IterateBitSet(mStateBits & otherBits))
      {
          EXPECT_EQ(0u, seenBits.count(bit));
          seenBits.insert(bit);
          EXPECT_TRUE(mStateBits[bit]);
          EXPECT_TRUE(otherBits[bit]);
      }
  
      EXPECT_EQ((mStateBits & otherBits).count(), seenBits.size());
  }
  
  }  // anonymous namespace
  

Download