Hash :
5bb36cc0
Author :
Date :
2020-02-21T18:25:54
Passing covgl/covgl Fix the following gles1-API implementation codes and some validation functions: glClearColorx glClearDepthx glDepthRangex glGetFixedv glGetTexParameterxv glLineWidthx glPolygonOffsetx glSampleCoveragex glTexParameterx glTexParameterxv ValidateMaterialCommon ValidateFogx ValidateFogxv ValidatePointSizex ValidateRotatex ValidateTexEnvx ValidateTexEnvxv Bug: angleproject:4281 Change-Id: Ia1d9e53c3ffde2bc77b7ca7eaa0d790e8ca43f10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2075341 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166
//
// Copyright 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// TextureParameterTest.cpp: Tests GLES1-specific usage of glTexParameter.
#include "test_utils/ANGLETest.h"
#include "test_utils/gl_raii.h"
#include "util/random_utils.h"
#include <stdint.h>
using namespace angle;
class TextureParameterTest : public ANGLETest
{
protected:
TextureParameterTest()
{
setWindowWidth(32);
setWindowHeight(32);
setConfigRedBits(8);
setConfigGreenBits(8);
setConfigBlueBits(8);
setConfigAlphaBits(8);
setConfigDepthBits(24);
}
};
// Initial state check
TEST_P(TextureParameterTest, InitialState)
{
GLint params[4] = {};
glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, params);
EXPECT_GL_NO_ERROR();
EXPECT_EQ(GL_NEAREST_MIPMAP_LINEAR, params[0]);
glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, params);
EXPECT_GL_NO_ERROR();
EXPECT_EQ(GL_LINEAR, params[0]);
glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, params);
EXPECT_GL_NO_ERROR();
EXPECT_EQ(GL_REPEAT, params[0]);
glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, params);
EXPECT_GL_NO_ERROR();
EXPECT_EQ(GL_REPEAT, params[0]);
glGetTexParameteriv(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, params);
EXPECT_GL_NO_ERROR();
EXPECT_GL_FALSE(params[0]);
glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, params);
EXPECT_GL_NO_ERROR();
EXPECT_EQ(0, params[0]);
EXPECT_EQ(0, params[1]);
EXPECT_EQ(0, params[2]);
EXPECT_EQ(0, params[3]);
}
// Negative test: invalid enum / operation
TEST_P(TextureParameterTest, NegativeEnum)
{
// Invalid target (not supported)
glGetTexParameteriv(GL_TEXTURE_3D, GL_TEXTURE_MIN_FILTER, nullptr);
EXPECT_GL_ERROR(GL_INVALID_ENUM);
// Invalid parameter name
glGetTexParameteriv(GL_TEXTURE_2D, 0, nullptr);
EXPECT_GL_ERROR(GL_INVALID_ENUM);
// Not enough buffer
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, 3);
EXPECT_GL_ERROR(GL_INVALID_OPERATION);
// Not supported in GLES1
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 0);
EXPECT_GL_ERROR(GL_INVALID_ENUM);
}
// Checks that GLES1-specific texture parameters can be set.
TEST_P(TextureParameterTest, Set)
{
GLint params[4] = {};
glTexParameteri(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, GL_TRUE);
EXPECT_GL_NO_ERROR();
glGetTexParameteriv(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, params);
EXPECT_GL_NO_ERROR();
EXPECT_GL_TRUE(params[0]);
GLint cropRect[4] = {10, 20, 30, 40};
glTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, cropRect);
EXPECT_GL_NO_ERROR();
glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, params);
EXPECT_GL_NO_ERROR();
for (int i = 0; i < 4; i++)
{
EXPECT_EQ(cropRect[i], params[i]);
}
}
// Make sure we don't improperly cast an int into a float in ANGLE's internals
TEST_P(TextureParameterTest, IntConversionsAndIntBounds)
{
// Test integers that can't be represented as floats, INT_MIN, and INT_MAX
constexpr GLint kFirstIntThatCannotBeFloat = 16777217;
constexpr unsigned int kParameterLength = 4;
constexpr std::array<GLint, kParameterLength> crop = {
-kFirstIntThatCannotBeFloat, kFirstIntThatCannotBeFloat, std::numeric_limits<GLint>::max(),
std::numeric_limits<GLint>::min()};
glTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, crop.data());
std::array<GLint, kParameterLength> cropStored = {0};
glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, cropStored.data());
ASSERT_EQ(crop, cropStored);
}
// Check that texture parameters can be set by glTexParameterx, glTexParameterxv
// and get by glGetTexParameterxv.
TEST_P(TextureParameterTest, SetFixedPoint)
{
std::array<GLfixed, 4> params = {};
glTexParameterx(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, GL_TRUE);
EXPECT_GL_NO_ERROR();
glGetTexParameterxv(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, params.data());
EXPECT_GL_NO_ERROR();
EXPECT_GL_TRUE(params[0]);
std::array<GLfixed, 4> cropRect = {0x10000, 0x10000, 0x20000, 0x20000};
glTexParameterxv(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, cropRect.data());
EXPECT_GL_NO_ERROR();
glGetTexParameterxv(GL_TEXTURE_2D, GL_TEXTURE_CROP_RECT_OES, params.data());
EXPECT_GL_NO_ERROR();
EXPECT_EQ(cropRect, params);
glTexParameterx(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_REPEAT);
EXPECT_GL_NO_ERROR();
glGetTexParameterxv(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, params.data());
EXPECT_GL_NO_ERROR();
EXPECT_EQ(GL_REPEAT, params[0]);
glTexParameterx(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
EXPECT_GL_NO_ERROR();
glGetTexParameterxv(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, params.data());
EXPECT_GL_NO_ERROR();
EXPECT_EQ(GL_LINEAR, params[0]);
}
ANGLE_INSTANTIATE_TEST_ES1(TextureParameterTest);