Hash :
de71760b
Author :
Date :
2025-03-28T00:00:00
Ensure ValidateGetMemoryObjectParameter entry point consistency Invalid calls must not reach the context. Bug: angleproject:406922380 Change-Id: I6b4fadabe93215839fcd6c8d35952f37d5a6755b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6417007 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
//
// Copyright 2019 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// MemoryObjectTest.cpp : Tests of the GL_EXT_memory_object extension.
#include "test_utils/ANGLETest.h"
#include "test_utils/gl_raii.h"
namespace angle
{
class MemoryObjectTest : public ANGLETest<>
{
protected:
MemoryObjectTest()
{
setWindowWidth(1);
setWindowHeight(1);
setConfigRedBits(8);
setConfigGreenBits(8);
setConfigBlueBits(8);
setConfigAlphaBits(8);
}
};
// glIsMemoryObjectEXT must identify memory objects.
TEST_P(MemoryObjectTest, MemoryObjectShouldBeMemoryObject)
{
ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object"));
// http://anglebug.com/42263921
ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
constexpr GLsizei kMemoryObjectCount = 2;
GLuint memoryObjects[kMemoryObjectCount];
glCreateMemoryObjectsEXT(kMemoryObjectCount, memoryObjects);
EXPECT_FALSE(glIsMemoryObjectEXT(0));
for (GLsizei i = 0; i < kMemoryObjectCount; ++i)
{
EXPECT_TRUE(glIsMemoryObjectEXT(memoryObjects[i]));
}
glDeleteMemoryObjectsEXT(kMemoryObjectCount, memoryObjects);
EXPECT_GL_NO_ERROR();
}
// glImportMemoryFdEXT must fail for handle types that are not file descriptors.
TEST_P(MemoryObjectTest, ShouldFailValidationOnImportFdUnsupportedHandleType)
{
ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object_fd"));
// http://anglebug.com/42263921
ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
{
GLMemoryObject memoryObject;
GLsizei deviceMemorySize = 1;
int fd = -1;
glImportMemoryFdEXT(memoryObject, deviceMemorySize, GL_HANDLE_TYPE_OPAQUE_WIN32_EXT, fd);
EXPECT_GL_ERROR(GL_INVALID_ENUM);
}
EXPECT_GL_NO_ERROR();
}
// Test memory object queries
TEST_P(MemoryObjectTest, MemoryObjectQueries)
{
ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object"));
// http://anglebug.com/42263921
ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
// Validate that configuring or querying memory object zero fails
{
GLint dedicatedMemory = GL_TRUE;
glMemoryObjectParameterivEXT(0, GL_DEDICATED_MEMORY_OBJECT_EXT, &dedicatedMemory);
EXPECT_GL_ERROR(GL_INVALID_VALUE);
glGetMemoryObjectParameterivEXT(0, GL_DEDICATED_MEMORY_OBJECT_EXT, &dedicatedMemory);
EXPECT_GL_ERROR(GL_INVALID_VALUE);
EXPECT_EQ(dedicatedMemory, GL_TRUE);
}
GLMemoryObject memoryObject;
// Validate that the initial state of GL_DEDICATED_MEMORY_OBJECT_EXT is GL_FALSE
{
GLint dedicatedMemory = 0;
glGetMemoryObjectParameterivEXT(memoryObject, GL_DEDICATED_MEMORY_OBJECT_EXT,
&dedicatedMemory);
EXPECT_GL_NO_ERROR();
EXPECT_GL_FALSE(dedicatedMemory);
}
// Change GL_DEDICATED_MEMORY_OBJECT_EXT to GL_TRUE
{
GLint dedicatedMemory = GL_TRUE;
glMemoryObjectParameterivEXT(memoryObject, GL_DEDICATED_MEMORY_OBJECT_EXT,
&dedicatedMemory);
EXPECT_GL_NO_ERROR();
}
// Confirm that GL_DEDICATED_MEMORY_OBJECT_EXT is now TRUE
{
GLint dedicatedMemory = 0;
glGetMemoryObjectParameterivEXT(memoryObject, GL_DEDICATED_MEMORY_OBJECT_EXT,
&dedicatedMemory);
EXPECT_GL_NO_ERROR();
EXPECT_GL_TRUE(dedicatedMemory);
}
EXPECT_GL_NO_ERROR();
}
// Use this to select which configurations (e.g. which renderer, which GLES major version) these
// tests should be run against.
ANGLE_INSTANTIATE_TEST_ES2_AND_ES3(MemoryObjectTest);
} // namespace angle