kc3-lang/angle/src/compiler/preprocessor/Preprocessor.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : Frank Henigman
  Date : 2017-05-03 23:32:29
  Hash : aa7203ef
  Message : Inherit privately from angle::NonCopyable. Make all inheritance from angle::NonCopyable private so the compiler complains about this (admittedly unlikely) code: class Foo: angle::NonCopyable { virtual ~Foo() { ... } }; angle::NonCopyable *p = new Foo; delete p; In the above code ~Foo() is not called, only ~NonCopyable(), because the latter is not virtual. Making it virtual would add overhead to all derived classes which don't already have a virtual method. Also tighten access in NonCopyable, because we can. BUG=angleproject:2026 Change-Id: Id0dc4d959cfb7bb82cf49382118129abb1d3a4f0 Reviewed-on: https://chromium-review.googlesource.com/495352 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

• src/compiler/preprocessor/Preprocessor.h

• //
  // Copyright (c) 2011 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifndef COMPILER_PREPROCESSOR_PREPROCESSOR_H_
  #define COMPILER_PREPROCESSOR_PREPROCESSOR_H_
  
  #include <cstddef>
  
  #include "common/angleutils.h"
  
  namespace pp
  {
  
  class Diagnostics;
  class DirectiveHandler;
  struct PreprocessorImpl;
  struct Token;
  
  struct PreprocessorSettings : private angle::NonCopyable
  {
      PreprocessorSettings() : maxMacroExpansionDepth(1000) {}
      int maxMacroExpansionDepth;
  };
  
  class Preprocessor : angle::NonCopyable
  {
    public:
      Preprocessor(Diagnostics *diagnostics,
                   DirectiveHandler *directiveHandler,
                   const PreprocessorSettings &settings);
      ~Preprocessor();
  
      // count: specifies the number of elements in the string and length arrays.
      // string: specifies an array of pointers to strings.
      // length: specifies an array of string lengths.
      // If length is NULL, each string is assumed to be null terminated.
      // If length is a value other than NULL, it points to an array containing
      // a string length for each of the corresponding elements of string.
      // Each element in the length array may contain the length of the
      // corresponding string or a value less than 0 to indicate that the string
      // is null terminated.
      bool init(size_t count, const char *const string[], const int length[]);
      // Adds a pre-defined macro.
      void predefineMacro(const char *name, int value);
  
      void lex(Token *token);
  
      // Set maximum preprocessor token size
      void setMaxTokenSize(size_t maxTokenSize);
  
    private:
      PreprocessorImpl *mImpl;
  };
  
  }  // namespace pp
  
  #endif  // COMPILER_PREPROCESSOR_PREPROCESSOR_H_