-
Show log
Commit
-
Hash : 8dc9e83e
Author :
Date : 2022-02-16T21:48:53
Translator: Fix RunAtTheEndOfShader w.r.t discard RunAtTheEndOfShader wrapped main() if it ended in discard. However, it didn't account for the fact that the discard instruction could be wrapped in a block. This change makes RunAtTheEndOfShader more conservative w.r.t discard and has it wrap main() on any encounter of discard. The change additionally adds AST validation to ensure transformations don't generate dead code after branches. Test credit to Cody Northrop. Test: GLSLTest_ES3.ConstantConditionGuardingDiscard Test: GLSLTest_ES3.NestedUnconditionalDiscards Bug: angleproject:7033 Change-Id: Ie9d5210a5cfbb13449720a8a3f44666df9443d98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3471014 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- AsNode.h
- BuiltIn.h
- BuiltIn_ESSL_autogen.h
- BuiltIn_complete_autogen.h
- DriverUniform.cpp
- DriverUniform.h
- FindFunction.cpp
- FindFunction.h
- FindMain.cpp
- FindMain.h
- FindPreciseNodes.cpp
- FindPreciseNodes.h
- FindSymbolNode.cpp
- FindSymbolNode.h
- IntermNodePatternMatcher.cpp
- IntermNodePatternMatcher.h
- IntermNode_util.cpp
- IntermNode_util.h
- IntermRebuild.cpp
- IntermRebuild.h
- IntermTraverse.cpp
- IntermTraverse.h
- NodeSearch.h
- NodeType.h
- ReplaceArrayOfMatrixVarying.cpp
- ReplaceArrayOfMatrixVarying.h
- ReplaceClipCullDistanceVariable.cpp
- ReplaceClipCullDistanceVariable.h
- ReplaceShadowingVariables.cpp
- ReplaceShadowingVariables.h
- ReplaceVariable.cpp
- ReplaceVariable.h
- RewriteSampleMaskVariable.cpp
- RewriteSampleMaskVariable.h
- RunAtTheBeginningOfShader.cpp
- RunAtTheBeginningOfShader.h
- RunAtTheEndOfShader.cpp
- RunAtTheEndOfShader.h
- SpecializationConstant.cpp
- SpecializationConstant.h
- Visit.h
