Hash :
7b0bb0f6
Author :
Date :
2023-09-01T13:52:28
Properly "install" program executables
According to GL:
- The program has an executable
- The executable is overwritten during link.
- After a failed link, queries of the executable may return
half-linked information
- On glUseProgram, the executable is installed in the context
- On glUseProgramStages, the executable is installed in the program
pipeline
- After a successful link, the executable is updated wherever the
previous executable of the program was installed.
This change implements exactly the above:
- The program's and the program pipeline's executables are now
shared_ptr. References to an executable in the context and PPO are
also through a shared_ptr. Installing an executable thus translates
to sharing the executable.
- The context and PPOs are made to not reference the program directly,
but work solely through the executable. As a result, the program is
free to create a new executable for link.
With this change, the link job will be free to modify the executable as
necessary because that will not be accessed until the link is done.
Note that previous changes made the backend executable accessed through
the frontend one, and moved all link results to the frontend and backend
executables as appropriate.
Bug: angleproject:6358
Bug: angleproject:8297
Change-Id: Ie636b23ff7420ad284d18b525ec4f5fb559dd9d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4823089
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
//
// Copyright 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Context.inl.h: Defines inline functions of gl::Context class
// Has to be included after libANGLE/Context.h when using one
// of the defined functions
#ifndef LIBANGLE_CONTEXT_INL_H_
#define LIBANGLE_CONTEXT_INL_H_
#include "libANGLE/Context.h"
#include "libANGLE/GLES1Renderer.h"
#include "libANGLE/renderer/ContextImpl.h"
#define ANGLE_HANDLE_ERR(X) \
(void)(X); \
return;
#define ANGLE_CONTEXT_TRY(EXPR) ANGLE_TRY_TEMPLATE(EXPR, ANGLE_HANDLE_ERR)
namespace gl
{
constexpr angle::PackedEnumMap<PrimitiveMode, GLsizei> kMinimumPrimitiveCounts = {{
{PrimitiveMode::Points, 1},
{PrimitiveMode::Lines, 2},
{PrimitiveMode::LineLoop, 2},
{PrimitiveMode::LineStrip, 2},
{PrimitiveMode::Triangles, 3},
{PrimitiveMode::TriangleStrip, 3},
{PrimitiveMode::TriangleFan, 3},
{PrimitiveMode::LinesAdjacency, 2},
{PrimitiveMode::LineStripAdjacency, 2},
{PrimitiveMode::TrianglesAdjacency, 3},
{PrimitiveMode::TriangleStripAdjacency, 3},
}};
ANGLE_INLINE void MarkTransformFeedbackBufferUsage(const Context *context,
GLsizei count,
GLsizei instanceCount)
{
if (context->getStateCache().isTransformFeedbackActiveUnpaused())
{
TransformFeedback *transformFeedback = context->getState().getCurrentTransformFeedback();
transformFeedback->onVerticesDrawn(context, count, instanceCount);
}
}
ANGLE_INLINE void MarkShaderStorageUsage(const Context *context)
{
for (size_t index : context->getStateCache().getActiveShaderStorageBufferIndices())
{
Buffer *buffer = context->getState().getIndexedShaderStorageBuffer(index).get();
if (buffer)
{
buffer->onDataChanged();
}
}
for (size_t index : context->getStateCache().getActiveImageUnitIndices())
{
const ImageUnit &imageUnit = context->getState().getImageUnit(index);
const Texture *texture = imageUnit.texture.get();
if (texture)
{
texture->onStateChange(angle::SubjectMessage::ContentsChanged);
}
}
}
// Return true if the draw is a no-op, else return false.
// If there is no active program for the vertex or fragment shader stages, the results of vertex
// and fragment shader execution will respectively be undefined. However, this is not
// an error. ANGLE will treat this as a no-op.
// A no-op draw occurs if the count of vertices is less than the minimum required to
// have a valid primitive for this mode (0 for points, 0-1 for lines, 0-2 for tris).
ANGLE_INLINE bool Context::noopDraw(PrimitiveMode mode, GLsizei count) const
{
// Make sure any pending link is done before checking whether draw is allowed.
mState.ensureNoPendingLink(this);
if (!mStateCache.getCanDraw())
{
return true;
}
return count < kMinimumPrimitiveCounts[mode];
}
ANGLE_INLINE bool Context::noopMultiDraw(GLsizei drawcount) const
{
return drawcount == 0 || !mStateCache.getCanDraw();
}
ANGLE_INLINE angle::Result Context::syncAllDirtyBits(Command command)
{
constexpr state::DirtyBits kAllDirtyBits = state::DirtyBits().set();
constexpr state::ExtendedDirtyBits kAllExtendedDirtyBits = state::ExtendedDirtyBits().set();
const state::DirtyBits dirtyBits = mState.getDirtyBits();
const state::ExtendedDirtyBits extendedDirtyBits = mState.getExtendedDirtyBits();
ANGLE_TRY(mImplementation->syncState(this, dirtyBits, kAllDirtyBits, extendedDirtyBits,
kAllExtendedDirtyBits, command));
mState.clearDirtyBits();
mState.clearExtendedDirtyBits();
return angle::Result::Continue;
}
ANGLE_INLINE angle::Result Context::syncDirtyBits(const state::DirtyBits bitMask,
const state::ExtendedDirtyBits extendedBitMask,
Command command)
{
const state::DirtyBits dirtyBits = (mState.getDirtyBits() & bitMask);
const state::ExtendedDirtyBits extendedDirtyBits =
(mState.getExtendedDirtyBits() & extendedBitMask);
ANGLE_TRY(mImplementation->syncState(this, dirtyBits, bitMask, extendedDirtyBits,
extendedBitMask, command));
mState.clearDirtyBits(dirtyBits);
mState.clearExtendedDirtyBits(extendedDirtyBits);
return angle::Result::Continue;
}
ANGLE_INLINE angle::Result Context::syncDirtyObjects(const state::DirtyObjects &objectMask,
Command command)
{
return mState.syncDirtyObjects(this, objectMask, command);
}
ANGLE_INLINE angle::Result Context::prepareForDraw(PrimitiveMode mode)
{
if (mGLES1Renderer)
{
ANGLE_TRY(mGLES1Renderer->prepareForDraw(mode, this, &mState, getMutableGLES1State()));
}
ANGLE_TRY(syncDirtyObjects(mDrawDirtyObjects, Command::Draw));
ASSERT(!isRobustResourceInitEnabled() ||
!mState.getDrawFramebuffer()->hasResourceThatNeedsInit());
return syncAllDirtyBits(Command::Draw);
}
ANGLE_INLINE void Context::drawArrays(PrimitiveMode mode, GLint first, GLsizei count)
{
// No-op if count draws no primitives for given mode
if (noopDraw(mode, count))
{
ANGLE_CONTEXT_TRY(mImplementation->handleNoopDrawEvent());
return;
}
ANGLE_CONTEXT_TRY(prepareForDraw(mode));
ANGLE_CONTEXT_TRY(mImplementation->drawArrays(this, mode, first, count));
MarkTransformFeedbackBufferUsage(this, count, 1);
}
ANGLE_INLINE void Context::drawElements(PrimitiveMode mode,
GLsizei count,
DrawElementsType type,
const void *indices)
{
// No-op if count draws no primitives for given mode
if (noopDraw(mode, count))
{
ANGLE_CONTEXT_TRY(mImplementation->handleNoopDrawEvent());
return;
}
ANGLE_CONTEXT_TRY(prepareForDraw(mode));
ANGLE_CONTEXT_TRY(mImplementation->drawElements(this, mode, count, type, indices));
}
ANGLE_INLINE void StateCache::onBufferBindingChange(Context *context)
{
updateBasicDrawStatesError();
updateBasicDrawElementsError();
}
ANGLE_INLINE void Context::bindBuffer(BufferBinding target, BufferID buffer)
{
Buffer *bufferObject =
mState.mBufferManager->checkBufferAllocation(mImplementation.get(), buffer);
// Early return if rebinding the same buffer
if (bufferObject == mState.getTargetBuffer(target))
{
return;
}
mState.setBufferBinding(this, target, bufferObject);
mStateCache.onBufferBindingChange(this);
}
} // namespace gl
#endif // LIBANGLE_CONTEXT_INL_H_