kc3-lang/angle/src/compiler/translator/OutputVulkanGLSL.h

• Show log

  Commit

• Hash : a60e4973
  Author :
  Date : 2020-02-27T20:11:20
  

  Revert "Vulkan:Include precision qualifier in GLSL"
  
  This reverts commit 93e72f5f0eb80b89334ea8fe577b32901a00b5fb.
  
  Reason for revert: This is having a negative impact on gfxbench
  Manhattan 3.1 tests (20-30%) with only a minor improvement (~4%) in TRex offscreen. Pulling out for now and need to re-evaluate best
  solution here.
  
  Original change's description:
  > Vulkan:Include precision qualifier in GLSL
  > 
  > With this initial implementation, it's possible to get precision
  > qualifier mis-matches in the generated GLSL 4.50. According to the
  > spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and
  > Precision Qualifiers":
  > 
  > For the purposes of determining if an output from one shader stage
  > matches an input of the next stage, the precision qualifier need not
  > match.
  > 
  > However, when converted to SPIR-V and run through the shader validation
  > any mismatches will cause shader validation errors. Initially just
  > ignoring those errors with this commit.
  > 
  > Bug: angleproject:3078
  > Change-Id: Ia2b04f90f0a7b6b1302c1b1b3e32bcfd8db9ed49
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749
  > Reviewed-by: Jamie Madill <jmadill@chromium.org>
  > Reviewed-by: Tobin Ehlis <tobine@google.com>
  > Reviewed-by: Tim Van Patten <timvp@google.com>
  > Commit-Queue: Tobin Ehlis <tobine@google.com>
  
  TBR=tobine@google.com,timvp@google.com,jmadill@chromium.org
  
  # Not skipping CQ checks because original CL landed > 1 day ago.
  
  Bug: angleproject:3078
  Change-Id: I84984e2a963bde573f0f1de585001ceb83623c89
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079334
  Reviewed-by: Tobin Ehlis <tobine@google.com>
  Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
  

Download

• src/compiler/translator/OutputVulkanGLSL.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // OutputVulkanGLSL:
  //   Code that outputs shaders that fit GL_KHR_vulkan_glsl.
  //   The shaders are then fed into glslang to spit out SPIR-V (libANGLE-side).
  //   See: https://www.khronos.org/registry/vulkan/specs/misc/GL_KHR_vulkan_glsl.txt
  //
  
  #include "compiler/translator/OutputGLSL.h"
  
  namespace sh
  {
  
  class TOutputVulkanGLSL : public TOutputGLSL
  {
    public:
      TOutputVulkanGLSL(TInfoSinkBase &objSink,
                        ShArrayIndexClampingStrategy clampingStrategy,
                        ShHashFunction64 hashFunction,
                        NameMap &nameMap,
                        TSymbolTable *symbolTable,
                        sh::GLenum shaderType,
                        int shaderVersion,
                        ShShaderOutput output,
                        ShCompileOptions compileOptions);
  
      void writeStructType(const TStructure *structure);
  
      uint32_t nextUnusedBinding() { return mNextUnusedBinding++; }
      uint32_t nextUnusedInputLocation(uint32_t consumedCount)
      {
          uint32_t nextUnused = mNextUnusedInputLocation;
          mNextUnusedInputLocation += consumedCount;
          return nextUnused;
      }
      uint32_t nextUnusedOutputLocation(uint32_t consumedCount)
      {
          uint32_t nextUnused = mNextUnusedOutputLocation;
          mNextUnusedOutputLocation += consumedCount;
          return nextUnused;
      }
  
    protected:
      void writeLayoutQualifier(TIntermTyped *variable) override;
      void writeVariableType(const TType &type,
                             const TSymbol *symbol,
                             bool isFunctionArgument) override;
  
      // Every resource that requires set & binding layout qualifiers is assigned set 0 and an
      // arbitrary binding when outputting GLSL.  Every input/output that requires a location
      // layout qualifiers is assigned an arbitrary location as well.
      //
      // Glslang wrapper modifies set, binding and location decorations in SPIR-V directly.
      uint32_t mNextUnusedBinding;
      uint32_t mNextUnusedInputLocation;
      uint32_t mNextUnusedOutputLocation;
  };
  
  }  // namespace sh
  

Download