Hash :
d8dc3cc2
Author :
Date :
2025-08-02T12:02:20
Remove shared context lock from glVertexAttrib{I}Format
This CL removes shared context lock from glVertexAttribFormat() and
glVertexAttribIFormat() APIs, since they no longer access anything
outside VertexArrayPrivate. The main problem I had run into is
validation code. Before this CL, ValidateIntegerVertexFormat() needs
context's mStateCache for mCachedVertexAttribTypesValidation and
mCachedIntegerVertexAttribTypesValidation. Given these two cached value
are constant after initialization, in this CL, I have moved them to
PrivateStateCache. PrivateStateCache argument is added to
ValidateVertexAttribFormat() and ValidateVertexAttribIFormat() to get
them access to mCachedIntegerVertexAttribTypesValidation.
Bug: b/433331119
Change-Id: Ifc3fbed32b4d3722c335dd2c393bc6519ed0b544
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6822032
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
{
"scripts/egl_angle_ext.xml":
"8389749098fae1d5c832a06b5be51dc1",
"scripts/entry_point_packed_egl_enums.json":
"a72ae855c6b403912103b519139951a1",
"scripts/entry_point_packed_gl_enums.json":
"be374e5742cda78e3189bbeddf9ab6f7",
"scripts/generate_entry_points.py":
"8fe4cc91467ea2f644923527aba3139f",
"scripts/gl_angle_ext.xml":
"da4ecccdd77635f1b0e9d4664f856706",
"scripts/registry_xml.py":
"15b29345de1215203addd0a2a7af530e",
"src/common/entry_points_enum_autogen.cpp":
"0a9f9d2bd8980b6c5071ce59374dad99",
"src/common/entry_points_enum_autogen.h":
"2e9a7d1e6586937e2c0871238be65da2",
"src/common/frame_capture_utils_autogen.cpp":
"740c827e5fa32ac4b6bce98a9225907e",
"src/common/frame_capture_utils_autogen.h":
"92492e0b08610fe09af507a3075fe203",
"src/libANGLE/Context_gles_1_0_autogen.h":
"cb1cfe652972d301a5a98b4f233fcc4f",
"src/libANGLE/Context_gles_2_0_autogen.h":
"63f297a21ff3d1ef014595d70e7f94ae",
"src/libANGLE/Context_gles_3_0_autogen.h":
"35eaf402180d2ddb542d5998d20f787a",
"src/libANGLE/Context_gles_3_1_autogen.h":
"2b81a1dd0d3109090afc073417e0667c",
"src/libANGLE/Context_gles_3_2_autogen.h":
"cf9900e0067812fc6773e8ae4664da33",
"src/libANGLE/Context_gles_ext_autogen.h":
"8fde7b77a6464e2e39dc176b852aa141",
"src/libANGLE/capture/capture_cl_autogen.cpp":
"fa6bf9530e2f1176decc6ceeaf7e3280",
"src/libANGLE/capture/capture_cl_autogen.h":
"b5a611a88b8f373d08c7ce29a4efdb64",
"src/libANGLE/capture/capture_egl_autogen.cpp":
"1b7c8ea9a5b7e19b4d9a44cdf366c306",
"src/libANGLE/capture/capture_egl_autogen.h":
"dddceb4900dd072f9bb9769c5996f71c",
"src/libANGLE/capture/capture_gles_1_0_autogen.cpp":
"d203de86be595ac05578ef01b362380a",
"src/libANGLE/capture/capture_gles_1_0_autogen.h":
"775d4c0d246b7674ab9e7c55b7f8183d",
"src/libANGLE/capture/capture_gles_2_0_autogen.cpp":
"94f04888c6130a39539bcd7cef1244ff",
"src/libANGLE/capture/capture_gles_2_0_autogen.h":
"ad9709f556ceae4366dcff4435eab1ca",
"src/libANGLE/capture/capture_gles_3_0_autogen.cpp":
"6705cab4f78501fcbca133b169671037",
"src/libANGLE/capture/capture_gles_3_0_autogen.h":
"2363abe832f4f2cd4222194dc48cb53c",
"src/libANGLE/capture/capture_gles_3_1_autogen.cpp":
"a266d12eab9874144d2c948755ee1b76",
"src/libANGLE/capture/capture_gles_3_1_autogen.h":
"7a437f522813a83b7b62a4dc5ffec73b",
"src/libANGLE/capture/capture_gles_3_2_autogen.cpp":
"7e6560b176108a579e281f727d75c410",
"src/libANGLE/capture/capture_gles_3_2_autogen.h":
"5e956a19d9e3ba697fb05049c4be9936",
"src/libANGLE/capture/capture_gles_ext_autogen.cpp":
"bbd218a49ad64826c2c0f21172b0b2d6",
"src/libANGLE/capture/capture_gles_ext_autogen.h":
"5dd9236d8638b00ce1966a742f72058d",
"src/libANGLE/context_private_call_autogen.h":
"b12e4b57d792fda9b12600082d6d960f",
"src/libANGLE/validationCL_autogen.h":
"0022d0cdb6a9e2ef4a59b71164f62333",
"src/libANGLE/validationEGL_autogen.h":
"7723ac082391488cb95958e42db221ff",
"src/libANGLE/validationES1_autogen.h":
"66b46adeff0788563f81a89b4c620bd2",
"src/libANGLE/validationES2_autogen.h":
"5bb6268a17bed5eedd8f8924ea1a85e1",
"src/libANGLE/validationES31_autogen.h":
"7de3988b7e07121b005c66eeaf966410",
"src/libANGLE/validationES32_autogen.h":
"67429f628946feab206d1ce9bdcf6fe9",
"src/libANGLE/validationES3_autogen.h":
"8d5b4de6479691eb63a687246491182f",
"src/libANGLE/validationESEXT_autogen.h":
"53eb4d9643f8bcd0fe774e425b23718e",
"src/libEGL/libEGL_autogen.cpp":
"77d82db4a45c2f08108929ef7fe8b698",
"src/libEGL/libEGL_autogen.def":
"01f7efff224d3b48ba9ec640ee350277",
"src/libEGL/libEGL_vulkan_secondaries_autogen.def":
"145504627a80fc96b619ff99981c739e",
"src/libGLESv2/cl_stubs_autogen.h":
"90de40afa78b7574558f8514f53dbab8",
"src/libGLESv2/egl_context_lock_autogen.h":
"8c2f68a26888ff37b5f312763a985b4f",
"src/libGLESv2/egl_ext_stubs_autogen.h":
"0f6d1f1a0232b02f78b98ad05e8fd1f1",
"src/libGLESv2/egl_get_labeled_object_data.json":
"2f4148b2ddf34e62670e32c5e6da4937",
"src/libGLESv2/egl_stubs_autogen.h":
"66ee6957861e78ae4090ef6dd735202a",
"src/libGLESv2/entry_points_cl_autogen.cpp":
"618283212b1ea951b9a561a3766433f2",
"src/libGLESv2/entry_points_cl_autogen.h":
"dde2f94c3004874a7da995dae69da811",
"src/libGLESv2/entry_points_egl_autogen.cpp":
"e77fbdf435820938b7c906947bab9c35",
"src/libGLESv2/entry_points_egl_autogen.h":
"3bc7a8df9deadd7cfd615d0cfad0c6a8",
"src/libGLESv2/entry_points_egl_ext_autogen.cpp":
"6326b915f4459fbc355be97c7bd5b3e6",
"src/libGLESv2/entry_points_egl_ext_autogen.h":
"7799eb7417ec584b9de7480f65f3203c",
"src/libGLESv2/entry_points_gles_1_0_autogen.cpp":
"220ff3048f68031b2f18e9dff8d4473c",
"src/libGLESv2/entry_points_gles_1_0_autogen.h":
"1d3aef77845a416497070985a8e9cb31",
"src/libGLESv2/entry_points_gles_2_0_autogen.cpp":
"740202d6c2896be4fa0d87006c939751",
"src/libGLESv2/entry_points_gles_2_0_autogen.h":
"691c60c2dfed9beca68aa1f32aa2c71b",
"src/libGLESv2/entry_points_gles_3_0_autogen.cpp":
"51c1706c374d56d94b229a407493b6dc",
"src/libGLESv2/entry_points_gles_3_0_autogen.h":
"4ac2582759cdc6a30f78f83ab684d555",
"src/libGLESv2/entry_points_gles_3_1_autogen.cpp":
"115f55b9e74fb3221997755d0b161415",
"src/libGLESv2/entry_points_gles_3_1_autogen.h":
"a7327c330a91665fc31accbb78793b42",
"src/libGLESv2/entry_points_gles_3_2_autogen.cpp":
"188cccac5553256003c4796afb0e840a",
"src/libGLESv2/entry_points_gles_3_2_autogen.h":
"647f932a299cdb4726b60bbba059f0d2",
"src/libGLESv2/entry_points_gles_ext_autogen.cpp":
"cc44b5057c273e781453fd9b3ee271de",
"src/libGLESv2/entry_points_gles_ext_autogen.h":
"5fff81d5a32c658a6f260d56ed0d1776",
"src/libGLESv2/libGLESv2_autogen.cpp":
"730db46e04b1a8a96990fc05a827bfdd",
"src/libGLESv2/libGLESv2_autogen.def":
"1f2834a63af0434a3d57c3bc0428c996",
"src/libGLESv2/libGLESv2_no_capture_autogen.def":
"e2fa461bd9252bf06595bb870edfb207",
"src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def":
"eb3d8aa001816c14dbfd7f7e311b7337",
"src/libGLESv2/libGLESv2_with_capture_autogen.def":
"344dc01e6ea58b2f09c5d2331e1f6efc",
"src/libOpenCL/libOpenCL_autogen.cpp":
"10849978c910dc1af5dd4f0c815d1581",
"third_party/EGL-Registry/src/api/egl.xml":
"2056d54ea07156f1988ca1366bdee21a",
"third_party/OpenCL-Docs/src/xml/cl.xml":
"6d0bf09e20a8f8c3ae440d79eda08bf9",
"third_party/OpenGL-Registry/src/xml/gl.xml":
"d7ed846c15f72e084763c22d70adf1e2",
"third_party/OpenGL-Registry/src/xml/glx.xml":
"6e1745b04a1ac673c60aaa5dd819f3c4",
"third_party/OpenGL-Registry/src/xml/wgl.xml":
"eae784bf4d1b983a42af5671b140b7c4",
"util/capture/frame_capture_replay_autogen.cpp":
"281ce957461793303bc4b62efaf8e445"
}