kc3-lang/angle/src/libANGLE/Surface_unittest.cpp

• Show log

  Commit

• Hash : bf7b95db
  Author :
  Date : 2018-05-01T16:48:21
  

  Create a default framebuffer per surface/context pair on MakeCurrent.
  
  Sharing a gl::Framebuffer object between multiple contexts causes problems if
  contexts are not virtualized because the native framebuffer objects are not
  shared between these contexts.  The FramebufferImpl created should be the glue
  that binds a specific context to a specific surface.
  
  Update the SurfaceImpl implementations to re-create the framebuffer
  object before passing it to FramebufferGL.  No backing resources will be
  re-created.
  
  BUG=angleproject:2464
  
  Change-Id: Id0b13a221c22b71517b25cb5b1ef2392ad2ecdd6
  Reviewed-on: https://chromium-review.googlesource.com/1039985
  Commit-Queue: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/Surface_unittest.cpp

• //
  // Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "gmock/gmock.h"
  #include "gtest/gtest.h"
  #include "libANGLE/angletypes.h"
  #include "libANGLE/AttributeMap.h"
  #include "libANGLE/Config.h"
  #include "libANGLE/ContextState.h"
  #include "libANGLE/State.h"
  #include "libANGLE/Surface.h"
  #include "libANGLE/renderer/FramebufferImpl_mock.h"
  #include "libANGLE/renderer/SurfaceImpl.h"
  #include "tests/angle_unittests_utils.h"
  
  using namespace rx;
  using namespace testing;
  
  namespace
  {
  
  class MockSurfaceImpl : public rx::SurfaceImpl
  {
    public:
      MockSurfaceImpl() : SurfaceImpl(mockState), mockState(nullptr, egl::AttributeMap()) {}
      virtual ~MockSurfaceImpl() { destructor(); }
  
      MOCK_METHOD1(destroy, void(const egl::Display *));
      MOCK_METHOD1(initialize, egl::Error(const egl::Display *));
      MOCK_METHOD2(createDefaultFramebuffer,
                   rx::FramebufferImpl *(const gl::Context *, const gl::FramebufferState &data));
      MOCK_METHOD1(swap, egl::Error(const gl::Context *));
      MOCK_METHOD3(swapWithDamage, egl::Error(const gl::Context *, EGLint *, EGLint));
      MOCK_METHOD5(postSubBuffer, egl::Error(const gl::Context *, EGLint, EGLint, EGLint, EGLint));
      MOCK_METHOD2(querySurfacePointerANGLE, egl::Error(EGLint, void**));
      MOCK_METHOD3(bindTexImage, egl::Error(const gl::Context *context, gl::Texture *, EGLint));
      MOCK_METHOD2(releaseTexImage, egl::Error(const gl::Context *context, EGLint));
      MOCK_METHOD3(getSyncValues, egl::Error(EGLuint64KHR *, EGLuint64KHR *, EGLuint64KHR *));
      MOCK_METHOD1(setSwapInterval, void(EGLint));
      MOCK_CONST_METHOD0(getWidth, EGLint());
      MOCK_CONST_METHOD0(getHeight, EGLint());
      MOCK_CONST_METHOD0(isPostSubBufferSupported, EGLint(void));
      MOCK_CONST_METHOD0(getSwapBehavior, EGLint(void));
      MOCK_METHOD4(getAttachmentRenderTarget,
                   gl::Error(const gl::Context *,
                             GLenum,
                             const gl::ImageIndex &,
                             rx::FramebufferAttachmentRenderTarget **));
  
      MOCK_METHOD0(destructor, void());
  
      egl::SurfaceState mockState;
  };
  
  TEST(SurfaceTest, DestructionDeletesImpl)
  {
      NiceMock<MockEGLFactory> factory;
  
      MockSurfaceImpl *impl = new MockSurfaceImpl;
      EXPECT_CALL(factory, createWindowSurface(_, _, _)).WillOnce(Return(impl));
  
      egl::Config config;
      egl::Surface *surface = new egl::WindowSurface(
          &factory, &config, static_cast<EGLNativeWindowType>(0), egl::AttributeMap());
  
      EXPECT_CALL(*impl, destroy(_)).Times(1).RetiresOnSaturation();
      EXPECT_CALL(*impl, destructor()).Times(1).RetiresOnSaturation();
  
      EXPECT_FALSE(surface->onDestroy(nullptr).isError());
  
      // Only needed because the mock is leaked if bugs are present,
      // which logs an error, but does not cause the test to fail.
      // Ordinarily mocks are verified when destroyed.
      Mock::VerifyAndClear(impl);
  }
  
  } // namespace
  

Download