kc3-lang/angle/src/tests/gl_tests/PBOExtensionTest.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/gl_tests/PBOExtensionTest.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "test_utils/ANGLETest.h"
  
  using namespace angle;
  
  namespace
  {
  constexpr char kVS[] = R"(attribute vec4 aTest;
  attribute vec2 aPosition;
  varying vec4 vTest;
  
  void main()
  {
      vTest        = aTest;
      gl_Position  = vec4(aPosition, 0.0, 1.0);
      gl_PointSize = 1.0;
  })";
  
  constexpr char kFS[] = R"(precision mediump float;
  varying vec4 vTest;
  void main()
  {
      gl_FragColor = vTest;
  })";
  }  // namespace
  
  class PBOExtensionTest : public ANGLETest<>
  {
    protected:
      PBOExtensionTest()
      {
          setWindowWidth(32);
          setWindowHeight(32);
          setConfigRedBits(8);
          setConfigGreenBits(8);
          setConfigBlueBits(8);
          setConfigAlphaBits(8);
      }
  
      void testSetUp() override
      {
          if (IsGLExtensionEnabled("NV_pixel_buffer_object"))
          {
              glGenBuffers(1, &mPBO);
              glBindBuffer(GL_PIXEL_PACK_BUFFER, mPBO);
              glBufferData(GL_PIXEL_PACK_BUFFER, 4 * getWindowWidth() * getWindowHeight(), nullptr,
                           GL_STATIC_DRAW);
              glBindBuffer(GL_PIXEL_PACK_BUFFER, 0);
  
              mProgram = CompileProgram(kVS, kFS);
  
              glGenBuffers(1, &mPositionVBO);
              glBindBuffer(GL_ARRAY_BUFFER, mPositionVBO);
              glBufferData(GL_ARRAY_BUFFER, 128, nullptr, GL_DYNAMIC_DRAW);
              glBindBuffer(GL_ARRAY_BUFFER, 0);
          }
          ASSERT_GL_NO_ERROR();
      }
  
      void testTearDown() override
      {
          glDeleteBuffers(1, &mPBO);
          glDeleteProgram(mProgram);
      }
  
      GLuint mPBO         = 0;
      GLuint mProgram     = 0;
      GLuint mPositionVBO = 0;
  };
  
  TEST_P(PBOExtensionTest, PBOWithOtherTarget)
  {
      if (IsGLExtensionEnabled("NV_pixel_buffer_object"))
      {
          glClearColor(1.0f, 0.0f, 0.0f, 1.0f);
          glClear(GL_COLOR_BUFFER_BIT);
          EXPECT_GL_NO_ERROR();
  
          glBindBuffer(GL_PIXEL_PACK_BUFFER, mPBO);
          glReadPixels(0, 0, 16, 16, GL_RGBA, GL_UNSIGNED_BYTE, 0);
  
          glBindBuffer(GL_PIXEL_PACK_BUFFER, 0);
          glBindBuffer(GL_ARRAY_BUFFER, mPBO);
  
          void *mappedPtr        = glMapBufferRangeEXT(GL_ARRAY_BUFFER, 0, 32, GL_MAP_READ_BIT);
          unsigned char *dataPtr = static_cast<unsigned char *>(mappedPtr);
          EXPECT_GL_NO_ERROR();
  
          EXPECT_EQ(255, dataPtr[0]);
          EXPECT_EQ(0, dataPtr[1]);
          EXPECT_EQ(0, dataPtr[2]);
          EXPECT_EQ(255, dataPtr[3]);
  
          glUnmapBufferOES(GL_ARRAY_BUFFER);
      }
      EXPECT_GL_NO_ERROR();
  }
  
  TEST_P(PBOExtensionTest, PBOWithExistingData)
  {
      if (IsGLExtensionEnabled("NV_pixel_buffer_object"))
      {
          // Clear backbuffer to red
          glClearColor(1.0f, 0.0f, 0.0f, 1.0f);
          glClear(GL_COLOR_BUFFER_BIT);
          EXPECT_GL_NO_ERROR();
  
          // Read 16x16 region from red backbuffer to PBO
          glBindBuffer(GL_PIXEL_PACK_BUFFER, mPBO);
          glReadPixels(0, 0, 16, 16, GL_RGBA, GL_UNSIGNED_BYTE, 0);
  
          // Clear backbuffer to green
          glClearColor(0.0f, 1.0f, 0.0f, 1.0f);
          glClear(GL_COLOR_BUFFER_BIT);
          EXPECT_GL_NO_ERROR();
  
          // Read 16x16 region from green backbuffer to PBO at offset 16
          glReadPixels(0, 0, 16, 16, GL_RGBA, GL_UNSIGNED_BYTE, reinterpret_cast<void *>(16));
          void *mappedPtr        = glMapBufferRangeEXT(GL_PIXEL_PACK_BUFFER, 0, 32, GL_MAP_READ_BIT);
          unsigned char *dataPtr = static_cast<unsigned char *>(mappedPtr);
          EXPECT_GL_NO_ERROR();
  
          // Test pixel 0 is red (existing data)
          EXPECT_EQ(255, dataPtr[0]);
          EXPECT_EQ(0, dataPtr[1]);
          EXPECT_EQ(0, dataPtr[2]);
          EXPECT_EQ(255, dataPtr[3]);
  
          // Test pixel 16 is green (new data)
          EXPECT_EQ(0, dataPtr[16 * 4 + 0]);
          EXPECT_EQ(255, dataPtr[16 * 4 + 1]);
          EXPECT_EQ(0, dataPtr[16 * 4 + 2]);
          EXPECT_EQ(255, dataPtr[16 * 4 + 3]);
  
          glUnmapBufferOES(GL_PIXEL_PACK_BUFFER);
      }
      EXPECT_GL_NO_ERROR();
  }
  
  // Use this to select which configurations (e.g. which renderer, which GLES major version) these
  // tests should be run against.
  ANGLE_INSTANTIATE_TEST_ES2_AND_ES3(PBOExtensionTest);
  

Download