Edit

kc3-lang/angle/src/libANGLE/AttributeMap.cpp

Branch :

  • Show log

    Commit

  • Author : Jamie Madill
    Date : 2017-11-21 19:22:44
    Hash : acf2f3ad
    Message : Apply Chromium style fixes. This addresses several minor code quality issues that are validated in Chromium, but not yet applied to ANGLE: * constructors and destructors must be defined out-of-line * auto is not allowed for simple pointer types * use override everywhere instead of virtual * virtual functions must also be defined out-of-line Slightly reduces binary size for me (~2k on Win, 150k on Linux). Bug: angleproject:1569 Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6 Reviewed-on: https://chromium-review.googlesource.com/779959 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

  • src/libANGLE/AttributeMap.cpp
  • //
    // Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.
    //
    
    #include "libANGLE/AttributeMap.h"
    
    #include "common/debug.h"
    
    namespace egl
    {
    
    AttributeMap::AttributeMap()
    {
    }
    
    AttributeMap::AttributeMap(const AttributeMap &other) = default;
    
    AttributeMap::~AttributeMap() = default;
    
    void AttributeMap::insert(EGLAttrib key, EGLAttrib value)
    {
        mAttributes[key] = value;
    }
    
    bool AttributeMap::contains(EGLAttrib key) const
    {
        return (mAttributes.find(key) != mAttributes.end());
    }
    
    EGLAttrib AttributeMap::get(EGLAttrib key) const
    {
        auto iter = mAttributes.find(key);
        ASSERT(iter != mAttributes.end());
        return iter->second;
    }
    
    EGLAttrib AttributeMap::get(EGLAttrib key, EGLAttrib defaultValue) const
    {
        auto iter = mAttributes.find(key);
        return (mAttributes.find(key) != mAttributes.end()) ? iter->second : defaultValue;
    }
    
    EGLint AttributeMap::getAsInt(EGLAttrib key) const
    {
        return static_cast<EGLint>(get(key));
    }
    
    EGLint AttributeMap::getAsInt(EGLAttrib key, EGLint defaultValue) const
    {
        return static_cast<EGLint>(get(key, static_cast<EGLAttrib>(defaultValue)));
    }
    
    bool AttributeMap::isEmpty() const
    {
        return mAttributes.empty();
    }
    
    std::vector<EGLint> AttributeMap::toIntVector() const
    {
        std::vector<EGLint> ret;
        for (const auto &pair : mAttributes)
        {
            ret.push_back(static_cast<EGLint>(pair.first));
            ret.push_back(static_cast<EGLint>(pair.second));
        }
        ret.push_back(EGL_NONE);
    
        return ret;
    }
    
    AttributeMap::const_iterator AttributeMap::begin() const
    {
        return mAttributes.begin();
    }
    
    AttributeMap::const_iterator AttributeMap::end() const
    {
        return mAttributes.end();
    }
    
    // static
    AttributeMap AttributeMap::CreateFromIntArray(const EGLint *attributes)
    {
        AttributeMap map;
        if (attributes)
        {
            for (const EGLint *curAttrib = attributes; curAttrib[0] != EGL_NONE; curAttrib += 2)
            {
                map.insert(static_cast<EGLAttrib>(curAttrib[0]), static_cast<EGLAttrib>(curAttrib[1]));
            }
        }
        return map;
    }
    
    // static
    AttributeMap AttributeMap::CreateFromAttribArray(const EGLAttrib *attributes)
    {
        AttributeMap map;
        if (attributes)
        {
            for (const EGLAttrib *curAttrib = attributes; curAttrib[0] != EGL_NONE; curAttrib += 2)
            {
                map.insert(curAttrib[0], curAttrib[1]);
            }
        }
        return map;
    }
    }