Edit

kc3-lang/angle/src/libANGLE/LoggingAnnotator.cpp

Branch :

  • Show log

    Commit

  • Author : Jamie Madill
    Date : 2017-11-21 19:22:44
    Hash : acf2f3ad
    Message : Apply Chromium style fixes. This addresses several minor code quality issues that are validated in Chromium, but not yet applied to ANGLE: * constructors and destructors must be defined out-of-line * auto is not allowed for simple pointer types * use override everywhere instead of virtual * virtual functions must also be defined out-of-line Slightly reduces binary size for me (~2k on Win, 150k on Linux). Bug: angleproject:1569 Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6 Reviewed-on: https://chromium-review.googlesource.com/779959 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

  • src/libANGLE/LoggingAnnotator.cpp
  • //
    // Copyright 2017 The ANGLE Project Authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.
    //
    // LoggingAnnotator.cpp: DebugAnnotator implementing logging
    //
    
    #include "libANGLE/LoggingAnnotator.h"
    
    #include <platform/Platform.h>
    
    namespace angle
    {
    
    bool LoggingAnnotator::getStatus()
    {
        return false;
    }
    
    void LoggingAnnotator::logMessage(const gl::LogMessage &msg) const
    {
        auto *plat = ANGLEPlatformCurrent();
        if (plat != nullptr)
        {
            switch (msg.getSeverity())
            {
                case gl::LOG_ERR:
                    plat->logError(plat, msg.getMessage().c_str());
                    break;
                case gl::LOG_WARN:
                    plat->logWarning(plat, msg.getMessage().c_str());
                    break;
                default:
                    UNREACHABLE();
            }
        }
        else
        {
            gl::Trace(msg.getSeverity(), msg.getMessage().c_str());
        }
    }
    
    }  // namespace angle